From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68C71C47404 for ; Mon, 7 Oct 2019 07:31:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E1312084D for ; Mon, 7 Oct 2019 07:31:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VOx7YI5k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E1312084D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fY8KpfJCZV4FskASbDuLJ1Ohzn0yrlKnmJ2fy0kUefA=; b=VOx7YI5kq8gKZ5 m7wQY0fwbOWDh5lHAY6alb66Rli++v/54Wy1lfwKJ+4XwjmOoLEeWTTdGnckzARJS/gVA8SqnZPVd k54R/LlG2DfZ7PikeVH3sOTwlup3dE3lGSHOHZv3Dy55XpQUWwH6VXClgwYJEo3E3ariACUPzKX8Y fXh5sBLdh4sYKO8qZPZiLvWkX177evcbLmWrrEKlnwtXU3tCZsBBQ9k0VkLKV8tm6iMbFisg1jJ9z Lqu7+DD5qdpCObWjr0s8pPHH5UiDoz5KDVQa6LOjlbLQyVFGAS/ridLa0KkDHpoKxwFAaKBnJxLj4 IyUJf7a4EnWrnlD5khSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNU2-0002Xf-Sd; Mon, 07 Oct 2019 07:31:06 +0000 Received: from mail-ot1-f67.google.com ([209.85.210.67]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHNTz-0002XA-GA for linux-arm-kernel@lists.infradead.org; Mon, 07 Oct 2019 07:31:05 +0000 Received: by mail-ot1-f67.google.com with SMTP id 67so10137140oto.3 for ; Mon, 07 Oct 2019 00:31:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TB5Y9SznZoLk3Cl9+KE4TTX9dqxZSiY5fm75Asj4Mjs=; b=twHQ3BPkq13FyrASnVE3NL03Gccxj4uEcYOxFkWj55ZL6AlGTdD43n03aO3UAskNLT UE/8J5Ggol01xmaqH4aNTEllLdGPk15du/254wiBdbJWRORToQNRjGtI2UbR60g1GS+u n6iWjykuXf7wKeR81OAkDjvXRx4dQNh72j4coMwt7GkBfXPSeEjrwnK7EDQ83mEMFM7r RQK2j74+IxLynSaY1/byRQas+JTLRPCBXNNIWSkmpzLQNH6/BbxeQhm7mSFW5VulUBLC ZZdt0TmFCKoxv5DZJDOAgF3uhC8shuv697yEL6encc7rS5yhtMJzlzb1DlTSfo8kGTw9 CoFQ== X-Gm-Message-State: APjAAAVcLLLSjPL+Zk4j+8IiEMXoo8kk6ExRfmG8xVdPOZO9OEKx3jye sInOvisjGlrJDhBvldbfz9SxJc8BkZns5lZpndM= X-Google-Smtp-Source: APXvYqwRM7uJwnHvbblrxA3GV3XCD3dOkjpVemwi/jQS/PJ9OScfdocl+T1L6ngeL0/ZvC8rlrJgbk3ER8m6c6VW4zk= X-Received: by 2002:a9d:6642:: with SMTP id q2mr19868047otm.250.1570433462183; Mon, 07 Oct 2019 00:31:02 -0700 (PDT) MIME-Version: 1.0 References: <20191003000310.17099-1-chris.packham@alliedtelesis.co.nz> <20191003000310.17099-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20191003000310.17099-3-chris.packham@alliedtelesis.co.nz> From: Geert Uytterhoeven Date: Mon, 7 Oct 2019 09:30:50 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] pinctrl: iproc: use unique name for irq chip To: Chris Packham X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_003103_534047_9D85FFF7 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Scott Branden , rayagonda.kokatanur@broadcom.com, Ray Jui , Linus Walleij , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , bcm-kernel-feedback-list@broadcom.com, Marc Zyngier , li.jin@broadcom.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Chris, CC MarcZ On Thu, Oct 3, 2019 at 2:03 AM Chris Packham wrote: > Use the dev_name(dev) for the irqc->name so that we get unique names > when we have multiple instances of this driver. > > Signed-off-by: Chris Packham A while ago, Marc Zyngier pointed out that the irq_chip .name field should contain the device's class name, not the instance's name. Hence the current code is correct? See also "[PATCH 0/4] irqchip: renesas: Use proper irq_chip name and parent" (https://lore.kernel.org/lkml/20190607095858.10028-1-geert+renesas@glider.be/) Note that the irqchip patches in that series have been applied; the gpio patches haven't been applied yet. > --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c > @@ -858,7 +858,7 @@ static int iproc_gpio_probe(struct platform_device *pdev) > struct gpio_irq_chip *girq; > > irqc = &chip->irqchip; > - irqc->name = "bcm-iproc-gpio"; > + irqc->name = dev_name(dev); > irqc->irq_ack = iproc_gpio_irq_ack; > irqc->irq_mask = iproc_gpio_irq_mask; > irqc->irq_unmask = iproc_gpio_irq_unmask; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel