From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79BB7C0650F for ; Tue, 30 Jul 2019 09:23:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E2D4206A2 for ; Tue, 30 Jul 2019 09:23:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sPLe43VL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E2D4206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2MbTK6lCeEnPGkQrFzMKTqqCjKLCGLy9v8fLj2WVX2s=; b=sPLe43VL7Ps2h9 gluSDLiENPc/DzImYYLMQdLQ9PRi8lpAb+hzpG7sh9feF6Kn6noMgfhJCjq1SRqKOqFwzNOuE0EM4 qDfsSCL14A+aH8c51woTGAAK/bybWG9sJw4fbfZtEMXPifiFZGR3A8kFWMo5MQW3M1iFyJSBykUjU UU4HbO8anqxcBww9+XDdliG9X7bsxGzQsjrSY2VkJFiKcQaU6RkLDZ7pGyVU8WkGWc6BYppGqbtvK BaI1k1iQU6FOE++5uu+pP6/ovnUoYdt3dbMHSR/cmcYDwE8uvx1aMsZhvmTc3O8jVhymr722/gyyq roMYLZ6tVR+WkEVuyhPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hsOML-000195-E5; Tue, 30 Jul 2019 09:23:53 +0000 Received: from mail-wm1-f66.google.com ([209.85.128.66]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hsOMF-000156-8P for linux-arm-kernel@lists.infradead.org; Tue, 30 Jul 2019 09:23:48 +0000 Received: by mail-wm1-f66.google.com with SMTP id p74so56392686wme.4 for ; Tue, 30 Jul 2019 02:23:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IVKY/KEUXjTWN+bYP3M9li6aLpvlVa9sTGtOM6kUeiU=; b=jrZzXMa9QzncuFEfMkqV0/pYFfU++FgCcDE3hAWwZyuFPj1stJ4+ziIqEQBkm5/h0B hDr0GehgOeDwPLYIibDHwr+y3zmxRJr3eAk+ejnCDJAqxVOVv01tluzGhKMHAR1R9Ueu v4JHDq2YcLXs/9cVHOuEXohs6pzF0MxWWtyEYJFiAbeaT7wI0aAEoC5uPhcl8TwJFUJ4 hjReBHEbTMbGx/XWppYeOQVRdxnBxJqYMyiuvhUTuuP2wUycrBubcLLuTutfIyXAxFx4 EPI3Zc+WzaPLtgx0HPG9aKUB02nLu8Npp+prtLD3v+3goTaNew6ufIiujRNUKarXtRGI CnMA== X-Gm-Message-State: APjAAAVQSsEiCGDXNxQ8c25Sq1TsBfoH2ytko6nQggshRBoTCRSQDpyo 5+hO0Qg4RZf2sO6MkhFdDDG8BIy93TS0cvdoPjo= X-Google-Smtp-Source: APXvYqyFeh5CWq4lx5qP/Lw6wykdQGeWP2Ty9SqBR2iBLJHWuDQBk7YcFYjciyT2+R2xAH4drl8Z8kyjyYjieNyymmA= X-Received: by 2002:a05:600c:254b:: with SMTP id e11mr97212692wma.171.1564478625893; Tue, 30 Jul 2019 02:23:45 -0700 (PDT) MIME-Version: 1.0 References: <1563905015-2911-1-git-send-email-ykaneko0929@gmail.com> In-Reply-To: From: Geert Uytterhoeven Date: Tue, 30 Jul 2019 11:23:34 +0200 Message-ID: Subject: Re: [PATCH] arm64: dts: renesas: ulcb-kf: sort nodes To: Yoshihiro Kaneko X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190730_022347_439004_F37EF819 X-CRM114-Status: GOOD ( 16.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , Simon Horman , Magnus Damm , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 30, 2019 at 11:14 AM Geert Uytterhoeven wrote: > On Tue, Jul 23, 2019 at 8:03 PM Yoshihiro Kaneko wrote: > > Sort nodes. > > > > If node address is present > > * Sort by node address, grouping all nodes with the same compat string > > and sorting the group alphabetically. > > Else > > * Sort alphabetically > > > > This should not have any run-time effect. > > > > Signed-off-by: Yoshihiro Kaneko > > You forgot to sort the i2c slave nodes. > As this kind of patches is hard to rebase and rework, I'm fixing that up while > applying: > > --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi > @@ -83,6 +83,56 @@ > }; > > &i2c2 { > + i2cswitch2: i2c-switch@71 { > + compatible = "nxp,pca9548"; > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <0x71>; > + reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>; > + > + /* Audio_SDA, Audio_SCL */ > + i2c@7 { > + #address-cells = <1>; > + #size-cells = <0>; > + reg = <7>; > + > + pcm3168a: audio-codec@44 { > + #sound-dai-cells = <0>; > + compatible = "ti,pcm3168a"; > + reg = <0x44>; > + clocks = <&clksndsel>; > + clock-names = "scki"; > + > + VDD1-supply = <&snd_3p3v>; > + VDD2-supply = <&snd_3p3v>; > + VCCAD1-supply = <&snd_vcc5v>; > + VCCAD2-supply = <&snd_vcc5v>; > + VCCDA1-supply = <&snd_vcc5v>; > + VCCDA2-supply = <&snd_vcc5v>; > + > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + mclk-fs = <512>; > + port@0 { > + reg = <0>; > + pcm3168a_endpoint_p: endpoint { > + > remote-endpoint = <&rsnd_for_pcm3168a_play>; > + clocks = <&clksndsel>; > + }; > + }; > + port@1 { > + reg = <1>; > + pcm3168a_endpoint_c: endpoint { > + > remote-endpoint = <&rsnd_for_pcm3168a_capture>; > + clocks = <&clksndsel>; > + }; > + }; > + }; > + }; > + }; > + }; > + > /* U11 */ > gpio_exp_74: gpio@74 { > compatible = "ti,tca9539"; > @@ -153,56 +203,6 @@ > interrupt-parent = <&gpio6>; > interrupts = <4 IRQ_TYPE_EDGE_FALLING>; > }; > - > - i2cswitch2: i2c-switch@71 { > - compatible = "nxp,pca9548"; > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <0x71>; > - reset-gpios = <&gpio5 3 GPIO_ACTIVE_LOW>; > - > - /* Audio_SDA, Audio_SCL */ > - i2c@7 { > - #address-cells = <1>; > - #size-cells = <0>; > - reg = <7>; > - > - pcm3168a: audio-codec@44 { > - #sound-dai-cells = <0>; > - compatible = "ti,pcm3168a"; > - reg = <0x44>; > - clocks = <&clksndsel>; > - clock-names = "scki"; > - > - VDD1-supply = <&snd_3p3v>; > - VDD2-supply = <&snd_3p3v>; > - VCCAD1-supply = <&snd_vcc5v>; > - VCCAD2-supply = <&snd_vcc5v>; > - VCCDA1-supply = <&snd_vcc5v>; > - VCCDA2-supply = <&snd_vcc5v>; > - > - ports { > - #address-cells = <1>; > - #size-cells = <0>; > - mclk-fs = <512>; > - port@0 { > - reg = <0>; > - pcm3168a_endpoint_p: endpoint { > - > remote-endpoint = <&rsnd_for_pcm3168a_play>; > - clocks = <&clksndsel>; > - }; > - }; > - port@1 { > - reg = <1>; > - pcm3168a_endpoint_c: endpoint { > - > remote-endpoint = <&rsnd_for_pcm3168a_capture>; > - clocks = <&clksndsel>; > - }; > - }; > - }; > - }; > - }; > - }; > }; > > &i2c4 { > and the second i2c bus, too, of course: --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi @@ -206,6 +206,14 @@ }; &i2c4 { + i2cswitch4: i2c-switch@71 { + compatible = "nxp,pca9548"; + #address-cells = <1>; + #size-cells = <0>; + reg = <0x71>; + reset-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; + }; + gpio_exp_76: gpio@76 { compatible = "ti,tca9539"; reg = <0x76>; @@ -225,14 +233,6 @@ interrupt-parent = <&gpio5>; interrupts = <9 IRQ_TYPE_EDGE_FALLING>; }; - - i2cswitch4: i2c-switch@71 { - compatible = "nxp,pca9548"; - #address-cells = <1>; - #size-cells = <0>; - reg = <0x71>; - reset-gpios = <&gpio3 15 GPIO_ACTIVE_LOW>; - }; }; &ohci0 { Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel