From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1201C48BC2 for ; Mon, 7 Jun 2021 09:25:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 81E4860232 for ; Mon, 7 Jun 2021 09:25:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 81E4860232 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sAphQmp7+oa3V1+RIhACvmUeKbZVrwbcZp94PJ1qpvM=; b=x+/TcMCWgPinDy 3L8hMp4vaXPUVn/a1s+96rfgn59e2qT3lWgZtJEygx1N9+l4ur89Odn9zvoRNYOr2aqWuC9I8RXb3 Ul/xqMm7dSyEyYx8VemAsW0ZFOSgNQBU6epHmR/TBMqmCG3jgUhCAFnAf1Az5JK1NzGrNX+qi+4E2 5v7kCcNIegoP9E6dNALKYND4VUMZDEgfBsKRpv9Bdt++GWhO1Lo8abawaCY+lqys3ARfcfTPhGbI6 +QTXj0bEPhTWli936Gr9ZosKFjpvjq+n2vhTulkOYULssEKcNmHTn+gtIimie6GaOYDIEyCIn5JDm Qqx/xwmbJN8uqN/ckyIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqBSq-002YeK-AH; Mon, 07 Jun 2021 09:22:33 +0000 Received: from mail-ua1-f45.google.com ([209.85.222.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lqB0a-002QLb-VF; Mon, 07 Jun 2021 08:53:23 +0000 Received: by mail-ua1-f45.google.com with SMTP id l12so9292621uai.0; Mon, 07 Jun 2021 01:53:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=y7XwbZyFAy9rqQo5J7t8DRS+d/mueoOLl5p+cSQb+8Y=; b=hKBndH/5jrn5HhJNu1AcNO3JoGuCUsqjDgN34Df7a6h04SNBYeNU66G1XBjjDa/g8d aXxgvmRCSxjjeKuIw8sKMeUl4CBJ2tJt2mPh0104rwQ44ovGgk+AZoXw1Mw20laLb0QV Zw1n45neJGXonqUP2tENLz6VZeaXNdZB5h9MjRBuJstx3Z2Je529HZ9V+E6AwIwpeBva SoIQ+BJpwF+ZP+hYbF5PBLhvFis77WtR8F2DQKVEr3azyBQrHL4a97dU6i78OPmj9NHa ZMns71LYVkgmSuf5f4inEHv934G7EBbnUiS2Ot683q8TvLm13AXT0hxL6xk44bWraZvK xH+w== X-Gm-Message-State: AOAM531wZ+zwERp6y/RqjDHaGktXtbsfhYmOa6zVnnu5TS19DaQf95DR gj72G0THqn7MyBzoF+DuiO4RTuaQy06Wkg69Krc= X-Google-Smtp-Source: ABdhPJw70xfmNroh3KIu5QGmqKsYwQ+PKLyHQ50n7DeatYgE4iGl6TNz+FWGTOL2BBcrgRRRH99rMYwIPPT469OpB6M= X-Received: by 2002:ab0:63d9:: with SMTP id i25mr6682382uap.106.1623055999326; Mon, 07 Jun 2021 01:53:19 -0700 (PDT) MIME-Version: 1.0 References: <20210604064916.26580-1-rppt@kernel.org> <20210604064916.26580-9-rppt@kernel.org> In-Reply-To: <20210604064916.26580-9-rppt@kernel.org> From: Geert Uytterhoeven Date: Mon, 7 Jun 2021 10:53:08 +0200 Message-ID: Subject: Re: [PATCH v2 8/9] mm: replace CONFIG_NEED_MULTIPLE_NODES with CONFIG_NUMA To: Mike Rapoport Cc: Andrew Morton , Arnd Bergmann , Ivan Kokshaysky , Jonathan Corbet , Matt Turner , Mike Rapoport , Richard Henderson , Vineet Gupta , kexec@lists.infradead.org, alpha , Linux-Arch , Linux ARM , "open list:DOCUMENTATION" , "linux-ia64@vger.kernel.org" , Linux Kernel Mailing List , linux-m68k , "open list:BROADCOM NVRAM DRIVER" , Linux MM , linux-riscv , linux-s390 , Linux-sh list , arcml , "open list:TENSILICA XTENSA PORT (xtensa)" , linuxppc-dev , sparclinux X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210607_015321_136219_B0E223FC X-CRM114-Status: GOOD ( 19.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike, On Fri, Jun 4, 2021 at 8:50 AM Mike Rapoport wrote: > From: Mike Rapoport > > After removal of DISCINTIGMEM the NEED_MULTIPLE_NODES and NUMA > configuration options are equivalent. > > Drop CONFIG_NEED_MULTIPLE_NODES and use CONFIG_NUMA instead. > > Done with > > $ sed -i 's/CONFIG_NEED_MULTIPLE_NODES/CONFIG_NUMA/' \ > $(git grep -wl CONFIG_NEED_MULTIPLE_NODES) > $ sed -i 's/NEED_MULTIPLE_NODES/NUMA/' \ > $(git grep -wl NEED_MULTIPLE_NODES) > > with manual tweaks afterwards. > > Signed-off-by: Mike Rapoport Thanks for your patch! As you dropped the following hunk from v2 of PATCH 5/9, there's now one reference left of CONFIG_NEED_MULTIPLE_NODES (plus the discontigmem comment): -diff --git a/mm/memory.c b/mm/memory.c -index f3ffab9b9e39157b..fd0ebb63be3304f5 100644 ---- a/mm/memory.c -+++ b/mm/memory.c -@@ -90,8 +90,7 @@ - #warning Unfortunate NUMA and NUMA Balancing config, growing page-frame for last_cpupid. - #endif - --#ifndef CONFIG_NEED_MULTIPLE_NODES --/* use the per-pgdat data instead for discontigmem - mbligh */ -+#ifdef CONFIG_FLATMEM - unsigned long max_mapnr; - EXPORT_SYMBOL(max_mapnr); - Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel