From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B97CC43381 for ; Thu, 14 Feb 2019 10:55:12 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1CB43222A4 for ; Thu, 14 Feb 2019 10:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iYRGHeD+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1CB43222A4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9RN6D6PBMa/Z+U6gdCawd3ZRpimWEMRQyLYsqs9oD00=; b=iYRGHeD+7e5mcB 5ygPORRz887gdUTTWBEdHjKc05o9GrKwlApFPhoZu9OMAPiWD1V7fI+cAxxgngpOOr0I9KJML0tvI ClgBto5qdALCp8X4H12cFUu7sX/+s1Hcnjw9TCEvsnHw7/Y212RblnrGo90tkPoJ9CPKVMwDY5Scx +hYnL4o+KTw+BCccv/PC+2pvGUvoZ6WJB6ecB7GlWmSmlnCMqXwJLMUPInYHOYIf1lKcTHn+6c8Aw l8idEjBlc4+TdkguZ77rKAw8uBn063ChDsGpuFCGruJ4keMOBCghlVOOL5RjxjuEgswn1Hc8/fDL1 Hjn/u6mfRx/e50luY6Iw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1guEfd-0002KW-Sj; Thu, 14 Feb 2019 10:55:09 +0000 Received: from mail-ua1-f68.google.com ([209.85.222.68]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1guEfW-00017a-Q5; Thu, 14 Feb 2019 10:55:05 +0000 Received: by mail-ua1-f68.google.com with SMTP id s15so1866391uap.6; Thu, 14 Feb 2019 02:55:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0FVphaqkdujewH8xkqyrrOZQTGaRwWmRxSe5PedLOc8=; b=QCjAnAFl7by6lmfAV1WoM0pqtJ2YbpPey9qLnr+3kaV6YupNtccrYV9eGt+/YH+32d 5ADgB0Yc+xa8gNzwVm7tOO7nTTFg4EhBZA0zWugqmEL+shvut7gMdTk2InRUUpFtOBl/ j4we6PGWbVZKm/uAFtrswGSPvfMlTduJjBW6B9rmv2Pl7iJTsKTUFou5UOZOIyX3HTR3 qObTfNO1L4wUamtTxyIrX0UD9JZ4q+IwN0KRjmfkMXxYWkiLZ9iq/VO8UaDWcu9Jry6+ RDoFZdHp3gQi3mbUjnGYL3HVK3QJWChOsJXNr62vyQ0xDoymlqda06jAszl/9SC+lZpt Ig+g== X-Gm-Message-State: AHQUAua4PgNEb0RIO89TwVUmtAxzeSgXju+W3nZqVw9mnoeh15a4lYaK mBSi+5FNjkCwa7wmh87kGF76cSgKNq/zWELr7zg= X-Google-Smtp-Source: AHgI3IbzhzuzEySYHwSbJTqDaXLapQMTOW53oPTxOn4RxgH5lrV4tpWGJZxYzqt5buLzgH3+IW1GydrsaXAApWWXHYU= X-Received: by 2002:a9f:2726:: with SMTP id a35mr1587802uaa.75.1550141699426; Thu, 14 Feb 2019 02:54:59 -0800 (PST) MIME-Version: 1.0 References: <1550095217-12047-1-git-send-email-longman@redhat.com> <1550095217-12047-3-git-send-email-longman@redhat.com> In-Reply-To: <1550095217-12047-3-git-send-email-longman@redhat.com> From: Geert Uytterhoeven Date: Thu, 14 Feb 2019 11:54:47 +0100 Message-ID: Subject: Re: [PATCH v4 2/3] locking/rwsem: Remove rwsem-spinlock.c & use rwsem-xadd.c for all archs To: Waiman Long , Christoph Hellwig X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190214_025503_703039_7E7FD98B X-CRM114-Status: GOOD ( 13.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-ia64@vger.kernel.org" , Linux-sh list , Peter Zijlstra , Will Deacon , Linux Kernel Mailing List , "H. Peter Anvin" , sparclinux , linux-riscv@lists.infradead.org, Linux-Arch , linux-s390 , Davidlohr Bueso , linux-c6x-dev@linux-c6x.org, "open list:QUALCOMM HEXAGON..." , the arch/x86 maintainers , Ingo Molnar , "moderated list:H8/300 ARCHITECTURE" , linux-xtensa@linux-xtensa.org, Arnd Bergmann , linux-um@lists.infradead.org, linuxppc-dev , linux-m68k , Openrisc , Borislav Petkov , Thomas Gleixner , Linux ARM , Parisc List , Linus Torvalds , linux-mips@vger.kernel.org, alpha , nios2-dev@lists.rocketboards.org, Andrew Morton , Tim Chen Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Feb 13, 2019 at 11:01 PM Waiman Long wrote: > Currently, we have two different implementation of rwsem: > 1) CONFIG_RWSEM_GENERIC_SPINLOCK (rwsem-spinlock.c) > 2) CONFIG_RWSEM_XCHGADD_ALGORITHM (rwsem-xadd.c) > > As we are going to use a single generic implementation for rwsem-xadd.c > and no architecture-specific code will be needed, there is no point > in keeping two different implementations of rwsem. In most cases, the > performance of rwsem-spinlock.c will be worse. It also doesn't get all > the performance tuning and optimizations that had been implemented in > rwsem-xadd.c over the years. > > For simplication, we are going to remove rwsem-spinlock.c and make all > architectures use a single implementation of rwsem - rwsem-xadd.c. > > All references to RWSEM_GENERIC_SPINLOCK and RWSEM_XCHGADD_ALGORITHM > in the code are removed. > > Suggested-by: Peter Zijlstra > Signed-off-by: Waiman Long Note that this conflicts with "[PATCH 03/11] kernel/locks: consolidate RWSEM_GENERIC_* options" https://lore.kernel.org/lkml/20190213174005.28785-4-hch@lst.de/ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel