From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF64CC48BD4 for ; Tue, 25 Jun 2019 13:23:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8DFC8208CA for ; Tue, 25 Jun 2019 13:23:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="WFRMgnPO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8DFC8208CA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t3QatRvJcN3JqhLsB4C2sZ5z26axW3ze/NRhnd1vJVs=; b=WFRMgnPOMgEX2n Le4Q8QrMxVXqsOmUivcD0qxCVKJSgIRUJ5z8dyOaM5q8aOs5aRJh7dJR4DDy3us65qtJ2IzEf/QPf +KfU9s5jXs5Pv3/isuFLAqAkxH0H5K1NiMshCeyp8w6ciA+eP8Jv8g+yGCXE37yZTSwo/+JnhY81i Azcf3at3BotdQfz3HBhFiKtmZqKS4HBaRjIpCRwDU4nf96sp8TFYDjrEY6fv6VZ319vtPb8UMnepx c1PrraDk9p8Ka1qlAVMR+4+OrN53zfECaQa1kBCe8XgMwKMp3TnqTNitIIxy4eD+gLh2qvKbj006C 07CSOrs2gaVYLwtmzYEg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hflQF-0006HG-0v; Tue, 25 Jun 2019 13:23:43 +0000 Received: from mail-ot1-f68.google.com ([209.85.210.68]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hflQB-0006FM-99 for linux-arm-kernel@lists.infradead.org; Tue, 25 Jun 2019 13:23:40 +0000 Received: by mail-ot1-f68.google.com with SMTP id 43so12396985otf.8 for ; Tue, 25 Jun 2019 06:23:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=V/HoNCBy6oaaKzj/AJjkqXaJhdI4AhH9UXxBfsvy6QM=; b=sGUvHZwNftJuqxpXUKBZARCr7nLRos/7+j9ssTePomLv98R46m8eXeGTi75CMHYoMt bemmhQgte93XnshOaXJ5Z6W1dWOUf0ZBMEhSXJ/Fza2x2TzOZeL6uCzep0r5kcyZYiL2 jsGD03t2ic9g+S4UjgOgcnNdEVkF1jwZHhwfztF/92P0HlW4Q0U8XWH11WpmXgqJyUFz 7+9w8XDUu4eJhegn6Pb9joYxeNEIVL7M1TWuHXNvaD0SYKu/VcU3AMRGyeU7idGBHn4x +9Nw6lQw4rcNk0sR3hFdSbx8aG4of9Ugrdp4Vt9q89+UYZZ4WplwQalRPqxMLJ06Tq7w fpyg== X-Gm-Message-State: APjAAAUiKKjQhOSXxuiGcHBu2kbe6OfyGq299JiXlkUF0gLLk57CJeXE /XxlYfOE+MeCR7L4cHOOQKznemEtyWipOb3LO9o= X-Google-Smtp-Source: APXvYqwCh+xqlirpWox1xCYMlxP741knDKudJm0tvoxCfTOQbqPl8UcUqa7otd/VmaNSbjNiooF5BU1EPzx+vu0mf10= X-Received: by 2002:a9d:2f03:: with SMTP id h3mr91466602otb.107.1561469016656; Tue, 25 Jun 2019 06:23:36 -0700 (PDT) MIME-Version: 1.0 References: <20190625124924.ubpi3pxwggbz5cbw@localhost> In-Reply-To: <20190625124924.ubpi3pxwggbz5cbw@localhost> From: Geert Uytterhoeven Date: Tue, 25 Jun 2019 15:23:24 +0200 Message-ID: Subject: Re: [GIT PULL] Renesas ARM Based SoC Updates for v5.3 To: Olof Johansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190625_062339_323550_9DE9F45B X-CRM114-Status: GOOD ( 13.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Kevin Hilman , Magnus Damm , Linux-Renesas , arm-soc , Simon Horman , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Olof, On Tue, Jun 25, 2019 at 3:10 PM Olof Johansson wrote: > On Fri, Jun 21, 2019 at 11:12:04AM +0200, Simon Horman wrote: > > Oleksandr Tyshchenko (1): > > ARM: mach-shmobile: Don't init CNTVOFF/counter if PSCI is available > > Merged, thanks. Thanks! > Note that in this patch, code like this: > > +#ifdef CONFIG_ARM_PSCI_FW > + if (psci_ops.cpu_on) > + need_update = false; > +#endif > + > + if (need_update == false) > + goto skip_update; > > > Can either be replaced with a goto under the ifdef, or at the very least, no I believe a goto under the ifdef may cause a "label defined but not used" warning if CONFIG_ARM_PSCI_FW is not defined. > need to do a 'need_update == false' -- 'if (need_update)' is sufficient. Yeah, "if (!need_update)" would work too. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel