From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Simon Horman <horms@verge.net.au>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Yoshihiro Kaneko <ykaneko0929@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: renesas: r8a7796: sort nodes
Date: Wed, 21 Aug 2019 11:02:37 +0200 [thread overview]
Message-ID: <CAMuHMdW-K9s55TaRMKyNThMfUP7j90sjCK5vEeL8hZd6SCPsTQ@mail.gmail.com> (raw)
In-Reply-To: <20190821085710.ywva3oz733hxagnc@verge.net.au>
On Wed, Aug 21, 2019 at 10:57 AM Simon Horman <horms@verge.net.au> wrote:
> On Mon, Aug 19, 2019 at 09:56:18PM +0900, Yoshihiro Kaneko wrote:
> > Sort nodes.
> >
> > If node address is present
> > * Sort by node address, grouping all nodes with the same compat string
> > and sorting the group alphabetically.
> > Else
> > * Sort alphabetically
> >
> > This should not have any run-time effect.
> >
> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.4.
> Sorry, I feel that I have missed this in other review's too,
> but, isn't canfd out of order. Its bus address seems to place it
> before dmac0. Or do we prefer to keep it grouped with the can nodes?
We always group it with the can nodes.
BTW, i2c_dvfs is similar, but it seems we deviated from that in at least one
case.
Once the nodes are sorted, we can run my soc-dts-diff script and fix the
last small deviations, crickets, and typos.
> The above notwithstanding,
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2019-08-21 9:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 12:56 [PATCH] arm64: dts: renesas: r8a7796: sort nodes Yoshihiro Kaneko
2019-08-21 8:57 ` Simon Horman
2019-08-21 9:02 ` Geert Uytterhoeven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdW-K9s55TaRMKyNThMfUP7j90sjCK5vEeL8hZd6SCPsTQ@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=ykaneko0929@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).