From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7516C47089 for ; Thu, 27 May 2021 11:30:54 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98868613D3 for ; Thu, 27 May 2021 11:30:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 98868613D3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oM13St3Ax1xZ00x/jXnc0K+B83ECtcEAgzhoiykWXnc=; b=rL9jvFBGnhiska G+I07Xbz3BkY707IQhaR3k0Kiv7zpjkxc0QpttkGKoGgsEkFWnOmDl5X+giSzVKNOeyt4rpIRROCn yMqj31fgPXGur/+JE3KI5X7Z4eUSbdpMJLkeX0duXCf9q6PkS28ziCxih/SQ7UZlKPfeloHc2zGYA 8QMy1RRNRBFlAf5PjiCZy5pzM4h1pK6/xqscOMo7ek6HGOxJ7MtqSIO/+Z1Ipjqaqm1EJYvkrnkWc oOWgfoK7YMA9JZQt0kAf6Wst7hNbT0QW8+Qqs1F3aXzRFB2p7aYcy4/XjvKiv/7jnjHRkKd2QYiE0 1T9sfjqF5boNXO73UGcQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEBw-005HPp-JP; Thu, 27 May 2021 11:28:44 +0000 Received: from mail-vs1-f49.google.com ([209.85.217.49]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmEBr-005HMu-IQ for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 11:28:41 +0000 Received: by mail-vs1-f49.google.com with SMTP id j82so179658vsd.7 for ; Thu, 27 May 2021 04:28:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=33GSI50sxu92I8IBITQZbN0A1jxl04eHMvNt/IrTGXc=; b=WbSG720fLV8Rj+vbaazlNtcoJyOwjbVTu9EORemWXQ8xNpL0N9hoSgpG3C0Pfzg5JY XNDKKh9FDHq4sgpeuSJk3CPRki3OrayIALi+88K4xe10L/4hnbrFqus0OBME88YsrSED ckAPOGE+z2hk4OlK9Hg+Kyv+2T9XvMqq46tr8jeo2TrIMIyUKmmwBqv06IKdeKybK/3U xbD/XHg+KiwWB5XdnDG/CUzvL27M3lPLNsRRlGY937Ez4PcoMc3EOArCQ1AuaFGABD6r 7a0lmCBunlFUdt4IwSD55Txnh+iI0Z6bNNh0ojqFMn1F2oODWnP1nJle1KRPTU+/1EiY /Eag== X-Gm-Message-State: AOAM530JlerQPmwR5zu4D5S1UNvihQ3dNRsW507ox11UaR0VcaFM4AGz scq4PLXUgArUX6hcInKVKJgz0xDKZFQErRSzpRk= X-Google-Smtp-Source: ABdhPJw7dGjhkE2M0QJo1TMHQN5dIq1LOERf9w53NN4gy0CAFSv/lT9VSrQegZJtzjXjzQqnotB7VDTxF3be56GaASM= X-Received: by 2002:a67:4386:: with SMTP id q128mr1725781vsa.40.1622114915482; Thu, 27 May 2021 04:28:35 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-3-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Thu, 27 May 2021 13:28:24 +0200 Message-ID: Subject: Re: [PATCH 02/16] dt-bindings: arm: renesas: Document Renesas RZ/G2{L,LC} SoC variants To: "Lad, Prabhakar" Cc: Lad Prabhakar , Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_042839_637076_0358A755 X-CRM114-Status: GOOD ( 28.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Fri, May 21, 2021 at 7:10 PM Lad, Prabhakar wrote: > On Fri, May 21, 2021 at 2:23 PM Geert Uytterhoeven wrote: > > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > > wrote: > > > Add device tree bindings documentation for Renesas RZ/G2{L,LC} > > > SoC variants. > > > > > > Signed-off-by: Lad Prabhakar > > > Reviewed-by: Biju Das > > > Reviewed-by: Chris Paterson > > > > > --- a/Documentation/devicetree/bindings/arm/renesas.yaml > > > +++ b/Documentation/devicetree/bindings/arm/renesas.yaml > > > @@ -308,6 +308,15 @@ properties: > > > - renesas,r9a07g043u11 # Single Cortex-A55 RZ/G2UL > > > - const: renesas,r9a07g043 > > > > > > + - description: RZ/G2{L,LC} (R9A07G044) > > > + items: > > > + - enum: > > > + - renesas,r9a07g044c1 # Single Cortex-A55 RZ/G2LC > > > + - renesas,r9a07g044c2 # Dual Cortex-A55 RZ/G2LC > > > + - renesas,r9a07g044l1 # Single Cortex-A55 RZ/G2L > > > + - renesas,r9a07g044l2 # Dual Cortex-A55 RZ/G2L > > > > Given the LSI DEVID is the same for all four, and presumably they're > > thus the same die with different packaging, do we need these four > > compatible values? > > > Yes the LSI DEVID is the same for all the above, so as to > differentiate between each SoC's, these compatible strings are added. OK, especially for single-core versus dual-core, this can be useful, if "integration issues" pop up depending on the number of cores or other functionality being present. > * For example some IP blocks which are present on RZ/G2L aren't > present in RZ/G2LC. That'll be handled by the .dtsi, right? > * Adding this to DTS gives an opportunity to stop booting if the wrong > DTB is loaded into the board. This only works for SoCs with different LSI DEVIDs. As all four above have the same LSI DEVID, you can only distinguish them by the main compatible value. It does not protect against loading an RZ/G2LC DTB on an RZ/G2L board or vice versa. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel