From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55ADAC33CA8 for ; Mon, 13 Jan 2020 08:58:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A5C820678 for ; Mon, 13 Jan 2020 08:58:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rDSthey3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A5C820678 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=JKPLJhVoYXvW7A5FgC9/tWocWP6jXxXsoM19O0L6E68=; b=rDSthey3PggIYD RhHWHg6cR+p5Q03uwkQ5/QWfU8jXoOmdkaXN7BV4ojIAYYSFWz4M4clalDc1gshwDqCEadBHyTfG4 xO30Sa1HjUlRPzq5L2t6N0t0XHEmf7lG9uTpIno0FnomDhAJGuiJEKCrf/FdJEwFhqbhGtnh7BuhK 0HPIQeRfmydcpY1WIlubVvblzpGO4PN6zQzTqg+ll38kyQNKB4YI4uCFQJcq+j2CzaywXGrXMUolv KM+F5vONSW6oWyCFTwK31kb84iyRTVos+KPPO1kOSe0ZUMzBt4LBkdjOBt3USD239VEFnp3/ML3Ja Xnqvs/C7iBvEa2BVlLIw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqvYV-0002H1-Ht; Mon, 13 Jan 2020 08:58:39 +0000 Received: from mail-oi1-f194.google.com ([209.85.167.194]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iqvYR-0002GX-IG for linux-arm-kernel@lists.infradead.org; Mon, 13 Jan 2020 08:58:36 +0000 Received: by mail-oi1-f194.google.com with SMTP id 18so7531717oin.9 for ; Mon, 13 Jan 2020 00:58:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yqNlNrOQ7aJ6S/nMKFawkP6Fc2v57+yYYE7QCHVa+YM=; b=WT/C87Ql39dFzxoCME/hrRiPJnn/hPFRnX7fNOkZ1UmzLa88bgSiP+NS1W/Xm1K8CR QbGB6L6rrX7HTEp3RGEeP8xxsLqqz6us5R2Eap9qKc71VTz70h+8xIzVUkol8eZe8y/d ZisHy45I75vqdoRTGFC41qqwqVZVNeMx89EnQLxSpFXllgnLLmVq0mtlU7/MO6MEBs/m xOefSVHXLrXcwL7dZUldkfvvjfNW1eJN6qQDabSjsNig61CSJZxY+v3Cr+tPdDf5npkb +yMrt2rKXcC7H+w37vl6mQvWmWNnrHvzH1XvCG3gyGm3jsuS4TAh26/j4LnkxLj5aPCn J6Pg== X-Gm-Message-State: APjAAAXwYpb109n2KBPccUSehyx4xcyLsG6Ohg/owIvKV1PTTIDiSwbb QtcHlXkbHQMlsPdRlDf+9HV3I3J01sRbedtWBW8= X-Google-Smtp-Source: APXvYqxxsg0TC2Iy7kijFuyONZGoBo0TdJRSrcVkcxlFUfMwFV5qcQg4MhgfNgAma26laSlNFdZZpnD9+zujy0m2PCA= X-Received: by 2002:aca:5905:: with SMTP id n5mr12244176oib.54.1578905914472; Mon, 13 Jan 2020 00:58:34 -0800 (PST) MIME-Version: 1.0 References: <20200112191315.118831-1-marek.vasut@gmail.com> In-Reply-To: <20200112191315.118831-1-marek.vasut@gmail.com> From: Geert Uytterhoeven Date: Mon, 13 Jan 2020 09:58:23 +0100 Message-ID: Subject: Re: [RFC][PATCH] ARM: dts: renesas: Add missing ethernet PHY reset GPIO on Gen2 reference boards To: Marek Vasut X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200113_005835_604534_F276530E X-CRM114-Status: GOOD ( 13.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Linux-Renesas , Wolfram Sang , Geert Uytterhoeven , Linux ARM , Marek Vasut Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On Sun, Jan 12, 2020 at 8:13 PM wrote: > From: Marek Vasut > > The ethernet PHY reset GPIO was missing and the kernel was depending > solely on the bootloader to bring the PHY out of reset. Fix this to > get rid of the dependency on bootloader. > > Signed-off-by: Marek Vasut Thanks for your patch! Reviewed-by: Geert Uytterhoeven > NOTE: Thus far tested on R8A7791 Koelsch > arch/arm/boot/dts/r8a7790-lager.dts | 1 + > arch/arm/boot/dts/r8a7790-stout.dts | 1 + > arch/arm/boot/dts/r8a7791-koelsch.dts | 1 + > arch/arm/boot/dts/r8a7791-porter.dts | 1 + > arch/arm/boot/dts/r8a7793-gose.dts | 1 + > arch/arm/boot/dts/r8a7794-alt.dts | 1 + > arch/arm/boot/dts/r8a7794-silk.dts | 1 + I believe all of the above (except for stout) are available in Magnus' farm... r8a7743-sk-rzg1m.dts and r8a7745-sk-rzg1e.dts need similar changes as r8a7791-porter.dts resp. r8a7794-silk.dts. > --- a/arch/arm/boot/dts/r8a7790-lager.dts > +++ b/arch/arm/boot/dts/r8a7790-lager.dts > @@ -671,6 +671,7 @@ ðer { > > phy1: ethernet-phy@1 { > reg = <1>; > + reset-gpios = <&gpio5 31 GPIO_ACTIVE_LOW>; I would insert this line below micrel,led-mode, though. > interrupt-parent = <&irqc0>; > interrupts = <0 IRQ_TYPE_LEVEL_LOW>; > micrel,led-mode = <1>; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel