From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3A6B4ECAAD1 for ; Wed, 31 Aug 2022 08:25:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=n5XUH1RukKWIAWShf79HXZZ1XLvKkbFioQw/qwe+zVE=; b=YpzJj4HGbqu2/L 3e6wG2zUsnF9ypWnNg5w59kpqYMGZPlWp0glXspkdYOcH87Ir4XPRUzaRKMceCN+gy7nNDm21T7q2 dFWYkz4/cxaGopbtKPHEA8qAkI0ijhhH2Bfo1bP364zYD1q4++R//93r8IcH+SBCcIagtjB9C1X58 PP4GLcbg+p4Xv8gXTBk4c3LsT2SrIkb6swChIez4AYZL43QSoHRXOsFsGcNNUbyh42sLwkgzlvicH Im2QHkHy1b56VgxMOj5pgNtZEpo/Gac/tsZd/43S/nYbBdq4GhBrTkQNQ35tXpFOTISrNB/z9TE9M +laliEV8DC9K7HEQcmEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTJ0o-004uhX-5e; Wed, 31 Aug 2022 08:23:51 +0000 Received: from mail-qk1-f182.google.com ([209.85.222.182]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTIs0-004quK-52 for linux-arm-kernel@lists.infradead.org; Wed, 31 Aug 2022 08:14:45 +0000 Received: by mail-qk1-f182.google.com with SMTP id g21so10270049qka.5 for ; Wed, 31 Aug 2022 01:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=tL3Pu80GajPbXIuFp2pntr8ejcDbNLFHN+ltW3MDRBA=; b=XFqhCy3q5kkyU8Fk+yDiR/fyav8hw75OyNWhYgc6K7lWTzF397xex6g8cn+Fvh5un6 dfigfF6SkEIIekDHfkxjtyyclS4PHQiTsyT34yd8Vt/zjrB/q0U2Lwb1St12J43jWu07 WIySC67tb6PLz7Yw7qeoeduZ9xigWPvyCQ6jiiaX0FKGhORXktQwTY2h5jDUtezp0s1a 1O/Pq6GhaZNlqMX57n0jze+QjXYiiGRVnyszc2hpBz5gE8a9oXDujb99mHqjiyt/sLFc J2yEkOa1Q4eyfeaqzV1AEhrjPjAstn75Rp0l+rofuZ0LkRDRewdJoijUfOhuK4MhsXyX Cv4g== X-Gm-Message-State: ACgBeo0k046K8tzIuLJr1sZV79ydDL5i455cT03ML+67SYfLhk3fZ96O GZkvtgoksRIlR8qVH/XIpd2HxWunqlxF6A== X-Google-Smtp-Source: AA6agR5CPKhlM74m61b8SWzYid0IszjvvcP6n83C6bPwBW6/yzNw7v5+NqtMZ3OF/0upCIao9eJ6rg== X-Received: by 2002:a05:620a:1357:b0:6ba:e661:f91a with SMTP id c23-20020a05620a135700b006bae661f91amr14643073qkl.744.1661933681317; Wed, 31 Aug 2022 01:14:41 -0700 (PDT) Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com. [209.85.219.172]) by smtp.gmail.com with ESMTPSA id f4-20020a05620a280400b006a65c58db99sm9702111qkp.64.2022.08.31.01.14.39 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 31 Aug 2022 01:14:40 -0700 (PDT) Received: by mail-yb1-f172.google.com with SMTP id 11so3074937ybu.0 for ; Wed, 31 Aug 2022 01:14:39 -0700 (PDT) X-Received: by 2002:a25:24b:0:b0:696:4e87:7cec with SMTP id 72-20020a25024b000000b006964e877cecmr14439821ybc.202.1661933679611; Wed, 31 Aug 2022 01:14:39 -0700 (PDT) MIME-Version: 1.0 References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech> <20220728-rpi-analog-tv-properties-v2-10-459522d653a7@cerno.tech> <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> In-Reply-To: <242d272b-5b79-986c-9aaf-64e62f6b37ff@gmail.com> From: Geert Uytterhoeven Date: Wed, 31 Aug 2022 10:14:28 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 10/41] drm/modes: Add a function to generate analog display modes To: Mateusz Kwiatkowski Cc: Maxime Ripard , Maxime Ripard , Ben Skeggs , David Airlie , Chen-Yu Tsai , Thomas Zimmermann , Jani Nikula , Lyude Paul , Philipp Zabel , Maarten Lankhorst , Rodrigo Vivi , Tvrtko Ursulin , Jernej Skrabec , Samuel Holland , Karol Herbst , =?UTF-8?Q?Noralf_Tr=C3=B8nnes?= , Emma Anholt , Daniel Vetter , Joonas Lahtinen , Hans de Goede , Linux ARM , Phil Elwell , Intel Graphics Development , Dave Stevenson , DRI Development , Dom Cobley , Linux Kernel Mailing List , Nouveau Dev , linux-sunxi@lists.linux.dev X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220831_011444_223161_59718349 X-CRM114-Status: GOOD ( 29.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mateusz, On Wed, Aug 31, 2022 at 3:44 AM Mateusz Kwiatkowski wrote: > Wow. That's an enormous amount of effort put into this patch. > > But I'm tempted to say that this is actually overengineered quite a bit :D > Considering that there's no way to access all these calculations from user > space, and I can't imagine anybody using anything else than those standard > 480i/576i (and maybe 240p/288p) modes at 13.5 MHz any time soon... I'm not > sure if we actually need all this. We'll need it when we get an Amiga DRM driver, which will use 7/14/28 MHz pixel clocks. > But anyway, I'm not the maintainer of this subsystem, so I'm not the one to > decide. > > > +enum drm_mode_analog { > > + DRM_MODE_ANALOG_NTSC, > > + DRM_MODE_ANALOG_PAL, > > +}; > > Using "NTSC" and "PAL" to describe the 50Hz and 60Hz analog TV modes is common, > but strictly speaking a misnomer. Those are color encoding systems, and your > patchset fully supports lesser used, but standard encodings for those (e.g. > PAL-M for 60Hz and SECAM for 50Hz). I'd propose switching to some more neutral > naming scheme. Some ideas: > > - DRM_MODE_ANALOG_60_HZ / DRM_MODE_ANALOG_50_HZ (after standard refresh rate) > - DRM_MODE_ANALOG_525_LINES / DRM_MODE_ANALOG_625_LINES (after standard line > count) IMHO these are bad names, as e.g. VGA640x480@60 is also analog, using 60 Hz and 525 lines. Add "TV" to the name? > - DRM_MODE_ANALOG_JM / DRM_MODE_ANALOG_BDGHIKLN (after corresponding ITU System > Letter Designations) Or DRM_MODE_ITU_*? But given the long list of letters, this looks fragile to me. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel