From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8888C47089 for ; Thu, 27 May 2021 15:41:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D2C613B4 for ; Thu, 27 May 2021 15:41:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D2C613B4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gP8RrpPE5FB8XTVLiDk1EmwiDwotXdam4Pgdh6JP2tI=; b=pCDv26L5Z+PjUO kngTAbqtltPHw687bIuiFRUnk491uZZltyVUmBYiqRJBusYzGK0/oO0o0ycaz7YgVbOK3UU7IsvM/ 8ZFJqnavYF5pBZ+Fzp3WZwM1ZziSFOGN8VSyeW9Ca/Ktk+/2rhXPqxEya/gS3SimxeV3xWBp+eSFQ BTYBkUPh62/smMNqKDQJgBsTkotqpkf7v07VB5N8deIEQuo2fGuogS07SDP+lG9mtSXnnhZ2cYmgL 5vnEA87saxWvX2YFwriSY6ZuouhehzfDc8F9uuSXqpW5JP0nXPNPAfnswInWhjIR4q+skosqVkMXD sm4JO4qhLi8dnHMEuXAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmI6C-007Hog-9A; Thu, 27 May 2021 15:39:05 +0000 Received: from mail-ua1-f44.google.com ([209.85.222.44]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lmHYm-0071BC-5Y for linux-arm-kernel@lists.infradead.org; Thu, 27 May 2021 15:04:33 +0000 Received: by mail-ua1-f44.google.com with SMTP id x1so381199uau.1 for ; Thu, 27 May 2021 08:04:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3u3wWCo2lZGWRYWR5pjnSvnC6obG/x9fym7jnlVxBcM=; b=AnnyhpgEGTO011YmkzdXlOrJsVYft6VdpibcKNfiFO1ttDXyz33+zW97sMnWUQVv1z bVx5Slamcswd//6D4ykYpXVOvISszeqh2uDKp4bvvwasnny+XAgE4BaxqqWv+JVjI6xd QkNXDzAs+lBd2FfJ3s1lYpmsewMGr9N3+Bn9XnOatb6xK1t1Pg4Zezjg42tlZq4xw/gC iK9IB+uKwO211XG6g+pk6PoDJ9q2W3AoKe22qsXwcEMm4hab7k6xitxnt7AIsl5BIVXF x1aEJXowp2amJJobBZU+jjuIoBOXe5l8TW+VaaJ2q0priCPvW1uDZ7QVPXFAFa5HWly0 SDFQ== X-Gm-Message-State: AOAM530kNGbzeuB37qaXEXmn14hOyUb74248BQfM26wpYyxXILPc//xx 1A9uBoT9lnko7dmqgB7+lhQM/2rqS5ExJsedtVg= X-Google-Smtp-Source: ABdhPJzHaOLJBSw3gQx+wVzMZyw1XojcblD4dymCtSozCyRiE6ryYMrpQjtlVbuuU6nXtCljn2TrB5YZmEsVQ/NaFAQ= X-Received: by 2002:ab0:7705:: with SMTP id z5mr2806791uaq.2.1622127871092; Thu, 27 May 2021 08:04:31 -0700 (PDT) MIME-Version: 1.0 References: <52df0592c81ac000d3f486a9ba5a4d84b0f42c47.1621583562.git.geert+renesas@glider.be> <20210521182403.GA50332@robh.at.kernel.org> In-Reply-To: <20210521182403.GA50332@robh.at.kernel.org> From: Geert Uytterhoeven Date: Thu, 27 May 2021 17:04:19 +0200 Message-ID: Subject: Re: [PATCH 3/3] dt-bindings: gpio: pcf857x: Convert to json-schema To: Rob Herring Cc: Linus Walleij , Laurent Pinchart , Bartosz Golaszewski , =?UTF-8?Q?Beno=C3=AEt_Cousson?= , Tony Lindgren , Jan Tuerk , Shawn Guo , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:GPIO SUBSYSTEM" , Linux-OMAP , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210527_080432_251110_8DA2522D X-CRM114-Status: GOOD ( 33.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, May 21, 2021 at 8:24 PM Rob Herring wrote: > On Fri, May 21, 2021 at 12:23:47PM +0200, Geert Uytterhoeven wrote: > > On Fri, May 21, 2021 at 12:04 PM Linus Walleij wrote: > > > On Fri, May 21, 2021 at 9:54 AM Geert Uytterhoeven > > > wrote: > > > > Convert the PCF857x-compatible I/O expanders Device Tree binding > > > > documentation to json-schema. > > > > > > > > Document missing compatible values, properties, and gpio hogs. > > > > > > > > Signed-off-by: Geert Uytterhoeven > > > > > > (...) > > > > Perhaps the "ti,pcf8575" construct should be removed, and the few users > > > > fixed instead? > > > > > > You would rather list it as deprecated I think? > > > It is ABI... > > > > All DTS files use the "nxp,pcf8575" fallback, except for > > arch/x86/platform/ce4100/falconfalls.dts. > > The latter ain't working with Linux, as the Linux driver doesn't > > match against "ti,pcf8575"... Correction: i2c_device_id-based matching ignores the vendor part of the compatible value. One day this is gonna bite us... > Perhaps can it just be removed? I think so. All other users of similar I2C GPIO expanders just use the compatible values of the original NXP parts. > > > > +patternProperties: > > > > + "^(hog-[0-9]+|.+-hog(-[0-9]+)?)$": > > > > + type: object > > > > > > But this is already in > > > /dtschema/schemas/gpio/gpio-hog.yaml > > > for nodename, isn't that where it properly belongs? > > > > > > I'm however confused here Rob will know what to do. > > This one is a bit odd. > > > If we leave this out, something still has to refer to it? > > I see no other binding doing that... > > It's selected by 'gpio-hog' being present, but here you need to make > sure that's the case. OK. Fixed. > And I would hope you could define the node name to be just 1 of the 2 > cases. Yep, the latter is fine. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel