From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Simon Horman <horms@verge.net.au>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Magnus Damm <magnus.damm@gmail.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369
Date: Fri, 23 Aug 2019 11:49:19 +0200 [thread overview]
Message-ID: <CAMuHMdX1uryY5wbbJ7n1w2_XHdCMwLst4w-nbQw-iAxORTJyuw@mail.gmail.com> (raw)
In-Reply-To: <20190822085804.rgyjxisnznmnura5@verge.net.au>
Hi Simon,
On Thu, Aug 22, 2019 at 10:58 AM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Aug 21, 2019 at 02:46:02PM +0200, Geert Uytterhoeven wrote:
> > PL310 Erratum 588369 affects PL310 cache controller revisions older than
> > r2p0.
> >
> > As Renesas ARM SoCs contain the following revisions:
> > - SH-Mobile AG5: r3p1,
> > - R-Mobile A1: r3p1-50rel0,
> > - R-Car H1: r3p2,
> > - RZ/A1: r3p2,
> > - RZ/A2: r3p3,
> > none of them are affected, and support for the errata can be disabled
> > safely.
> >
> > The EMMA Mobile EV2 documentation doesn't mention the revision of its
> > PL310 cache controller, so this SoC might be affected. However, the L2
> > cache controller is not enabled by Linux.
>
> If the controller is not enabled by Linux then I would think that the
> Errata is not needed. If that is true then I agree with this patch.
>
> Regarding making assumptions about the version of the PL310 cache
> controller, I suggest that we cannot assume that it is not affected
> without further information.
I agree, so this needs more investigation.
It seems this was included in shmobile_defconfig based on the old
armadillo800eav_defconfig, which enabled several errata options since
commit e0ef0984ae346c54 ("ARM: shmobile: armadillo800eva: enable all
errata for cache on defconfig").
Based on my current knowledge, PL310_ERRATA_769419 is the only one that
affects Renesas SoCs (ignoring EMEV2 for now) with a PL310, and thus
should be enabled, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-23 9:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
2019-08-22 8:58 ` Simon Horman
2019-08-21 12:46 ` [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9 Geert Uytterhoeven
2019-08-22 8:59 ` Simon Horman
2019-08-21 12:46 ` [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369 Geert Uytterhoeven
2019-08-22 8:58 ` Simon Horman
2019-08-23 9:49 ` Geert Uytterhoeven [this message]
2019-08-23 7:54 ` [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
2019-08-23 8:35 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMuHMdX1uryY5wbbJ7n1w2_XHdCMwLst4w-nbQw-iAxORTJyuw@mail.gmail.com \
--to=geert@linux-m68k.org \
--cc=geert+renesas@glider.be \
--cc=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).