linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/3] soc: renesas: ARM errata updates
@ 2019-08-21 12:45 Geert Uytterhoeven
  2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 12:45 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Geert Uytterhoeven, linux-arm-kernel

	Hi all,

This patch series updates the handling of ARM errata for affected
Renesas SoCs.

The first patch enables the new ARM_ERRATA_814220 for Cortex-A7, using
Kconfig logic.
The second patch moves enablement of ARM_ERRATA_754322 for Cortex-A9
from shmobile_defconfig to Kconfig logic, to make sure it's always
enabled when needed.
The third patch disables PL310_ERRATA_588369, as it doesn't affect any
Renesas SoCs.

The last patch is marked RFC, as I don't know the revision of PL310 on
EMMA Mobile EV2, and cannot test it on EMEV2.

Thanks for your comments!

Geert Uytterhoeven (3):
  soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7
  soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9
  [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369

 arch/arm/configs/shmobile_defconfig |  2 --
 drivers/soc/renesas/Kconfig         | 11 +++++++++++
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.17.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7
  2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
@ 2019-08-21 12:46 ` Geert Uytterhoeven
  2019-08-22  8:58   ` Simon Horman
  2019-08-21 12:46 ` [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9 Geert Uytterhoeven
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 12:46 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Geert Uytterhoeven, linux-arm-kernel

ARM Erratum 814220 affects Cortex-A7 revisions r0p2-r0p5.

Enable automatically support to mitigate the erratum when compiling a
kernel for any of the affected Renesas SoCs:
  - R-Mobile APE6: r0p2,
  - RZ/G1E: r0p5,
  - RZ/G1C: r0p5,
  - R-Car H2: r0p3,
  - R-Car E2: r0p5,
  - RZ/N1: r0p5.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/soc/renesas/Kconfig | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index 2bbf49e5d441808b..a72d014ea37cc788 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -72,6 +72,7 @@ config ARCH_R8A73A4
 	bool "R-Mobile APE6 (R8A73A40)"
 	select ARCH_RMOBILE
 	select ARM_ERRATA_798181 if SMP
+	select ARM_ERRATA_814220
 	select HAVE_ARM_ARCH_TIMER
 	select RENESAS_IRQC
 
@@ -95,11 +96,13 @@ config ARCH_R8A7744
 config ARCH_R8A7745
 	bool "RZ/G1E (R8A77450)"
 	select ARCH_RCAR_GEN2
+	select ARM_ERRATA_814220
 	select SYSC_R8A7745
 
 config ARCH_R8A77470
 	bool "RZ/G1C (R8A77470)"
 	select ARCH_RCAR_GEN2
+	select ARM_ERRATA_814220
 	select SYSC_R8A77470
 
 config ARCH_R8A7778
@@ -117,6 +120,7 @@ config ARCH_R8A7790
 	bool "R-Car H2 (R8A77900)"
 	select ARCH_RCAR_GEN2
 	select ARM_ERRATA_798181 if SMP
+	select ARM_ERRATA_814220
 	select I2C
 	select SYSC_R8A7790
 
@@ -143,11 +147,13 @@ config ARCH_R8A7793
 config ARCH_R8A7794
 	bool "R-Car E2 (R8A77940)"
 	select ARCH_RCAR_GEN2
+	select ARM_ERRATA_814220
 	select SYSC_R8A7794
 
 config ARCH_R9A06G032
 	bool "RZ/N1D (R9A06G032)"
 	select ARCH_RZN1
+	select ARM_ERRATA_814220
 
 config ARCH_SH73A0
 	bool "SH-Mobile AG5 (R8A73A00)"
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9
  2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
  2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
@ 2019-08-21 12:46 ` Geert Uytterhoeven
  2019-08-22  8:59   ` Simon Horman
  2019-08-21 12:46 ` [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369 Geert Uytterhoeven
  2019-08-23  7:54 ` [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
  3 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 12:46 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Geert Uytterhoeven, linux-arm-kernel

ARM Erratum 754322 affects Cortex-A9 revisions r2p* and r3p*.

Enable support code to mitigate the erratum when compiling a kernel for
any of the affected Renesas SoCs:
  - RZ/A1: r3p0,
  - R-Mobile A1: r2p4,
  - R-Car M1A: r2p2-00rel0,
  - R-Car H1: r3p0,
  - SH-Mobile AG5: r2p2,
and drop the corresponding config symbol from shmobile_defconfig.

EMMA Mobile EV2 (r1p3) and RZ/A2 (r4p1) are not affected.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Looks like my R-Mobile A1 is actually r2p3, and the R-Car M1A in Magnus'
farm is r2p4?

 arch/arm/configs/shmobile_defconfig | 1 -
 drivers/soc/renesas/Kconfig         | 5 +++++
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index c6c70355141c38fa..123821e63873dafa 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -9,7 +9,6 @@ CONFIG_PERF_EVENTS=y
 CONFIG_SLAB=y
 CONFIG_ARCH_RENESAS=y
 CONFIG_PL310_ERRATA_588369=y
-CONFIG_ARM_ERRATA_754322=y
 CONFIG_SMP=y
 CONFIG_SCHED_MC=y
 CONFIG_NR_CPUS=8
diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index a72d014ea37cc788..3c5e017bacbaca11 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -55,6 +55,7 @@ config ARCH_EMEV2
 
 config ARCH_R7S72100
 	bool "RZ/A1H (R7S72100)"
+	select ARM_ERRATA_754322
 	select PM
 	select PM_GENERIC_DOMAINS
 	select RENESAS_OSTM
@@ -79,6 +80,7 @@ config ARCH_R8A73A4
 config ARCH_R8A7740
 	bool "R-Mobile A1 (R8A77400)"
 	select ARCH_RMOBILE
+	select ARM_ERRATA_754322
 	select RENESAS_INTC_IRQPIN
 
 config ARCH_R8A7743
@@ -108,10 +110,12 @@ config ARCH_R8A77470
 config ARCH_R8A7778
 	bool "R-Car M1A (R8A77781)"
 	select ARCH_RCAR_GEN1
+	select ARM_ERRATA_754322
 
 config ARCH_R8A7779
 	bool "R-Car H1 (R8A77790)"
 	select ARCH_RCAR_GEN1
+	select ARM_ERRATA_754322
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select SYSC_R8A7779
@@ -158,6 +162,7 @@ config ARCH_R9A06G032
 config ARCH_SH73A0
 	bool "SH-Mobile AG5 (R8A73A00)"
 	select ARCH_RMOBILE
+	select ARM_ERRATA_754322
 	select HAVE_ARM_SCU if SMP
 	select HAVE_ARM_TWD if SMP
 	select RENESAS_INTC_IRQPIN
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369
  2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
  2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
  2019-08-21 12:46 ` [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9 Geert Uytterhoeven
@ 2019-08-21 12:46 ` Geert Uytterhoeven
  2019-08-22  8:58   ` Simon Horman
  2019-08-23  7:54 ` [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
  3 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-21 12:46 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: linux-renesas-soc, Geert Uytterhoeven, linux-arm-kernel

PL310 Erratum 588369 affects PL310 cache controller revisions older than
r2p0.

As Renesas ARM SoCs contain the following revisions:
  - SH-Mobile AG5: r3p1,
  - R-Mobile A1: r3p1-50rel0,
  - R-Car H1: r3p2,
  - RZ/A1: r3p2,
  - RZ/A2: r3p3,
none of them are affected, and support for the errata can be disabled
safely.

The EMMA Mobile EV2 documentation doesn't mention the revision of its
PL310 cache controller, so this SoC might be affected.  However, the L2
cache controller is not enabled by Linux.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/configs/shmobile_defconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
index 123821e63873dafa..95a127cbe8e6fcd7 100644
--- a/arch/arm/configs/shmobile_defconfig
+++ b/arch/arm/configs/shmobile_defconfig
@@ -8,7 +8,6 @@ CONFIG_CC_OPTIMIZE_FOR_SIZE=y
 CONFIG_PERF_EVENTS=y
 CONFIG_SLAB=y
 CONFIG_ARCH_RENESAS=y
-CONFIG_PL310_ERRATA_588369=y
 CONFIG_SMP=y
 CONFIG_SCHED_MC=y
 CONFIG_NR_CPUS=8
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369
  2019-08-21 12:46 ` [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369 Geert Uytterhoeven
@ 2019-08-22  8:58   ` Simon Horman
  2019-08-23  9:49     ` Geert Uytterhoeven
  0 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2019-08-22  8:58 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Wed, Aug 21, 2019 at 02:46:02PM +0200, Geert Uytterhoeven wrote:
> PL310 Erratum 588369 affects PL310 cache controller revisions older than
> r2p0.
> 
> As Renesas ARM SoCs contain the following revisions:
>   - SH-Mobile AG5: r3p1,
>   - R-Mobile A1: r3p1-50rel0,
>   - R-Car H1: r3p2,
>   - RZ/A1: r3p2,
>   - RZ/A2: r3p3,
> none of them are affected, and support for the errata can be disabled
> safely.
> 
> The EMMA Mobile EV2 documentation doesn't mention the revision of its
> PL310 cache controller, so this SoC might be affected.  However, the L2
> cache controller is not enabled by Linux.

If the controller is not enabled by Linux then I would think that the
Errata is not needed. If that is true then I agree with this patch.

Regarding making assumptions about the version of the PL310 cache
controller, I suggest that we cannot assume that it is not affected
without further information.

> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  arch/arm/configs/shmobile_defconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index 123821e63873dafa..95a127cbe8e6fcd7 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -8,7 +8,6 @@ CONFIG_CC_OPTIMIZE_FOR_SIZE=y
>  CONFIG_PERF_EVENTS=y
>  CONFIG_SLAB=y
>  CONFIG_ARCH_RENESAS=y
> -CONFIG_PL310_ERRATA_588369=y
>  CONFIG_SMP=y
>  CONFIG_SCHED_MC=y
>  CONFIG_NR_CPUS=8
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7
  2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
@ 2019-08-22  8:58   ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2019-08-22  8:58 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Wed, Aug 21, 2019 at 02:46:00PM +0200, Geert Uytterhoeven wrote:
> ARM Erratum 814220 affects Cortex-A7 revisions r0p2-r0p5.
> 
> Enable automatically support to mitigate the erratum when compiling a
> kernel for any of the affected Renesas SoCs:
>   - R-Mobile APE6: r0p2,
>   - RZ/G1E: r0p5,
>   - RZ/G1C: r0p5,
>   - R-Car H2: r0p3,
>   - R-Car E2: r0p5,
>   - RZ/N1: r0p5.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  drivers/soc/renesas/Kconfig | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> index 2bbf49e5d441808b..a72d014ea37cc788 100644
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -72,6 +72,7 @@ config ARCH_R8A73A4
>  	bool "R-Mobile APE6 (R8A73A40)"
>  	select ARCH_RMOBILE
>  	select ARM_ERRATA_798181 if SMP
> +	select ARM_ERRATA_814220
>  	select HAVE_ARM_ARCH_TIMER
>  	select RENESAS_IRQC
>  
> @@ -95,11 +96,13 @@ config ARCH_R8A7744
>  config ARCH_R8A7745
>  	bool "RZ/G1E (R8A77450)"
>  	select ARCH_RCAR_GEN2
> +	select ARM_ERRATA_814220
>  	select SYSC_R8A7745
>  
>  config ARCH_R8A77470
>  	bool "RZ/G1C (R8A77470)"
>  	select ARCH_RCAR_GEN2
> +	select ARM_ERRATA_814220
>  	select SYSC_R8A77470
>  
>  config ARCH_R8A7778
> @@ -117,6 +120,7 @@ config ARCH_R8A7790
>  	bool "R-Car H2 (R8A77900)"
>  	select ARCH_RCAR_GEN2
>  	select ARM_ERRATA_798181 if SMP
> +	select ARM_ERRATA_814220
>  	select I2C
>  	select SYSC_R8A7790
>  
> @@ -143,11 +147,13 @@ config ARCH_R8A7793
>  config ARCH_R8A7794
>  	bool "R-Car E2 (R8A77940)"
>  	select ARCH_RCAR_GEN2
> +	select ARM_ERRATA_814220
>  	select SYSC_R8A7794
>  
>  config ARCH_R9A06G032
>  	bool "RZ/N1D (R9A06G032)"
>  	select ARCH_RZN1
> +	select ARM_ERRATA_814220
>  
>  config ARCH_SH73A0
>  	bool "SH-Mobile AG5 (R8A73A00)"
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9
  2019-08-21 12:46 ` [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9 Geert Uytterhoeven
@ 2019-08-22  8:59   ` Simon Horman
  0 siblings, 0 replies; 10+ messages in thread
From: Simon Horman @ 2019-08-22  8:59 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: linux-renesas-soc, Magnus Damm, linux-arm-kernel

On Wed, Aug 21, 2019 at 02:46:01PM +0200, Geert Uytterhoeven wrote:
> ARM Erratum 754322 affects Cortex-A9 revisions r2p* and r3p*.
> 
> Enable support code to mitigate the erratum when compiling a kernel for
> any of the affected Renesas SoCs:
>   - RZ/A1: r3p0,
>   - R-Mobile A1: r2p4,
>   - R-Car M1A: r2p2-00rel0,
>   - R-Car H1: r3p0,
>   - SH-Mobile AG5: r2p2,
> and drop the corresponding config symbol from shmobile_defconfig.
> 
> EMMA Mobile EV2 (r1p3) and RZ/A2 (r4p1) are not affected.

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Looks like my R-Mobile A1 is actually r2p3, and the R-Car M1A in Magnus'
> farm is r2p4?
> 
>  arch/arm/configs/shmobile_defconfig | 1 -
>  drivers/soc/renesas/Kconfig         | 5 +++++
>  2 files changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/configs/shmobile_defconfig b/arch/arm/configs/shmobile_defconfig
> index c6c70355141c38fa..123821e63873dafa 100644
> --- a/arch/arm/configs/shmobile_defconfig
> +++ b/arch/arm/configs/shmobile_defconfig
> @@ -9,7 +9,6 @@ CONFIG_PERF_EVENTS=y
>  CONFIG_SLAB=y
>  CONFIG_ARCH_RENESAS=y
>  CONFIG_PL310_ERRATA_588369=y
> -CONFIG_ARM_ERRATA_754322=y
>  CONFIG_SMP=y
>  CONFIG_SCHED_MC=y
>  CONFIG_NR_CPUS=8
> diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
> index a72d014ea37cc788..3c5e017bacbaca11 100644
> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -55,6 +55,7 @@ config ARCH_EMEV2
>  
>  config ARCH_R7S72100
>  	bool "RZ/A1H (R7S72100)"
> +	select ARM_ERRATA_754322
>  	select PM
>  	select PM_GENERIC_DOMAINS
>  	select RENESAS_OSTM
> @@ -79,6 +80,7 @@ config ARCH_R8A73A4
>  config ARCH_R8A7740
>  	bool "R-Mobile A1 (R8A77400)"
>  	select ARCH_RMOBILE
> +	select ARM_ERRATA_754322
>  	select RENESAS_INTC_IRQPIN
>  
>  config ARCH_R8A7743
> @@ -108,10 +110,12 @@ config ARCH_R8A77470
>  config ARCH_R8A7778
>  	bool "R-Car M1A (R8A77781)"
>  	select ARCH_RCAR_GEN1
> +	select ARM_ERRATA_754322
>  
>  config ARCH_R8A7779
>  	bool "R-Car H1 (R8A77790)"
>  	select ARCH_RCAR_GEN1
> +	select ARM_ERRATA_754322
>  	select HAVE_ARM_SCU if SMP
>  	select HAVE_ARM_TWD if SMP
>  	select SYSC_R8A7779
> @@ -158,6 +162,7 @@ config ARCH_R9A06G032
>  config ARCH_SH73A0
>  	bool "SH-Mobile AG5 (R8A73A00)"
>  	select ARCH_RMOBILE
> +	select ARM_ERRATA_754322
>  	select HAVE_ARM_SCU if SMP
>  	select HAVE_ARM_TWD if SMP
>  	select RENESAS_INTC_IRQPIN
> -- 
> 2.17.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/3] soc: renesas: ARM errata updates
  2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
                   ` (2 preceding siblings ...)
  2019-08-21 12:46 ` [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369 Geert Uytterhoeven
@ 2019-08-23  7:54 ` Geert Uytterhoeven
  2019-08-23  8:35   ` Geert Uytterhoeven
  3 siblings, 1 reply; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-23  7:54 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux-Renesas, Simon Horman, Magnus Damm, Linux ARM

On Wed, Aug 21, 2019 at 2:46 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> This patch series updates the handling of ARM errata for affected
> Renesas SoCs.
>
> The first patch enables the new ARM_ERRATA_814220 for Cortex-A7, using
> Kconfig logic.

Queuing the first one in renesas-devel for v5.4.

> The second patch moves enablement of ARM_ERRATA_754322 for Cortex-A9
> from shmobile_defconfig to Kconfig logic, to make sure it's always
> enabled when needed.
> The third patch disables PL310_ERRATA_588369, as it doesn't affect any
> Renesas SoCs.
>
> The last patch is marked RFC, as I don't know the revision of PL310 on
> EMMA Mobile EV2, and cannot test it on EMEV2.

The other 2 are postponed.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/3] soc: renesas: ARM errata updates
  2019-08-23  7:54 ` [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
@ 2019-08-23  8:35   ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-23  8:35 UTC (permalink / raw)
  To: Geert Uytterhoeven; +Cc: Linux-Renesas, Simon Horman, Magnus Damm, Linux ARM

On Fri, Aug 23, 2019 at 9:54 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Wed, Aug 21, 2019 at 2:46 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> > This patch series updates the handling of ARM errata for affected
> > Renesas SoCs.
> >
> > The first patch enables the new ARM_ERRATA_814220 for Cortex-A7, using
> > Kconfig logic.
>
> Queuing the first one in renesas-devel for v5.4.
>
> > The second patch moves enablement of ARM_ERRATA_754322 for Cortex-A9
> > from shmobile_defconfig to Kconfig logic, to make sure it's always
> > enabled when needed.
> > The third patch disables PL310_ERRATA_588369, as it doesn't affect any
> > Renesas SoCs.
> >
> > The last patch is marked RFC, as I don't know the revision of PL310 on
> > EMMA Mobile EV2, and cannot test it on EMEV2.
>
> The other 2 are postponed.

Given it untangles dependencies, I'm also queuing the Kconfig part of patch 2.
The defconfig update will happen automatically during the refresh
after v5.4-rc1.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369
  2019-08-22  8:58   ` Simon Horman
@ 2019-08-23  9:49     ` Geert Uytterhoeven
  0 siblings, 0 replies; 10+ messages in thread
From: Geert Uytterhoeven @ 2019-08-23  9:49 UTC (permalink / raw)
  To: Simon Horman; +Cc: Linux-Renesas, Magnus Damm, Linux ARM, Geert Uytterhoeven

Hi Simon,

On Thu, Aug 22, 2019 at 10:58 AM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Aug 21, 2019 at 02:46:02PM +0200, Geert Uytterhoeven wrote:
> > PL310 Erratum 588369 affects PL310 cache controller revisions older than
> > r2p0.
> >
> > As Renesas ARM SoCs contain the following revisions:
> >   - SH-Mobile AG5: r3p1,
> >   - R-Mobile A1: r3p1-50rel0,
> >   - R-Car H1: r3p2,
> >   - RZ/A1: r3p2,
> >   - RZ/A2: r3p3,
> > none of them are affected, and support for the errata can be disabled
> > safely.
> >
> > The EMMA Mobile EV2 documentation doesn't mention the revision of its
> > PL310 cache controller, so this SoC might be affected.  However, the L2
> > cache controller is not enabled by Linux.
>
> If the controller is not enabled by Linux then I would think that the
> Errata is not needed. If that is true then I agree with this patch.
>
> Regarding making assumptions about the version of the PL310 cache
> controller, I suggest that we cannot assume that it is not affected
> without further information.

I agree, so this needs more investigation.

It seems this was included in shmobile_defconfig based on the old
armadillo800eav_defconfig, which enabled several errata options since
commit e0ef0984ae346c54 ("ARM: shmobile: armadillo800eva: enable all
errata for cache on defconfig").
Based on my current knowledge, PL310_ERRATA_769419 is the only one that
affects Renesas SoCs (ignoring EMEV2 for now) with a PL310, and thus
should be enabled, too.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-08-23  9:49 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 12:45 [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
2019-08-21 12:46 ` [PATCH 1/3] soc: renesas: Enable ARM_ERRATA_814220 for affected Cortex-A7 Geert Uytterhoeven
2019-08-22  8:58   ` Simon Horman
2019-08-21 12:46 ` [PATCH 2/3] soc: renesas: Enable ARM_ERRATA_754322 for affected Cortex-A9 Geert Uytterhoeven
2019-08-22  8:59   ` Simon Horman
2019-08-21 12:46 ` [PATCH 3/3] [RFC] ARM: shmobile: defconfig: Disable PL310_ERRATA_588369 Geert Uytterhoeven
2019-08-22  8:58   ` Simon Horman
2019-08-23  9:49     ` Geert Uytterhoeven
2019-08-23  7:54 ` [PATCH 0/3] soc: renesas: ARM errata updates Geert Uytterhoeven
2019-08-23  8:35   ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).