From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64F47C47078 for ; Fri, 21 May 2021 15:29:36 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC68C60698 for ; Fri, 21 May 2021 15:29:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC68C60698 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ElbG3TsgyV2DbHCmQ7yf67nrZNRcZ/WyKi0G2+u65Z0=; b=VDK+QyjW6r8+4IX69yBoitRXkx LwQZqUmEprCHnardcu4MNsM8aLfT0xrKaQL9BLrPIPvVqcWb3cA3PfRVUjE3xuivC67bwKLXyDvCC KqbeeXY4aPdG7xmLwPk/r9cfhxWShzBCLFtcmVCCApAMiYWlRBDc+orMwis2KXDA1RnhD9yOX83uT QP7rx3D3taQlQ8h9yA+PSSnOrlGGMrDTLfu4C6lsPAEAgrlWp4vxjU6i9aRc3Z9cf+1gCe2UrZ6Mr 6WWsEcfQHqRqoFtuMez7Kn7ytVZK++gPGHDTdIim2J+mBrKfEPM2Q3agveY82VRD1LDl7ejFQ4kcA UmGYMisg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk74F-0001f3-Ol; Fri, 21 May 2021 15:28:04 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lk72o-0001OK-Il for linux-arm-kernel@desiato.infradead.org; Fri, 21 May 2021 15:26:34 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZjH8fPaY2o8f5Ib7RZj1gMaw/NXIuKmhbkZfvqyPn5I=; b=qNDf6WsSGR34rij6BudXyrdp0U UKEQlJYNqWWH3KwLs2t0MPsf2Zsu1x9fII8TZ8HSK39i2qf3debQLY4yqDY6w+8TX2tntikLL6wyg 5dt+lVXVwaQU/QeNsTcDgSrv2cW0jKJUDVVqivnvesmnVCF7n/5ZGnKsp3Eeq0eOOB8U1oJwk4iqm drJhZUBNX0LdhO6simgwnBDSag+MSNYFmFjCvTIrYpxAr9TCjDuk9DSBqvaxwciJKx0UBBUyxOSTy GuApqtlTUDvytzUfcMsoCiSlcpBwuFAp2HcJ321FP/ctSiUisgJv7dI198DLeAwu5jz9NOEHgb3Fe sr04rJOQ==; Received: from mail-vs1-f46.google.com ([209.85.217.46]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lk6sm-00HDsH-Ng for linux-arm-kernel@lists.infradead.org; Fri, 21 May 2021 15:16:14 +0000 Received: by mail-vs1-f46.google.com with SMTP id o192so10524351vsd.7 for ; Fri, 21 May 2021 08:16:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZjH8fPaY2o8f5Ib7RZj1gMaw/NXIuKmhbkZfvqyPn5I=; b=TUmOjjRcUjMjFjM8NWsaGSv2SuuTHR40uDASO1UYN2RhHA3SyFMBW7CqxXj6/cXNuk yFgnw6Ug/Ir8xfnrC7dG+bykrtGKS9ShE1yoZyLaTSrjKx5/JTBwMdMuwn0IlqbFbFM0 pyrVHbXtyGPXMpxt6W6Tet/gdCP2NGYjDVRV9LgQXdaBywzg/G87z7v5GfXavvyFuoVk YPuh9zSWiTAVAeDZZM2j9q6/xzPDbi8rwbGG988NjISC7yjLG8cC2v8t99qHph+NfDX4 UR9AzJCv6U+KinSN7IIs8hN8M1arOXVKjH4L1eRmnxcEGG/SXvU+h4qhCKPnqw7y0S2v 69RA== X-Gm-Message-State: AOAM531QwnDpKnBnotdIy6H5NoxB9wbqlqAu/E4Gx7qfBikDn7G8tCEd P0lAQvgD9NSLYgVhtKSz6TpzPtD4ZkStUEDSne0= X-Google-Smtp-Source: ABdhPJx8Ajdh/v2OoW95fXlR3EdAJCqsWTRUG9iGhYqfk38ZBsPFymjTEjfn+Kf+9AyJ7sOkWVT6IygojHInYWXe4/Q= X-Received: by 2002:a67:fb52:: with SMTP id e18mr11430842vsr.18.1621610171231; Fri, 21 May 2021 08:16:11 -0700 (PDT) MIME-Version: 1.0 References: <20210514192218.13022-1-prabhakar.mahadev-lad.rj@bp.renesas.com> <20210514192218.13022-10-prabhakar.mahadev-lad.rj@bp.renesas.com> In-Reply-To: From: Geert Uytterhoeven Date: Fri, 21 May 2021 17:15:59 +0200 Message-ID: Subject: Re: [PATCH 09/16] dt-bindings: serial: renesas,scif: Document r9a07g044 bindings To: Lad Prabhakar Cc: Rob Herring , Magnus Damm , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Catalin Marinas , Will Deacon , Jiri Slaby , Philipp Zabel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux-Renesas , linux-clk , "open list:SERIAL DRIVERS" , Linux ARM , Biju Das , Prabhakar X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210521_081612_793201_98F57ACE X-CRM114-Status: GOOD ( 25.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, On Fri, May 21, 2021 at 3:26 PM Geert Uytterhoeven wrote: > On Fri, May 14, 2021 at 9:23 PM Lad Prabhakar > wrote: > > Document R9A07G044 SoC variants, common compatiable string > > "renesas,scif-r9a07g044" is added for RZ/G2L and RZ/G2LC SoC. > > > > Signed-off-by: Lad Prabhakar > > Reviewed-by: Biju Das > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > @@ -64,6 +64,10 @@ properties: > > - const: renesas,rcar-gen3-scif # R-Car Gen3 and RZ/G2 > > - const: renesas,scif # generic SCIF compatible UART > > > > + - items: > > + - enum: > > + - renesas,scif-r9a07g044 # RZ/G2{L,LC} > > + > > reg: > > maxItems: 1 > > Looks good to me. > > Do interrupts and interrupt-names need to be updated? > The SCIF node added in "[PATCH 15/16] arm64: dts: renesas: Add initial > DTSI for RZ/G2{L,LC} SoC's" has 5 interrupts, while the bindings > support only 1, 4, or 6 interrupts. According to the SoC interrupt mapping, "tei" and "dri" share an interrupt, so 6 interrupts is correct, and this part of the binding does not need an update. Reviewed-by: Geert Uytterhoeven Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel