linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: geert@linux-m68k.org (Geert Uytterhoeven)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: wheat: add SDHI0 support
Date: Wed, 31 Aug 2016 09:06:34 +0200	[thread overview]
Message-ID: <CAMuHMdXbVPigVM=ObWY724B6Yf1TFWBn2j9q2RVWse=Z57ovvA@mail.gmail.com> (raw)
In-Reply-To: <1659137.gEKJxNrmrk@wasted.cogentembedded.com>

Hi Sergei,

On Wed, Aug 31, 2016 at 12:24 AM, Sergei Shtylyov
<sergei.shtylyov@cogentembedded.com> wrote:
> Define the Wheat board dependent  part of  the SDHI0 (connected to the
> micro-SD slot)  device node along with the necessary voltage regulator.
>
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>
> ---
> This patch is against the 'renesas-devel-20160830-v4.8-rc4' of Simon Horman's
> 'renesas.git' repo plus the CAN patch posted yesterday.
> Starting with this patch, SMSC LAN89218 Ethernet chip starts to misbehave on my
> board...

Are GP11_11 or GP11_12 connected to the Ethernet chip?
Does the misbehaving go away if you drop
  - cd-gpios?
  - The regulator?
  - sdhi0-pins (there may be a bug in the pfc register bit definitions)?

>  arch/arm/boot/dts/r8a7792-wheat.dts |   26 ++++++++++++++++++++++++++
>  1 file changed, 26 insertions(+)
>
> Index: renesas/arch/arm/boot/dts/r8a7792-wheat.dts
> ===================================================================
> --- renesas.orig/arch/arm/boot/dts/r8a7792-wheat.dts
> +++ renesas/arch/arm/boot/dts/r8a7792-wheat.dts
> @@ -11,6 +11,7 @@
>
>  /dts-v1/;
>  #include "r8a7792.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
>
>  / {
>         model = "Wheat";
> @@ -54,6 +55,17 @@
>                 pinctrl-0 = <&lan89218_pins>;
>                 pinctrl-names = "default";
>         };
> +
> +       vcc_sdhi0: regulator-vcc-sdhi0 {
> +               compatible = "regulator-fixed";
> +
> +               regulator-name = "SDHI0 Vcc";
> +               regulator-min-microvolt = <3300000>;
> +               regulator-max-microvolt = <3300000>;
> +
> +               gpio = <&gpio11 12 GPIO_ACTIVE_HIGH>;
> +               enable-active-high;
> +       };
>  };
>
>  &extal_clk {
> @@ -86,6 +98,11 @@
>                 groups = "can1_data";
>                 function = "can1";
>         };
> +
> +       sdhi0_pins: sdhi0 {
> +               groups = "sdhi0_data4", "sdhi0_ctrl";
> +               function = "sdhi0";
> +       };
>  };
>
>  &scif0 {
> @@ -108,3 +125,12 @@
>
>         status = "okay";
>  };
> +
> +&sdhi0 {
> +       pinctrl-0 = <&sdhi0_pins>;
> +       pinctrl-names = "default";
> +
> +       vmmc-supply = <&vcc_sdhi0>;
> +       cd-gpios = <&gpio11 11 GPIO_ACTIVE_LOW>;
> +       status = "okay";
> +};

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

  reply	other threads:[~2016-08-31  7:06 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-14 20:18 [PATCH 0/3] Add R8A7792/Blanche CAN support Sergei Shtylyov
2016-07-14 20:19 ` [PATCH 1/3] ARM: dts: r8a7792: add CAN clocks Sergei Shtylyov
2016-07-15  3:19   ` Geert Uytterhoeven
2016-07-14 20:20 ` [PATCH 2/3] ARM: dts: r8a7792: add CAN support Sergei Shtylyov
2016-07-15  3:21   ` Geert Uytterhoeven
2016-07-14 20:21 ` [PATCH 3/3] ARM: dts: blanche: add CAN0 support Sergei Shtylyov
2016-07-18  2:10 ` [PATCH 0/3] Add R8A7792/Blanche CAN support Simon Horman
2016-08-29 20:11 ` [PATCH] ARM: dts: wheat: add " Sergei Shtylyov
2016-09-03 21:50   ` Sergei Shtylyov
2016-09-05 12:03     ` Simon Horman
2016-08-30 22:24 ` [PATCH] ARM: dts: wheat: add SDHI0 support Sergei Shtylyov
2016-08-31  7:06   ` Geert Uytterhoeven [this message]
2016-09-03 21:49   ` Sergei Shtylyov
2016-09-05 12:07     ` Simon Horman
2016-09-01 21:29 ` [PATCH] ARM: dts: wheat: add DU support Sergei Shtylyov
2016-09-12 17:52   ` Sergei Shtylyov
2016-09-16 10:11     ` Simon Horman
2016-09-22 21:06 ` [PATCH v2] " Sergei Shtylyov
2016-09-23  7:37   ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMuHMdXbVPigVM=ObWY724B6Yf1TFWBn2j9q2RVWse=Z57ovvA@mail.gmail.com' \
    --to=geert@linux-m68k.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).