From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF039C4742C for ; Mon, 16 Nov 2020 17:19:08 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51C5020797 for ; Mon, 16 Nov 2020 17:19:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="l2D3qEuT"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Wf3kB4A1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 51C5020797 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1A5WAL6McyQlZi+gYoYzZ78bkLt+V/BpQPhE4jf2u7c=; b=l2D3qEuTVjcqSw8Fj9XJCx/sb TVAWdfw6m4FJ94tgjYfezltLok6HUU0mZp2IAQmtL2eATMY9V9dAGnMRWTFoYG1f6EbdNY5rWtWWr DY8kZUx//vXIlSl8mYbVwTLpYq7magpKhCIjOgtmtqwDZ+rHmKXMKPeSO8eDRjv8DxCfoy0baI3ni ZsnrlxaS04uxKYJJ+aGzJV67soY4hvft03fiCx8V5yw8JMODDXDMTkdzcbgBUZF4+2sBKdN9VU6kI ugsZL/E14YF65dWPkqxflPCbXXl6vkNP8fgB3FHzzQkRgov7eQverQbw49j5rINLu1HgFqSvVn95z yj/AGNbtQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kei8d-0006hx-ND; Mon, 16 Nov 2020 17:17:59 +0000 Received: from mail-qt1-x836.google.com ([2607:f8b0:4864:20::836]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kei8b-0006fd-I7 for linux-arm-kernel@lists.infradead.org; Mon, 16 Nov 2020 17:17:58 +0000 Received: by mail-qt1-x836.google.com with SMTP id 3so13437208qtx.3 for ; Mon, 16 Nov 2020 09:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RY7dzZjNXgsnJCVVQm8TyT/jUzYsH7NzXH3Mac7B9Rw=; b=Wf3kB4A140V5E08ma2vQlRfFr7iwHao00b8EDxrwHAUlbrApv9/MDn9ZD/TXcGlNj+ rRfETVYLjXsvAsVTe1GfWzN1dC8IPcJbeLuscQx38hNfq+/vfXpQ9iTB6bhtkOEIbn3s gOs8ztPYmRMRtsLn0Icorskz/foCpzs1RS5K3e5F6svPBHTtXmOFB1nVnjOubd4Vrb9O IYlOuEfsNgWsXVO47Irs1t48pObB+PKbjCRO1/40tkKh0DEF/hSo573z6dmQQzRQ9A/K DMujZU+uI8hdyIwAFsJzjXvPPrjVjcg9DwaEujb6eZi6XW2FqjIWTQQyxnB0+4JaN1GN CMbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RY7dzZjNXgsnJCVVQm8TyT/jUzYsH7NzXH3Mac7B9Rw=; b=Hv4Q+Of5cFwaYNQuehoQ7vEfYKbBqijYHno3pjRQ+evAMvWedfpECYRZ61x3g1v+43 QpJ9EqLpOdu2PCfSuX3KM3W/fetqqqiwzrSaNhFEwwlSQRkX+/K7p5j+hfhOfNJig+PK 6TterjhYk4CcJHLSzkSlNqbhrBfZZ2yyPp9PmxMijRMjpEfwz0FgRoi+kL0bMNj94Mpn /s5oVPuE+2iN+W/Zu0MzIBHgprsbJsXyj5Sd9R0KCiS2STVWjupNMDvYgdW2+VJwKjzB qghsTX9em5CjSdsif6me8j9Zh89wqx1feL1SPMQOsdAUATN1Iij/3kyR89X1QK968GkG hnRQ== X-Gm-Message-State: AOAM532u9RUgbx8hI02CK8wrIibDy0kjdrk67quvXBX8fvWWW94nDpQH h2ZpWwnxcHTblFfzlZscf2Ym8swRgGcR8cwUmxUVvw== X-Google-Smtp-Source: ABdhPJy1GZi3KsRmAdk3ycATA59ZxIy129o62tCASlipDogQ69pc6V+0XGxARQ9IQ0+E6+bmdfk9CCJ24zuhMKmPwyk= X-Received: by 2002:aed:22ab:: with SMTP id p40mr14640722qtc.200.1605547068880; Mon, 16 Nov 2020 09:17:48 -0800 (PST) MIME-Version: 1.0 References: <20201026144943.30821-1-grzegorz.jaszczyk@linaro.org> In-Reply-To: From: Grzegorz Jaszczyk Date: Mon, 16 Nov 2020 18:17:37 +0100 Message-ID: Subject: Re: [PATCH] soc: ti: pruss: Remove wrong check against *get_match_data return value To: Suman Anna X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201116_121757_713964_58175518 X-CRM114-Status: GOOD ( 12.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Bajjuri, Praneeth" , Santosh Shilimkar , linux-kernel@vger.kernel.org, tony@atomide.com, Wei Yongjun , Santosh Shilimkar , linux-omap@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Suman, On Tue, 10 Nov 2020 at 21:43, Suman Anna wrote: > > Hi Greg, > > On 10/26/20 9:49 AM, Grzegorz Jaszczyk wrote: > > Since the of_device_get_match_data() doesn't return error code, remove > > wrong IS_ERR test. Proper check against NULL pointer is already done > > later before usage: if (data && data->...). > > > > Additionally, proceeding with empty device data is valid (e.g. in case > > of "ti,am3356-pruss"). > > > > Reported-by: Wei Yongjun > > Please add the appropriate Fixes: tag. > > And prefer %s/Remove/Fix/ in patch title. Sure. > > With that, > Acked-by: Suman Anna Thank you, I will post v2 with all improvements soon. Best regards, Grzegorz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel