From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CD4CC433E0 for ; Tue, 22 Dec 2020 15:59:19 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 40378221FA for ; Tue, 22 Dec 2020 15:59:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 40378221FA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aLs4zE5rUL28lnTBs5V/irZJqM+BYnKJv42gcpTxdrI=; b=t/zgkcySQW+yFGMMikB/oi+6B Xx0739OdcujAw0XMw5S8NKXq3o47Fw4bs8Mq7m3AjhL3NAKPr4SODhxBW03NEBQAn6I1PzXSaOOCU 1L93ccgjKI4mE2Vcyf5/tEZcJAbIXaYedRz7wZDM5cFS3fO9SD/JZzXdSyyesGBof5kTJxrOM+to0 j84B88vZX4leBj48xorazPwm2b3SAHSqIHY1mtspGLceFMWT/CLtiadlsAJWU0YY7yXTS3WWTXrI2 paav5VPJADUCv08JHzFvtFgEUH+cINaKoiARw0LIDptTTq0HYpRNEfMsCvU3RLJlXvfOr+ASq3sEO Mw4AM+Tbw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1krk2z-0007cw-BB; Tue, 22 Dec 2020 15:58:01 +0000 Received: from mail-qk1-x729.google.com ([2607:f8b0:4864:20::729]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1krk2w-0007cI-BB for linux-arm-kernel@lists.infradead.org; Tue, 22 Dec 2020 15:57:59 +0000 Received: by mail-qk1-x729.google.com with SMTP id b64so12208589qkc.12 for ; Tue, 22 Dec 2020 07:57:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tSbt+6uAU0/n70HJg2Z4UTZW3SPBYifyx/RQerMQRfc=; b=v7KC8FXXHyCRgKzSN1WdkZDILxNnZ3Tz50y2318GZEHFh2OgiVvbWtDas110A8j1bC bEUiYC07U4pNjkhq5tMD+838LcJrm+4obowXGjaHsc3RA+uiGe0rNYbBNCKn52aZEwnC BmcivK/TRVARKJegXMu8ZFzRsFfrV6Y7RPlm3CCXYLmXCCvVZPZII7ey3+RAXWnuHYkw VbEPi9Vqp1tuNwtjvV0bwxS+nhv1FE0yn+SLr/afAFKEWLTfcHUaQtvx/8wiFeBmYSxX ZjtuPMNqwpNZohmsmlH7kRYZXt9GF3YqcZAdXzrmFIEU9pwaL8VXAIbq3OJSqwbpIN0G E/IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tSbt+6uAU0/n70HJg2Z4UTZW3SPBYifyx/RQerMQRfc=; b=pHkikW9QwfQu+SU/x7RAuLmOBbvgh/4VifSPg6RZ3cLqhOU8CBAxVhus0foUScNsSt JiiYt8KS37u7oF96tE07x6TKxiY9jpesbI/HhY8953+HgfCGn8c2xzaeu4kW+VBIj3DE 3/bnYwDQsmQNFBCxBQrPKyfpL0kjdzBhkQDfkl7XCCbOJXkDz8CDKPwcveMeAVwA6kyI dOo+RGfzZk4pnHC0tiT89HWg5SELW1cMgmoqt8m5afn5aLTalc/vpPrErvqg0R+R8OsS BKxtKUbAya1STq/oQKXAT51lA/YY4Ko6YgkyLzY258qVYUzCCCnU4VR34Tv4BHeIDEBS yu4A== X-Gm-Message-State: AOAM530c+BbSUlxrP2GCWs41KU7lhl3mL6I7wvuALfw8BcMt788xKvYC DMELCEG++FnXMOASoxk/ouqg39FsrBJuyPNTBK4yFw== X-Google-Smtp-Source: ABdhPJyepNPHP4E52r1tz6fvELiPwmDt6Q5gFH4TExNWOuUpN0HYpkwqkhdR3ClOmYLtVmWMmX7T7ktkH+FPYq0fd1o= X-Received: by 2002:a05:620a:12b9:: with SMTP id x25mr23021282qki.421.1608652674817; Tue, 22 Dec 2020 07:57:54 -0800 (PST) MIME-Version: 1.0 References: <20201211142933.25784-1-grzegorz.jaszczyk@linaro.org> <20201211142933.25784-2-grzegorz.jaszczyk@linaro.org> <20201214225842.GA2537432@robh.at.kernel.org> In-Reply-To: From: Grzegorz Jaszczyk Date: Tue, 22 Dec 2020 16:57:43 +0100 Message-ID: Subject: Re: [PATCH 1/5] dt-bindings: remoteproc: Add PRU consumer bindings To: Rob Herring X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201222_105758_700010_B706AF5E X-CRM114-Status: GOOD ( 31.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben Cohen , devicetree@vger.kernel.org, linux-omap , Mathieu Poirier , "Bajjuri, Praneeth" , "open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Bjorn Andersson , Santosh Shilimkar , Lee Jones , linux-arm-kernel , Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Rob, On Fri, 18 Dec 2020 at 23:51, Rob Herring wrote: > > On Wed, Dec 16, 2020 at 9:55 AM Grzegorz Jaszczyk > wrote: > > > > Hi Rob, > > > > On Mon, 14 Dec 2020 at 23:58, Rob Herring wrote: > > > > > > On Fri, Dec 11, 2020 at 03:29:29PM +0100, Grzegorz Jaszczyk wrote: > > > > From: Suman Anna > > > > > > > > Add a YAML binding document for PRU consumers. The binding includes > > > > all the common properties that can be used by different PRU consumer > > > > or application nodes and supported by the PRU remoteproc driver. > > > > These are used to configure the PRU hardware for specific user > > > > applications. > > > > > > > > The application nodes themselves should define their own bindings. > > > > > > > > Co-developed-by: Tero Kristo > > > > Signed-off-by: Tero Kristo > > > > Signed-off-by: Suman Anna > > > > Co-developed-by: Grzegorz Jaszczyk > > > > Signed-off-by: Grzegorz Jaszczyk > > > > --- > > > > .../bindings/remoteproc/ti,pru-consumer.yaml | 64 +++++++++++++++++++ > > > > 1 file changed, 64 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > > > > > > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > > new file mode 100644 > > > > index 000000000000..2c5c5e2b6159 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-consumer.yaml > > > > @@ -0,0 +1,64 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > > > +%YAML 1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/remoteproc/ti,pru-consumer.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: Common TI PRU Consumer Binding > > > > + > > > > +maintainers: > > > > + - Suman Anna > > > > + > > > > +description: | > > > > + A PRU application/consumer/user node typically uses one or more PRU device > > > > + nodes to implement a PRU application/functionality. Each application/client > > > > + node would need a reference to at least a PRU node, and optionally define > > > > + some properties needed for hardware/firmware configuration. The below > > > > + properties are a list of common properties supported by the PRU remoteproc > > > > + infrastructure. > > > > + > > > > + The application nodes shall define their own bindings like regular platform > > > > + devices, so below are in addition to each node's bindings. > > > > + > > > > +properties: > > > > + prus: > > > > > > ti,prus > > > > Thank you - I will change and post v2 but with this I will run into > > issues when this binding will be referenced by some consumer YAML > > binding. Running dtbs_check in such case throws: > > ... k3-am654-base-board.dt.yaml: serial@28000: 'ti,prus' does not > > match any of the regexes: 'pinctrl-[0-9]+' > > In the same time if I will remove this property from that node I am getting: > > ... k3-am654-base-board.dt.yaml: serial@28000: 'ti,prus' is a required property > > as expected. > > Sounds like you didn't update 'ti,prus' in whatever schema you include > this one from. > > > > > Getting rid of the comma from this property name workarounds mentioned > > problem (which is not proper but allows me to correctly test this > > binding): e.g. s/ti,prus/ti-pruss/ or using the previous name without > > a comma. > > It seems to be an issue with dtbs_check itself which we will encounter > > in the future. > > If not, can you point me to a branch having this problem. Sure, here is temporary branch with 4 last commits demonstrating mentioned issues (when property name contains comma): https://git.linaro.org/people/grzegorz.jaszczyk/linux.git/log/?h=ti-pruss-binding-issue The last commit gets rid of the comma from properties names which successfully w/a the problem. Please note that those are only TEMP commits which demonstrates the mentioned issue. I've put error logs with some notes in commit log to ease understanding what issues are seen when. Thank you in advance, Grzegorz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel