From: Baolin Wang <baolin.wang@linaro.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: Chunyan Zhang <zhang.lyra@gmail.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5] mmc: host: sdhci: Fix the incorrect soft reset operation when runtime resuming
Date: Fri, 26 Jul 2019 09:41:15 +0800 [thread overview]
Message-ID: <CAMz4kuKOGmGHoYNELG38qYOw71=AaSk33=johskUtOs0KZ0z-g@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFoNGZRdY3VVf6G9eNBfCyJbN5SUU2+fK24U-mHDX13oFQ@mail.gmail.com>
On Thu, 25 Jul 2019 at 21:15, Ulf Hansson <ulf.hansson@linaro.org> wrote:
>
> - Trimmed cc list
>
> On Thu, 25 Jul 2019 at 05:14, Baolin Wang <baolin.wang@linaro.org> wrote:
> >
> > The SD host controller specification defines 3 types software reset:
> > software reset for data line, software reset for command line and
> > software reset for all. Software reset for all means this reset affects
> > the entire Host controller except for the card detection circuit.
> >
> > In sdhci_runtime_resume_host() function, now we will always do software
> > reset for all, which will cause Spreadtrum host controller work abnormally
> > after resuming. For Spreadtrum platform that will not power down the SD/eMMC
> > card during runtime suspend, we should just do software reset for data
> > and command instead doing reset for all.
> >
> > To fix this issue, this patch introduces a new parameter of
> > sdhci_runtime_resume_host() to let it decide if a 'reset for all' shall
> > be done or not. Meanwhile changes other host drivers to issue a software
> > reset for all to keep the original logic.
> >
> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org>
>
> Applied for next, with a little change (renaming the "soft"
> in-parameter to soft_reset), thanks!
Thanks Ulf :)
>
> Adrian, if there is anything you want to change, please tell.
>
> BTW, perhaps this should be applied for fixes and tagged for stable?
> Baolin, if so, can point me the commit (or stable tag) the patch
> fixes?
Yes, since we fixed the PM runtime issue, which will reveal this
issue. And I think it still fixes:
Fixes: fb8bd90f83c4 ("mmc: sdhci-sprd: Add Spreadtrum's initial host
controller")
Thanks.
--
Baolin Wang
Best Regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-26 1:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 3:14 [PATCH v5] mmc: host: sdhci: Fix the incorrect soft reset operation when runtime resuming Baolin Wang
2019-07-25 13:14 ` Ulf Hansson
2019-07-26 1:41 ` Baolin Wang [this message]
2019-08-02 15:16 ` Ulf Hansson
2019-08-05 5:45 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMz4kuKOGmGHoYNELG38qYOw71=AaSk33=johskUtOs0KZ0z-g@mail.gmail.com' \
--to=baolin.wang@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).