From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C28C3A5A4 for ; Sun, 1 Sep 2019 13:57:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8FD5B233A2 for ; Sun, 1 Sep 2019 13:57:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JxWhXvDE"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SJ2HR+ZX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8FD5B233A2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tDL69ZXsl/D4WXpe5NEGLs3N+Wlr2xZwL7GQWWA/ht8=; b=JxWhXvDESHmpzG ppn5g3U2fX5zQFVraqhso8JJfOp/NXN68DPM8J5R4He+ikl1pxwJxp+RHgP3bLFaLUXYyEDjPvsV3 FPO9T4ATtX9R8fv1Mv0srrsCM4sXpjAeLP39dA3Z9tK70I1wQtJapNxb5ju4hRcUqglmTX4RPrZ8u ELbAqfhYt9rYFuFSYiq2TK/ikURw3h8Mn237X52Qf2z7tx9wcIwjGI8VRLG49/h5xA6Q2qEY6jaGK 1BWFSyRgzVVcIiTae12hjtR7myUfa1OtikQbUbk7wxEW4d0y6SHR0kTHsVCUWj01G4dAiokut1a0K aSN38Q/ioCYvECw2n94Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i4QLt-0006BA-0A; Sun, 01 Sep 2019 13:57:09 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i4QLn-0006AM-N7; Sun, 01 Sep 2019 13:57:05 +0000 Received: by mail-io1-xd42.google.com with SMTP id p12so24173122iog.5; Sun, 01 Sep 2019 06:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DlZdrf9Irxs4fo8S+BI75RsfTncmV298kgaHuNHnRpA=; b=SJ2HR+ZX4CCLpMwYVrMm4tC48zXsqIaDeOJpgI3Pu3aF57K2+/GDf7STWkbYhRe2jR 7G6ODjRtP47aLxPmSBBqyyqGzi3KCb2cqBA399LgCItWnhLzUke/Y463BhS5rQjdJQTK 1BkGi60BKBY0TjPWuG0De2lTR4hD+X4qFbNhpF9j+6ldhAF1FEkBqt5Oy8zEpeW1sj6g t3yKMcSIaRw2WJb4SzaAwvl8LSCsOy0JEyEOFMJYk4CAt+qCWeDjeABNCA6XWck+s3i4 L+VsTBC+P8E3bxrBz+29duUA/AtUC8ML5kSvPq7G7g0DIxZN8tFz+7M4fUgzRKVWscmj GAsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DlZdrf9Irxs4fo8S+BI75RsfTncmV298kgaHuNHnRpA=; b=iObKkhUmQK7C8+7SrFUFKN13y/wSPPeT7uVERNqh46CNlpOD6PfBpKwTmFoZ5+xT7R SKDBm6eZIm/wcxtduMPHVLGazpK4hKCpFuGHr+gSQK9uNsn+G3aa6hNF1RSyOssuzvph wI0LbhCNhad6cRrU0i+LLguZx3bsAXD+70IqTCiqfvFLP+GgCTHREzo1AvOEdHv+tHJq hNOB2oFnJkJ+LhUFlQrvx1Ic3NLkrqDV98lxI/fVsKR+eLXZEYY0YNdbUsDm3CdISH5i dO5kT61vhr+HvFUfsJ2TTiVGp/TxNAmuUtYscAD+OrVJclC0CDpeacBohxexbBZkbctI OzzA== X-Gm-Message-State: APjAAAUv/Ov3xLmKginG7e/I91wR2lHunZN4TYHB0L+nBGCMVpQQlNdx Jq8T0DWT2uJriRMTsyigzy1JEkwHRjdHwx2UUCYkGw== X-Google-Smtp-Source: APXvYqxYOm/Hc/RFqCzlkxBEZ30dho7qz2hnto+SyaO5xK9jP5vx8O05CRf6dpJlVvYT87HcbjJnLhCQXciWgSqFGEw= X-Received: by 2002:a6b:c810:: with SMTP id y16mr5973464iof.75.1567346220862; Sun, 01 Sep 2019 06:57:00 -0700 (PDT) MIME-Version: 1.0 References: <20190828202723.1145-1-linux.amoon@gmail.com> <20190828202723.1145-3-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Sun, 1 Sep 2019 19:26:47 +0530 Message-ID: Subject: Re: [PATCHv1 2/3] arm64: dts: meson: odroid-c2: Add missing regulator linked to VDDIO_AO3V3 regulator To: Martin Blumenstingl X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190901_065703_756883_C538ABCA X-CRM114-Status: GOOD ( 19.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , Neil Armstrong , Kevin Hilman , Linux Kernel , Rob Herring , linux-amlogic@lists.infradead.org, linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, Thanks of your review comments. On Sun, 1 Sep 2019 at 17:11, Martin Blumenstingl wrote: > > On Wed, Aug 28, 2019 at 10:27 PM Anand Moon wrote: > > > > As per shematics TFLASH_VDD, TF_IO, VCC3V3 fixed regulator output which > typo: "schematics" > Ok > > is supplied by VDDIO_AO3V3. > please add a short sentence to the description (since you probably > have to re-send a v2) like: > "While here, move the comment name with the signal name in the > schematics above the gpio property to make it consistent with other > regulators" > Ok I will append this in next version. > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > with the patch rebased (see below) and the two issues from above addressed: > Reviewed-by: Martin Blumenstingl > > > --- > > arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > index 98e742bf44c1..a078a1ee5004 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-odroidc2.dts > > @@ -67,17 +67,19 @@ > > }; > > > > tflash_vdd: regulator-tflash_vdd { > > - /* > > - * signal name from schematics: TFLASH_VDD_EN > > - */ > > compatible = "regulator-fixed"; > > > > regulator-name = "TFLASH_VDD"; > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* > > + * signal name from schematics: TFLASH_VDD_EN > > + */ > > gpio = <&gpio GPIOY_12 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > + /* U16 RT9179GB */ > > + vin-supply = <&vddio_ao3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > @@ -95,6 +97,8 @@ > > > > states = <3300000 0 > > 1800000 1>; > > + /* U12/U13 RT9179GB */ > > + vin-supply = <&vddio_ao3v3>; > > }; > thank you for the patch but I think it won't apply on top of Neil's > "arm64: dts: meson: fix boards regulators states format" (which was > applied just after you sent this series) > > > Martin Ok will re-base these changes on linux-next next time. Best Regards -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel