From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE387C43613 for ; Mon, 24 Jun 2019 13:43:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A695D208E4 for ; Mon, 24 Jun 2019 13:43:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AjQNHN2k"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="WqahhA0v" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A695D208E4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xt97gb44KQ7WG3cv1lxmKqIE52eM9A9Lww4gxF+EHSo=; b=AjQNHN2kFdw7Uq 3BSeX0PrBDFmj7b/2YwenXYR4lMtzp6RF8UUMad/IdT4AmSdLHBaysdxjaPEiyZz3movFH4BduK1V DoEPqvNe820gngQQhe0rVvAPm9mSiAcdxpvR+N4kwjUCG5aaQcGPwe0jDxK9lTGbZXne6c9Sv/ZXe y2HHIp4kuWoUh4MiT7PFiJKXwLWiKzUkFGODxy6cNwGzBpAvxTRqnkTkyssqO70anvmvM5GlYoP+A Vh7gJdulbZY9AUSjpKBxZ8vOMqNBgUp9bW/brCIQYsAO8q31wuiAA1z3KVfxN7jPJy8DmcD3oBxIq W9t0HPxLmuSHvuu3xSSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfPFQ-0006xe-7V; Mon, 24 Jun 2019 13:43:04 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfPFM-0006oS-WA for linux-arm-kernel@lists.infradead.org; Mon, 24 Jun 2019 13:43:02 +0000 Received: by mail-io1-xd42.google.com with SMTP id n5so2134271ioc.7 for ; Mon, 24 Jun 2019 06:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JAY+HO+se6M27BJLGy2WaRXVtQjt3tup0p+M/AykcYU=; b=WqahhA0vGT09ygQXdubtYD5Lz8cEW9fjhcYm97RgfF6N2/isRXcUjN3KMzuLlAScL2 uB1+yrJlpzeAGIVXLqeyKk4Vv85+P8jeJFXi+iruawOOdanDNRNg8aoHp1CPiDmlYVSC 6U6VpETeSl0kXNREKCfsI8At3rHRNCu0EpJHK/dETrHs2ALcqFSRc3oLzsWKipgN8xM/ T1+lJaRW9mkfN/FM8N2bu1xaMckb8WFtWM0ymwCaaUbnCX6j5Wl3/3Fcu7P6cZBagDZm qF6gd2YkmuYRFi1rjW+ke9AcQTdaKKhb/17oQHB4k5i+20d0/O1EfWR42JOMSVp5noas SpKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JAY+HO+se6M27BJLGy2WaRXVtQjt3tup0p+M/AykcYU=; b=ALr20y0uRUGKRoIAG56nNtMzLiRSFrk/iYiwd8ZTXj/kAovnwypqaeIH3tMujWw27T 2NiRh3AqC0A1/qvvkajt6IA5ODgM5+6/TuQBbBZ9xlCiwnBDyN0ifuf3fm2bGQkwfeAZ 51/bU1DJOdaByOXmF7H90n2OV9gSRvVJyPxZD1XRHeA9s9XMJeJ7gKqn041ATSx4kLhs 4/dP6mqkE2tl1PGOX2plAoQ6wLRHPjB1120inocy9vr09wX9/E/pvZnTlQiyDULvO9xS 2wUic7LIi65dqY35PSrBKeKoUeMKIW4nNekEJLrdnEoYarpnfNSk7pYfXxkJpYY6Y+jz gKPA== X-Gm-Message-State: APjAAAUamQpLqEShPs06EXqfKIKNNyzXxdgqMDJ+40yQGMDSTH6x4RPJ htqQ9xIgSC+ZrxyiEgcTF0KOla9+fi/OMbuvs814/VHM X-Google-Smtp-Source: APXvYqypl0IrSyDO/f7SI42d4NpFHa/7OZX0jXNbFpUASMxwh2fx0mJgfs/qVOYaLSUhLwF6DwSrz304TPAq9G/BjWs= X-Received: by 2002:a5e:c30f:: with SMTP id a15mr8320747iok.246.1561383779652; Mon, 24 Jun 2019 06:42:59 -0700 (PDT) MIME-Version: 1.0 References: <20190621155845.7079-1-krzk@kernel.org> <20190621155845.7079-3-krzk@kernel.org> <2f58b63e-adf1-7935-8849-f311dc991b84@samsung.com> In-Reply-To: <2f58b63e-adf1-7935-8849-f311dc991b84@samsung.com> From: Anand Moon Date: Mon, 24 Jun 2019 19:12:46 +0530 Message-ID: Subject: Re: [PATCH v2 3/4] ARM: dts: exynos: Add regulator suspend configuration to Odroid XU3/XU4/HC1 family To: Marek Szyprowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_064301_068954_8FA63AC7 X-CRM114-Status: GOOD ( 18.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , "linux-samsung-soc@vger.kernel.org" , Linux Kernel , Krzysztof Kozlowski , Kukjin Kim , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek / Krzysztof, On Mon, 24 Jun 2019 at 14:31, Marek Szyprowski wrote: > > Hi Krzysztof, > > On 2019-06-24 09:41, Krzysztof Kozlowski wrote: > > On Mon, 24 Jun 2019 at 09:20, Marek Szyprowski wrote: > >> On 2019-06-23 18:02, Anand Moon wrote: > >>> Thanks for this patch. Please add my > >>> > >>> Tested-by: Anand Moon > >>> > >>> [snip] > >>> > >>> Could you integrate below small changes into this patch. > >>> with these below changes suspend and resume work correctly at my end. > >>> > >>> [1] XU4_suspendresume.patch > >>> > >>> As per S2MPS11B PMIC 1.2.1 Regulator (Features) > >>> Fix the min max value for *Buck7* and *Buck8* > >>> > >>> -- Buck7 (VDD_1.0V_LDO) 1.5 A (1.2 V to 1.5 V, 12.5 mV step, default on 1.35 V) > >>> -- Buck8 (VDD_1.8V_LDO) 2.5 A (1.8 V to 2.1 V, 12.5 mV step, default on 2.0 V) > >> Could you elaborate why such change for Buck7 and Buck8 is needed? > > Anand has here valid point - the constraints in DTS do not match > > hardware manual. This leads to question whether voltage table in > > driver is proper... Another point is the voltage itself. The > > schematics describes them as at specific voltage (1.35 V and 2.0 V) > > but after boot they are 1.2 V and 1.85 V. Maybe this shift comes from > > the problem above. > > > >>> Also add suspend-off for *Buck9* > >>> Buck9 internally controls the power of USB hub. > >>> Adding suspend the this node help proper reset of USB hub on Odroid > >>> XU4 / HC1/ XU3 > >>> during suspend and resume. Below it the logs from my testing. > >> Disabling Buck9 in suspend indeed reduces the power consumed by the > >> board during suspend-to-ram from about 80mA to as little as 7-10mA, what > >> matches the results of OdroidXU3. Thanks for the hint! > > Although I did not get what is the difference in the logs (Anand > > pasted two logs but they look the same) but the power consumption is > > reason is good enough. I would be happy to put in the changelog entire > > consumption difference. I can measure it on XU3-Lite but can you give > > me the XU4 (before and after)?\ > > > HC1: > > next-20190620: 120mA (@5V) > this patchset: 72mA (@5V) > this patchset + fixup from Anand: 7-10mA (@5V) > > XU4 (SDcard): > > next-20190620: 88mA (@5V) > this patchset: 74mA (@5V), sometimes 42mA (@5V) > this patchset + fixup from Anand: 6-9mA (@5V) > > > XU4 (eMMC): > > next-20190620: 100mA (@5V) > this patchset: 72mA (@5V), sometimes 41mA (@5V) > this patchset + fixup from Anand: 6-9mA (@5V) > > > Best regards > -- > Marek Szyprowski, PhD > Samsung R&D Institute Poland > Thanks for this results. Best Regards -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel