linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [GIT PULL] coresight: Add support for ETE and TRBE
@ 2021-04-05 19:17 Mathieu Poirier
  2021-04-06  8:22 ` Marc Zyngier
  0 siblings, 1 reply; 3+ messages in thread
From: Mathieu Poirier @ 2021-04-05 19:17 UTC (permalink / raw)
  To: maz
  Cc: suzuki.poulose, anshuman.khandual, gregkh, linux-arm-kernel,
	linux-kernel, kvmarm

The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c:

  KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +0000)

are available in the Git repository at:

  git@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE

for you to fetch changes up to 7885b4e43231048654c5a80c0a18844ce3185e64:

  dts: bindings: Document device tree bindings for Arm TRBE (2021-04-05 11:38:04 -0600)

----------------------------------------------------------------
Hi Marc,

As previously agreed, here are the changes to support CoreSight
ETE and TRBE components submitted here[1].

I draw your attention to these:

[PATCH v6 05/20] kvm: arm64: Handle access to TRFCR_EL1
[PATCH v6 06/20] kvm: arm64: Move SPE availability check to VCPU load
[PATCH v6 07/20] arm64: kvm: Enable access to TRBE support for host

They are KVM specific and will need an SoB tag.

Thanks,
Mathieu

[1]. https://lore.kernel.org/linux-arm-kernel/20210405164307.1720226-1-suzuki.poulose@arm.com/T/#t

----------------------------------------------------------------

Anshuman Khandual (5):
      arm64: Add TRBE definitions
      coresight: core: Add support for dedicated percpu sinks
      coresight: sink: Add TRBE driver
      Documentation: coresight: trbe: Sysfs ABI description
      Documentation: trace: Add documentation for TRBE

Suzuki K Poulose (15):
      perf: aux: Add flags for the buffer format
      perf: aux: Add CoreSight PMU buffer formats
      arm64: Add support for trace synchronization barrier
      kvm: arm64: Handle access to TRFCR_EL1
      kvm: arm64: Move SPE availability check to VCPU load
      arm64: kvm: Enable access to TRBE support for host
      coresight: etm4x: Move ETM to prohibited region for disable
      coresight: etm-perf: Allow an event to use different sinks
      coresight: Do not scan for graph if none is present
      coresight: etm4x: Add support for PE OS lock
      coresight: ete: Add support for ETE sysreg access
      coresight: ete: Add support for ETE tracing
      dts: bindings: Document device tree bindings for ETE
      coresight: etm-perf: Handle stale output handles
      dts: bindings: Document device tree bindings for Arm TRBE

 .../ABI/testing/sysfs-bus-coresight-devices-trbe   |   14 +
 Documentation/devicetree/bindings/arm/ete.yaml     |   75 ++
 Documentation/devicetree/bindings/arm/trbe.yaml    |   49 +
 Documentation/trace/coresight/coresight-trbe.rst   |   38 +
 MAINTAINERS                                        |    2 +
 arch/arm64/include/asm/barrier.h                   |    1 +
 arch/arm64/include/asm/el2_setup.h                 |   13 +
 arch/arm64/include/asm/kvm_arm.h                   |    2 +
 arch/arm64/include/asm/kvm_host.h                  |    8 +
 arch/arm64/include/asm/sysreg.h                    |   50 +
 arch/arm64/kernel/hyp-stub.S                       |    3 +-
 arch/arm64/kvm/arm.c                               |    2 +
 arch/arm64/kvm/debug.c                             |   35 +-
 arch/arm64/kvm/hyp/nvhe/debug-sr.c                 |   56 +-
 arch/arm64/kvm/hyp/nvhe/switch.c                   |    1 +
 arch/arm64/kvm/sys_regs.c                          |    1 +
 drivers/hwtracing/coresight/Kconfig                |   24 +-
 drivers/hwtracing/coresight/Makefile               |    1 +
 drivers/hwtracing/coresight/coresight-core.c       |   29 +-
 drivers/hwtracing/coresight/coresight-etm-perf.c   |  119 +-
 drivers/hwtracing/coresight/coresight-etm4x-core.c |  161 ++-
 .../hwtracing/coresight/coresight-etm4x-sysfs.c    |   19 +-
 drivers/hwtracing/coresight/coresight-etm4x.h      |   83 +-
 drivers/hwtracing/coresight/coresight-platform.c   |    6 +
 drivers/hwtracing/coresight/coresight-priv.h       |    3 +
 drivers/hwtracing/coresight/coresight-trbe.c       | 1157 ++++++++++++++++++++
 drivers/hwtracing/coresight/coresight-trbe.h       |  152 +++
 include/linux/coresight.h                          |   13 +
 include/uapi/linux/perf_event.h                    |   13 +-
 29 files changed, 2053 insertions(+), 77 deletions(-)
 create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-trbe
 create mode 100644 Documentation/devicetree/bindings/arm/ete.yaml
 create mode 100644 Documentation/devicetree/bindings/arm/trbe.yaml
 create mode 100644 Documentation/trace/coresight/coresight-trbe.rst
 create mode 100644 drivers/hwtracing/coresight/coresight-trbe.c
 create mode 100644 drivers/hwtracing/coresight/coresight-trbe.h

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] coresight: Add support for ETE and TRBE
  2021-04-05 19:17 [GIT PULL] coresight: Add support for ETE and TRBE Mathieu Poirier
@ 2021-04-06  8:22 ` Marc Zyngier
  2021-04-06 17:58   ` Mathieu Poirier
  0 siblings, 1 reply; 3+ messages in thread
From: Marc Zyngier @ 2021-04-06  8:22 UTC (permalink / raw)
  To: Mathieu Poirier
  Cc: suzuki.poulose, anshuman.khandual, gregkh, linux-arm-kernel,
	linux-kernel, kvmarm

Hi Mathieu,

On Mon, 05 Apr 2021 20:17:57 +0100,
Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> 
> The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c:
> 
>   KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +0000)
> 
> are available in the Git repository at:
> 
>   git@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE
> 
> for you to fetch changes up to 7885b4e43231048654c5a80c0a18844ce3185e64:
> 
>   dts: bindings: Document device tree bindings for Arm TRBE (2021-04-05 11:38:04 -0600)
> 
> ----------------------------------------------------------------
> Hi Marc,
> 
> As previously agreed, here are the changes to support CoreSight
> ETE and TRBE components submitted here[1].
> 
> I draw your attention to these:
> 
> [PATCH v6 05/20] kvm: arm64: Handle access to TRFCR_EL1
> [PATCH v6 06/20] kvm: arm64: Move SPE availability check to VCPU load
> [PATCH v6 07/20] arm64: kvm: Enable access to TRBE support for host
> 
> They are KVM specific and will need an SoB tag.

There seem to be a disconnect here, because it works the other way
around.

If I pull this, I obviously cannot add anything to the patches that
are merged (changing stuff would result in changing the commit IDs,
which is exactly the opposite of what we are trying to achieve).

This isn't a problem, as the act of pulling the branch means that I am
happy with that, and the git merge makes it traceable.

However, some of the patches (the KVM ones) do not carry your own SoB,
which is a problem (if you are picking stuff off the list, you need to
add your own SoB). So for the couple of KVM patches, please add my

	Acked-by: Marc Zyngier <maz@kernel.org>

together with your SoB, resend the PR and I'll gladly merge it.

And if you can make sure the subject lines are formatted as:

	"KVM: arm64: Super Duper feature enablement"

that'd be absolutely awesome (but that's just me being annoying...).

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [GIT PULL] coresight: Add support for ETE and TRBE
  2021-04-06  8:22 ` Marc Zyngier
@ 2021-04-06 17:58   ` Mathieu Poirier
  0 siblings, 0 replies; 3+ messages in thread
From: Mathieu Poirier @ 2021-04-06 17:58 UTC (permalink / raw)
  To: Marc Zyngier
  Cc: Suzuki K. Poulose, Anshuman Khandual, Greg KH, linux-arm-kernel,
	Linux Kernel Mailing List, kvmarm

On Tue, 6 Apr 2021 at 02:22, Marc Zyngier <maz@kernel.org> wrote:
>
> Hi Mathieu,
>
> On Mon, 05 Apr 2021 20:17:57 +0100,
> Mathieu Poirier <mathieu.poirier@linaro.org> wrote:
> >
> > The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c:
> >
> >   KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +0000)
> >
> > are available in the Git repository at:
> >
> >   git@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE
> >
> > for you to fetch changes up to 7885b4e43231048654c5a80c0a18844ce3185e64:
> >
> >   dts: bindings: Document device tree bindings for Arm TRBE (2021-04-05 11:38:04 -0600)
> >
> > ----------------------------------------------------------------
> > Hi Marc,
> >
> > As previously agreed, here are the changes to support CoreSight
> > ETE and TRBE components submitted here[1].
> >
> > I draw your attention to these:
> >
> > [PATCH v6 05/20] kvm: arm64: Handle access to TRFCR_EL1
> > [PATCH v6 06/20] kvm: arm64: Move SPE availability check to VCPU load
> > [PATCH v6 07/20] arm64: kvm: Enable access to TRBE support for host
> >
> > They are KVM specific and will need an SoB tag.
>
> There seem to be a disconnect here, because it works the other way
> around.
>
> If I pull this, I obviously cannot add anything to the patches that
> are merged (changing stuff would result in changing the commit IDs,
> which is exactly the opposite of what we are trying to achieve).
>
> This isn't a problem, as the act of pulling the branch means that I am
> happy with that, and the git merge makes it traceable.
>
> However, some of the patches (the KVM ones) do not carry your own SoB,
> which is a problem (if you are picking stuff off the list, you need to
> add your own SoB). So for the couple of KVM patches, please add my
>

I wasn't clear on how to handle the KVM patches and as such decided to
proceed conservatively...

>         Acked-by: Marc Zyngier <maz@kernel.org>
>
> together with your SoB, resend the PR and I'll gladly merge it.
>

And I didn't want to SoB those patches because I am not in a position
to cast judgement on them, but with your Ack it changes everything.

> And if you can make sure the subject lines are formatted as:
>
>         "KVM: arm64: Super Duper feature enablement"

No problem.

>
> that'd be absolutely awesome (but that's just me being annoying...).
>

I'll do a respin of this in a couple hours.

> Thanks,
>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-06 18:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-05 19:17 [GIT PULL] coresight: Add support for ETE and TRBE Mathieu Poirier
2021-04-06  8:22 ` Marc Zyngier
2021-04-06 17:58   ` Mathieu Poirier

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).