From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A53C7ECAAD1 for ; Thu, 1 Sep 2022 16:54:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rPfs2f5OivPbTR/urWLjrLFnvBRXWcHuyBw8C3AlQdA=; b=b33uWkLHy7nrxx JPDq2XVWRo8YEKvBkWDNBrfaL9ZXF6rRYKlqnCwOerewMlzrT4T5wk2QmvqCYspyoHVKMjLvMuPfW 9yCff9I4Gvvv7khCUB0cdhjz9dgoXA50IKwK2cxj7k56e5l8cTF44G22XVBcS3n+AD/kkfaVYXA5D KrBedd8FqOAuR2Ppox9/L5+7zfE6uMeFbttFbfLghI4OjrFIOJH+jO8etzf/bcoK75R7PfqwrKBS6 SOPROlMJTcuPHYB+TKjJ4bxR7jveX9JgfK6bROK2jeQDVZd10ywM3Cw/Vkq//BuqN5E95LSe1XPl+ wkYiBo3lqBDsIuYmmTGA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnRr-00DR5F-5f; Thu, 01 Sep 2022 16:53:47 +0000 Received: from mail-ed1-x52d.google.com ([2a00:1450:4864:20::52d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnRn-00DR42-Qq for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 16:53:45 +0000 Received: by mail-ed1-x52d.google.com with SMTP id u6so23360054eda.12 for ; Thu, 01 Sep 2022 09:53:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Utwb8GsJ5vvsHM/8ip4meWVPitKeqc5FGHGRSAfVV1w=; b=uuVU7Qb42ctTfJWZO3i/M1EEOb/t50IiLitHlYcYPqXB7Gn3xj8XYN6XUsanpJg2x8 D0wcHWl2TQOkRbNEQO6vErb2UHK4FGfZP4FHbIKiAD0nZOpJG7laRyNm0j4PgcojrDKY DiLLA7+KYZfpzxh3tcEHBxzNg1d3mIiPu+JAkvfg2rMHJ9BUjTgG+2hWxYYabAk26Jfp DMniZkCg9c8JGKFQvZ83biVv0rZAO4ENk1r/8ZNAxYEry8r8RS04sk1bgdKXeO2zQS/x Eg+Z+TgX4tK+nd2Q8+mFFFS6mkedtRxaxcCy22i1A8nFjOcWwX+gaPIzXBkdqUf5A38o Gpjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Utwb8GsJ5vvsHM/8ip4meWVPitKeqc5FGHGRSAfVV1w=; b=cpz+gtEWGfyTKyp/kQdRmEoXJDINwwOcBYUmnqsNM4WE0rG3MdJGKkDyJ+B1Jqhzn/ /J0tddQztVKT5XEo7/zMBG70y5sc9DDAwoYscOE2NGpdnnrxkPsUU0W4GVr6NMhF95B2 3uY1G8HGteU1BajjFmaRtNRuPxlhGGFjsLlAp0uixPe/nAJev9GykekRSN4BXXHYOxnK wJFOcyb2zZftQ/svAMfh2rJofChzTxildkk6hBrIcqxJKMDo3yHAkJ9arrd6u0159ASE +XKq/fWQ5RW8/ofr3kwXwmbciX0IJG9HEI5+/vdpXBMYmNVOnlMVQYUFqhNnWB4zCf2z vSTA== X-Gm-Message-State: ACgBeo3AyuuMFgFGfcHTw34gjjP7w6ncBng+8e3E0cgKd/bWlx6teZFA n6uDTE7Jn3RahF1twF9bkwsNtKA/xvy7FvZ1xILZHg== X-Google-Smtp-Source: AA6agR45bngCQB/O3nd8cwlu63JO4zrVqmKjTWp+JWEZlCfacAqcPmpOQjDaXmcnIvtxZi2/S+7XjXZbpQpcxHRwemY= X-Received: by 2002:a05:6402:538f:b0:444:c17b:1665 with SMTP id ew15-20020a056402538f00b00444c17b1665mr29843511edb.98.1662051221046; Thu, 01 Sep 2022 09:53:41 -0700 (PDT) MIME-Version: 1.0 References: <20220816114414.4092-1-yangyicong@huawei.com> <86bfaabc-43e3-bcfb-faf9-74a0d79ab2ec@huawei.com> In-Reply-To: <86bfaabc-43e3-bcfb-faf9-74a0d79ab2ec@huawei.com> From: Mathieu Poirier Date: Thu, 1 Sep 2022 10:53:29 -0600 Message-ID: Subject: Re: [PATCH v12 0/5] Add driver support for HiSilicon PCIe Tune and Trace device To: Yicong Yang Cc: alexander.shishkin@linux.intel.com, peterz@infradead.org, corbet@lwn.net, gregkh@linuxfoundation.org, yangyicong@hisilicon.com, helgaas@kernel.org, lorenzo.pieralisi@arm.com, suzuki.poulose@arm.com, joro@8bytes.org, shameerali.kolothum.thodi@huawei.com, mingo@redhat.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, iommu@lists.linux-foundation.org, iommu@lists.linux.dev, linux-doc@vger.kernel.org, prime.zeng@huawei.com, liuqi115@huawei.com, zhangshaokun@hisilicon.com, linuxarm@huawei.com, bagasdotme@gmail.com, john.garry@huawei.com, jonathan.cameron@huawei.com, leo.yan@linaro.org, james.clark@arm.com, robin.murphy@arm.com, will@kernel.org, acme@kernel.org, mark.rutland@arm.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_095343_904763_7CD4499C X-CRM114-Status: GOOD ( 46.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 30 Aug 2022 at 04:59, Yicong Yang wrote: > > A gentle ping for this... > I will look at this set next week. > Thanks. > > On 2022/8/16 19:44, Yicong Yang wrote: > > From: Yicong Yang > > > > HiSilicon PCIe tune and trace device (PTT) is a PCIe Root Complex integrated > > Endpoint (RCiEP) device, providing the capability to dynamically monitor and > > tune the PCIe traffic (tune), and trace the TLP headers (trace). > > > > PTT tune is designed for monitoring and adjusting PCIe link parameters. We provide > > several parameters of the PCIe link. Through the driver, user can adjust the value > > of certain parameter to affect the PCIe link for the purpose of enhancing the > > performance in certian situation. > > > > PTT trace is designed for dumping the TLP headers to the memory, which can be > > used to analyze the transactions and usage condition of the PCIe Link. Users > > can choose filters to trace headers, by either requester ID, or those downstream > > of a set of Root Ports on the same core of the PTT device. It's also supported > > to trace the headers of certain type and of certain direction. > > > > The driver registers a PMU device for each PTT device. The trace can be used > > through `perf record` and the traced headers can be decoded by `perf report`. > > The tune can be used through the sysfs attributes of related PMU device. See > > the documentation for the detailed usage. > > > > This patchset adds an initial driver support for the PTT device. The userspace > > perf tool support will be sent in a separate patchset. > > > > Change since v11: > > - Drop WARN_ON() for irq_set_affinity() failure per Greg > > - Split out userspace perf support patches according to the comments > > Link: https://lore.kernel.org/lkml/20220721130116.43366-1-yangyicong@huawei.com/ > > > > Change since v10: > > - Use title case in the documentation > > - Add RB from Bagas, thanks. > > Link: https://lore.kernel.org/lkml/20220714092710.53486-1-yangyicong@hisilicon.com/ > > > > Change since v9: > > - Add sysfs ABI description documentation > > - Remove the controversial available_{root_port, requester}_filters sysfs file > > - Shorten 2 tune sysfs attributes name and add some comments > > - Move hisi_ptt_process_auxtrace_info() to Patch 6. > > - Add RB from Leo and Ack-by from Mathieu, thanks! > > Link: https://lore.kernel.org/lkml/20220606115555.41103-1-yangyicong@hisilicon.com/ > > > > Change since v8: > > - Cleanups and one minor fix from Jonathan and John, thanks > > Link: https://lore.kernel.org/lkml/20220516125223.32012-1-yangyicong@hisilicon.com/ > > > > Change since v7: > > - Configure the DMA in probe rather than in runtime. Also use devres to manage > > PMU device as we have no order problem now > > - Refactor the config validation function per John and Leo > > - Use a spinlock hisi_ptt::pmu_lock instead of mutex to serialize the perf process > > in pmu::start as it's in atomic context > > - Only commit the traced data when stop, per Leo and James > > - Drop the filter dynamically updating patch from this series to simply the review > > of the driver. That patch will be send separately. > > - add a cpumask sysfs attribute and handle the cpu hotplug events, follow the > > uncore PMU convention > > - Other cleanups and fixes, both in driver and perf tool > > Link: https://lore.kernel.org/lkml/20220407125841.3678-1-yangyicong@hisilicon.com/ > > > > Change since v6: > > - Fix W=1 errors reported by lkp test, thanks > > > > Change since v5: > > - Squash the PMU patch into PATCH 2 suggested by John > > - refine the commit message of PATCH 1 and some comments > > Link: https://lore.kernel.org/lkml/20220308084930.5142-1-yangyicong@hisilicon.com/ > > > > Change since v4: > > Address the comments from Jonathan, John and Ma Ca, thanks. > > - Use devm* also for allocating the DMA buffers > > - Remove the IRQ handler stub in Patch 2 > > - Make functions waiting for hardware state return boolean > > - Manual remove the PMU device as it should be removed first > > - Modifier the orders in probe and removal to make them matched well > > - Make available {directions,type,format} array const and non-global > > - Using the right filter list in filters show and well protect the > > list with mutex > > - Record the trace status with a boolean @started rather than enum > > - Optimize the process of finding the PTT devices of the perf-tool > > Link: https://lore.kernel.org/linux-pci/20220221084307.33712-1-yangyicong@hisilicon.com/ > > > > Change since v3: > > Address the comments from Jonathan and John, thanks. > > - drop members in the common struct which can be get on the fly > > - reduce buffer struct and organize the buffers with array instead of list > > - reduce the DMA reset wait time to avoid long time busy loop > > - split the available_filters sysfs attribute into two files, for root port > > and requester respectively. Update the documentation accordingly > > - make IOMMU mapping check earlier in probe to avoid race condition. Also > > make IOMMU quirk patch prior to driver in the series > > - Cleanups and typos fixes from John and Jonathan > > Link: https://lore.kernel.org/linux-pci/20220124131118.17887-1-yangyicong@hisilicon.com/ > > > > Change since v2: > > - address the comments from Mathieu, thanks. > > - rename the directory to ptt to match the function of the device > > - spinoff the declarations to a separate header > > - split the trace function to several patches > > - some other comments. > > - make default smmu domain type of PTT device to identity > > Drop the RMR as it's not recommended and use an iommu_def_domain_type > > quirk to passthrough the device DMA as suggested by Robin. > > Link: https://lore.kernel.org/linux-pci/20211116090625.53702-1-yangyicong@hisilicon.com/ > > > > Change since v1: > > - switch the user interface of trace to perf from debugfs > > - switch the user interface of tune to sysfs from debugfs > > - add perf tool support to start trace and decode the trace data > > - address the comments of documentation from Bjorn > > - add RMR[1] support of the device as trace works in RMR mode or > > direct DMA mode. RMR support is achieved by common APIs rather > > than the APIs implemented in [1]. > > Link: https://lore.kernel.org/lkml/1618654631-42454-1-git-send-email-yangyicong@hisilicon.com/ > > [1] https://lore.kernel.org/linux-acpi/20210805080724.480-1-shameerali.kolothum.thodi@huawei.com/ > > > > Yicong Yang (5): > > iommu/arm-smmu-v3: Make default domain type of HiSilicon PTT device to > > identity > > hwtracing: hisi_ptt: Add trace function support for HiSilicon PCIe > > Tune and Trace device > > hwtracing: hisi_ptt: Add tune function support for HiSilicon PCIe Tune > > and Trace device > > docs: trace: Add HiSilicon PTT device driver documentation > > MAINTAINERS: Add maintainer for HiSilicon PTT driver > > > > .../ABI/testing/sysfs-devices-hisi_ptt | 61 + > > Documentation/trace/hisi-ptt.rst | 298 +++++ > > Documentation/trace/index.rst | 1 + > > MAINTAINERS | 8 + > > drivers/Makefile | 1 + > > drivers/hwtracing/Kconfig | 2 + > > drivers/hwtracing/ptt/Kconfig | 12 + > > drivers/hwtracing/ptt/Makefile | 2 + > > drivers/hwtracing/ptt/hisi_ptt.c | 1047 +++++++++++++++++ > > drivers/hwtracing/ptt/hisi_ptt.h | 200 ++++ > > drivers/iommu/arm/arm-smmu-v3/arm-smmu-v3.c | 21 + > > 11 files changed, 1653 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-devices-hisi_ptt > > create mode 100644 Documentation/trace/hisi-ptt.rst > > create mode 100644 drivers/hwtracing/ptt/Kconfig > > create mode 100644 drivers/hwtracing/ptt/Makefile > > create mode 100644 drivers/hwtracing/ptt/hisi_ptt.c > > create mode 100644 drivers/hwtracing/ptt/hisi_ptt.h > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel