From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Mike Leach <mike.leach@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, coresight@lists.linaro.org,
Suzuki.Poulose@arm.com, leo.yan@linaro.org
Subject: Re: [PATCH v3 4/6] coresight: syscfg: Example CoreSight configuration loadable module
Date: Mon, 29 Nov 2021 09:44:01 -0700 [thread overview]
Message-ID: <CANLsYkxon8QcFi5s9VS7swMNqc9Ps+yEDvWLukS3fXHG+=KQ4A@mail.gmail.com> (raw)
In-Reply-To: <CAJ9a7VitFhw6egRt7zNTMmjdFxm0vuMAui_nLX3rdQVaxxp8Bg@mail.gmail.com>
On Mon, 29 Nov 2021 at 05:24, Mike Leach <mike.leach@linaro.org> wrote:
>
> Hi Mathieu,
>
> On Fri, 26 Nov 2021 at 18:23, Mathieu Poirier
> <mathieu.poirier@linaro.org> wrote:
> >
> > On Wed, Nov 24, 2021 at 08:00:36PM +0000, Mike Leach wrote:
> > > An example of creating a loadable module to add CoreSight configurations
> > > into a system.
> > >
> > > In the Kernel samples/coresight directory.
> > >
> > > Signed-off-by: Mike Leach <mike.leach@linaro.org>
> > > Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > > ---
> > > MAINTAINERS | 1 +
> > > samples/Kconfig | 9 +++
> > > samples/Makefile | 1 +
> > > samples/coresight/Makefile | 4 ++
> > > samples/coresight/coresight-cfg-sample.c | 73 ++++++++++++++++++++++++
> > > 5 files changed, 88 insertions(+)
> > > create mode 100644 samples/coresight/Makefile
> > > create mode 100644 samples/coresight/coresight-cfg-sample.c
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 7a2345ce8521..85242fdd3b8c 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1890,6 +1890,7 @@ F: Documentation/trace/coresight/*
> > > F: drivers/hwtracing/coresight/*
> > > F: include/dt-bindings/arm/coresight-cti-dt.h
> > > F: include/linux/coresight*
> > > +F: samples/coresight/*
> > > F: tools/perf/arch/arm/util/auxtrace.c
> > > F: tools/perf/arch/arm/util/cs-etm.c
> > > F: tools/perf/arch/arm/util/cs-etm.h
> > > diff --git a/samples/Kconfig b/samples/Kconfig
> > > index bec3528aa2de..fe8b56d576ce 100644
> > > --- a/samples/Kconfig
> > > +++ b/samples/Kconfig
> > > @@ -232,6 +232,15 @@ config SAMPLE_WATCH_QUEUE
> > > Build example userspace program to use the new mount_notify(),
> > > sb_notify() syscalls and the KEYCTL_WATCH_KEY keyctl() function.
> > >
> > > +config SAMPLE_CORESIGHT_SYSCFG
> > > + tristate "Build example loadable module for CoreSight config"
> > > + depends on CORESIGHT && m
> > > + help
> > > + Build an example loadable module that adds new CoreSight features
> > > + and configuration using the CoreSight system configuration API.
> > > + This demonstrates how a user may create their own CoreSight
> > > + configurations and easily load them into the system at runtime.
> > > +
> > > endif # SAMPLES
> > >
> > > config HAVE_SAMPLE_FTRACE_DIRECT
> > > diff --git a/samples/Makefile b/samples/Makefile
> > > index b7b98307c2b4..c148ada64beb 100644
> > > --- a/samples/Makefile
> > > +++ b/samples/Makefile
> > > @@ -32,3 +32,4 @@ obj-$(CONFIG_SAMPLE_INTEL_MEI) += mei/
> > > subdir-$(CONFIG_SAMPLE_WATCHDOG) += watchdog
> > > subdir-$(CONFIG_SAMPLE_WATCH_QUEUE) += watch_queue
> > > obj-$(CONFIG_DEBUG_KMEMLEAK_TEST) += kmemleak/
> > > +obj-$(CONFIG_SAMPLE_CORESIGHT_SYSCFG) += coresight/
> > > diff --git a/samples/coresight/Makefile b/samples/coresight/Makefile
> > > new file mode 100644
> > > index 000000000000..b3fce4af2347
> > > --- /dev/null
> > > +++ b/samples/coresight/Makefile
> > > @@ -0,0 +1,4 @@
> > > +# SPDX-License-Identifier: GPL-2.0-only
> > > +
> > > +obj-$(CONFIG_SAMPLE_CORESIGHT_SYSCFG) += coresight-cfg-sample.o
> > > +ccflags-y += -I$(srctree)/drivers/hwtracing/coresight
> > > diff --git a/samples/coresight/coresight-cfg-sample.c b/samples/coresight/coresight-cfg-sample.c
> > > new file mode 100644
> > > index 000000000000..25485c80b5e3
> > > --- /dev/null
> > > +++ b/samples/coresight/coresight-cfg-sample.c
> > > @@ -0,0 +1,73 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Copyright(C) 2020 Linaro Limited. All rights reserved.
> > > + * Author: Mike Leach <mike.leach@linaro.org>
> > > + */
> > > +
> > > +#include "coresight-config.h"
> > > +#include "coresight-syscfg.h"
> > > +
> > > +/* create an alternate autofdo configuration */
> > > +
> > > +/* we will provide 4 sets of preset parameter values */
> > > +#define AFDO2_NR_PRESETS 4
> > > +/* the total number of parameters in used features - strobing has 2 */
> > > +#define AFDO2_NR_PARAM_SUM 2
> > > +
> > > +static const char *afdo2_ref_names[] = {
> > > + "strobing",
> >
> > Checkpatch is complaining the above should be "static const char * const ..." I
> > can't remember if we talked about this before - did we?
> >
>
> The first Complex config set had the same warning for the built in
> autofdo config - which went upstream without issue.
> The code is safe - the strings are only ever read, the array is not
> altered - so perhaps that is why it was permitted - or maybe it was
> missed.
>
> > Do you want me to make the modification?
> >
>
> When I first so the issue in the original patch series - I made the
> suggested change and this had ripple effects of compile time warnings
> - throwing away const.
> If this is then corrected - the dynamic creation of configuration
> descriptors from configfs input files (in the follow up patch set)
> throws up errors
> The only way round this I could see would be to have two versions of
> the configuration descriptor - one that could be statically const
> assigned in the code, and one that could be dynamically build from
> file information.
>
> Overall I am not convinced that there is a good fix for this
> checkpatch warning - and am not convinced that it is valid for this
> usecase.
... and I am definitely not convinced it is worth spending the time to fix this.
I have applied this patchset.
Thanks,
Mathieu
>
> Regards
>
> Mike
>
> --
> Mike Leach
> Principal Engineer, ARM Ltd.
> Manchester Design Centre. UK
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-11-29 16:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-24 20:00 [PATCH v3 0/6] coresight: syscfg: dynamic load Mike Leach
2021-11-24 20:00 ` [PATCH v3 1/6] coresight: configuration: Update API to introduce load owner concept Mike Leach
2021-11-24 20:00 ` [PATCH v3 2/6] coresight: configuration: Update API to permit dynamic load/unload Mike Leach
2021-11-24 20:00 ` [PATCH v3 3/6] coresight: syscfg: Update load API for config loadable modules Mike Leach
2021-11-24 20:00 ` [PATCH v3 4/6] coresight: syscfg: Example CoreSight configuration loadable module Mike Leach
2021-11-26 18:23 ` Mathieu Poirier
2021-11-29 12:24 ` Mike Leach
2021-11-29 16:44 ` Mathieu Poirier [this message]
2021-11-24 20:00 ` [PATCH v3 5/6] coresight: configfs: Allow configfs to activate configuration Mike Leach
2021-11-24 20:00 ` [PATCH v3 6/6] Documentation: coresight: Update coresight configuration docs Mike Leach
2021-11-26 18:26 ` Mathieu Poirier
2021-11-29 11:54 ` Mike Leach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLsYkxon8QcFi5s9VS7swMNqc9Ps+yEDvWLukS3fXHG+=KQ4A@mail.gmail.com' \
--to=mathieu.poirier@linaro.org \
--cc=Suzuki.Poulose@arm.com \
--cc=coresight@lists.linaro.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=mike.leach@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).