From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0466FC31E5C for ; Mon, 17 Jun 2019 19:28:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CBC462085A for ; Mon, 17 Jun 2019 19:28:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IYnH17Vz"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Qwvmzvga" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CBC462085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mZQYmGPmiTQbIEVSA0A4q5+LDRtV9YTSOYKeXhMlcdk=; b=IYnH17VzkyfJZ5 hbpKlUyKVb2tmH2i7xZbtOfQ8bnEYwwHPB4lVmheK21/d1pJFh+daQjmZ5/AOIZ/8xkg6GCUqEQjp q6SMVu4zmFG1jWeiqZhISUwavLW+bAusX1fhIqBsq+V3SDGnnfuheFKZOtMNMC5h44E33Sn3CoJ9b Mnhh5Dx908hVmxSuc/XuvdDW54cjZKIURzk9EjWGZDbEPvVSqTTrtjZhCdGDoGS0ImNja/jmk2lXe 1YFEtHhTIkJDR9PjEUB68k78vwrVzwqknmor6yHotO1iSIoJqe7KwGK/impk5OG1WKTlDv1LL+UyF ruauP/kakJ9GzWymxivA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcxIr-0003gw-Te; Mon, 17 Jun 2019 19:28:29 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcxIo-0003gJ-Jz for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 19:28:27 +0000 Received: by mail-io1-xd42.google.com with SMTP id e5so23940406iok.4 for ; Mon, 17 Jun 2019 12:28:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Z5rXgwG9yWcPN0fLE/vTF18T48XWO9yQmjH86/WUrac=; b=Qwvmzvga8buedBgHNunzYLLvybd7UB3ejxu5iIY+kC5E2T6WJQWUIFI3ehreI+zUJ1 ZWnBU+RGqNxx/YmjBygCx0KYMmgQrCTTfhDN+9FVGARDFz72R1cYjOGGFHQvrXj2Emu7 ny18uO/Z5K2+d88h1I4fczERW5BhF017uAFbNcAmuFHr8qOGAshskd85Fh5YhFKW2MNv Xw4yMMIdS4v8XfWxiJTJ3aBo45rqKCgX7ECFtHvwRlF895nDBCkTPtmKTdcXP99Em5TN 58RKUOcmsJW9i+G1fJzXDw+EOEc21vevCn+IGTl0CnCs7/gQikWnclA5NBhyeasQmzAT 3Qzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Z5rXgwG9yWcPN0fLE/vTF18T48XWO9yQmjH86/WUrac=; b=imw8oWxnSxMXNwZqn/IuOYja0H31F2tCBBgVmJpuOhWJpWOAJKyTXbFnCTPt6170wN YiahYQ7Go9FcQ6Orp6HDJ7MmPmCxHRGLod8UshX7tTIQ6yiBaORjwML1JB+Q+wGW4Ls/ J5KHJyGMCJxNfPrG3XTtymwOJaRZFZ6qpJVW26trVs6iznbhAc5tJ7mR/fPy/H/LFO4C ecvxZp0kzg/SSM0a28qbytP4CcquHTLPuPZmy4AREJG/cDw+ZZkbxjyklwXuTvjd1fJt eppZDk6h99QWovR1AEdBZrAwqtITzbfv/JM2bRCeKcypV4OLOOcvBmbhKJqJm/1/ls6Q alqQ== X-Gm-Message-State: APjAAAUK7aopXOrwHhJJ6BkMGhuTfV8+HCZ8UZNtlhJ5ZRn5rMGsOXOx 7EvWbu3XKJ7O6XOMp+/1ixNfdkjSZ0yk/a8rYzl2ekJO+l0= X-Google-Smtp-Source: APXvYqwJpEoINVaSgYz/MH4+YMNa6KQ5jX4ZVfZx9HlfeGQjPFf0uh0xUNGxa+acoGWC1bnWp3OdhVv/14tgmc40PpM= X-Received: by 2002:a5e:c241:: with SMTP id w1mr2348003iop.58.1560799706019; Mon, 17 Jun 2019 12:28:26 -0700 (PDT) MIME-Version: 1.0 References: <1560420386-4239-1-git-send-email-suzuki.poulose@arm.com> In-Reply-To: <1560420386-4239-1-git-send-email-suzuki.poulose@arm.com> From: Mathieu Poirier Date: Mon, 17 Jun 2019 13:28:15 -0600 Message-ID: Subject: Re: [PATCH 1/2] coresight: etm3x: Smatch: Fix potential NULL pointer dereference To: Suzuki K Poulose X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_122826_661372_D7B79F86 X-CRM114-Status: GOOD ( 15.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Coresight ML , Dan Carpenter , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 13 Jun 2019 at 04:06, Suzuki K Poulose wrote: > > Based on the following report from Smatch tool, make sure we have a > valid drvdata before we dereference it to find the real dev. > > The patch 21d26b905c05: "coresight: etm: Clean up device specific > data" from May 22, 2019, leads to the following Smatch complaint: > > ./drivers/hwtracing/coresight/coresight-etm3x.c:460 etm_get_trace_id() > warn: variable dereferenced before check 'drvdata' (see line 458) > > ./drivers/hwtracing/coresight/coresight-etm3x.c > 457 int trace_id = -1; > 458 struct device *etm_dev = drvdata->csdev->dev.parent; > ^^^^^^^^^ > New dereference > > 459 > 460 if (!drvdata) > ^^^^^^^^ > Checked too late. Delete the check? > > 461 goto out; > 462 > > Cc: Mathieu Poirier > Cc: Dan Carpenter > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-etm3x.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm3x.c b/drivers/hwtracing/coresight/coresight-etm3x.c > index bed7291..225c298 100644 > --- a/drivers/hwtracing/coresight/coresight-etm3x.c > +++ b/drivers/hwtracing/coresight/coresight-etm3x.c > @@ -455,11 +455,12 @@ int etm_get_trace_id(struct etm_drvdata *drvdata) > { > unsigned long flags; > int trace_id = -1; > - struct device *etm_dev = drvdata->csdev->dev.parent; > + struct device *etm_dev; > > if (!drvdata) > goto out; > > + etm_dev = drvdata->csdev->dev.parent; > if (!local_read(&drvdata->mode)) > return drvdata->traceid; > I have applied both patches in this set. Thanks, Mathieu > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel