From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0670AC31E5B for ; Mon, 17 Jun 2019 19:40:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE02B208C0 for ; Mon, 17 Jun 2019 19:40:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RlO9hxAk"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="aLeZkiIR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE02B208C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q/zE0Uey8j8T/eFnBySp+R0Lv47xqY5UGXGFlOtFdpE=; b=RlO9hxAkn8XLsZ 3HFH3XYmdwpIC8ABW3YtzHD3jgJ0i4VucPvG6Xujcg0R3wpO6Nf6JmnGAusdUDvyFEmRJoVQzWRmd qSeoDA1Pc/T4TVKBiwdU7fYLydlY10mfU1U12L7N4wUDLwRWRVEaroFqdQvqBZROwXElG5SBfMgJ+ HPAmoGmmGZU1Sev2c7KqQU8dnLlrh8XkpwTktPivsMaDXJ0zxLbjeDnqte4BevnhdDCvPaDtObAZE GiO04Dqb7iEPrKXIEPD94VFEkbP51o+zs/2YFONN0yr4N8sFKT1ju9pGr5VvbZBJFSesD9m7vFMMg zUOtOjUTDc0Ql4hwA6Jw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hcxUT-0003At-7w; Mon, 17 Jun 2019 19:40:29 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hcxUP-0003AF-QH for linux-arm-kernel@lists.infradead.org; Mon, 17 Jun 2019 19:40:27 +0000 Received: by mail-io1-xd43.google.com with SMTP id h6so24018609ioh.3 for ; Mon, 17 Jun 2019 12:40:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=j6WuASPE2mni0guIUkkRtD/52gMjLqr2ZEpRsUR4sK0=; b=aLeZkiIRZAsbC3vwrVPw8k/YEEnk6TMdBILNooAcrZfEK6urgpMJ5u9Eq8s1bOnb/Y k6nDVLTOgLip52Zhmj14Q+anQTe4dnae727Mc/ilZsSsARO8WHN9SELDR519JPcAfcnO LX/mOrjBmPgT3y7N+9sz63DOb1W8CgG5s5ffctFFrs53ndUU641/vruIyiJb7CK5Kn/j HeolrvIBNoB0KVQSbFUnXQtVgK17QzwZ70tcmuUBHWfZfQgTuUHSuGDD/slrq2V+Rynf PGM/Tw+k9FHiub/A1UweRNgdGJpYR7Njjw6grqwgS53CJTzXG4qcdQnNm0KeXDLN1yaL jUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=j6WuASPE2mni0guIUkkRtD/52gMjLqr2ZEpRsUR4sK0=; b=RxnVUtQh6F5WiOsJzsyL6w8jckTBfYxn44BPUmHQa4j6GChvtL5pYsILvgHEsEgIvV UzEwVxlFZqgSo67QkwPRkbnZQTP8hJi3kpC5Zc4KppwCGoNfy5TznyZv2CGp69Y5aKdV o83r7edIwNmT4cfZ72+5fUzZ40JxGM7BwVDPfMchdbhF6psOLUnvCooPEpQKjht4thSe ePhpq+quVHImvrcgX7tBwXZ47N/mzoSX289d7bTzIYoyuRAvTRuWeACCI+3CjP0Hn2Yz OQKBIh7WfRUc4YWJR/3J0F0SpQ0P+J6vxETY/msXh3zXSs/08OLpbIjRgZhA0Cw7Pxaf iECg== X-Gm-Message-State: APjAAAXYZQu/dLyIsIvz5g41cOwOtHPdThapQZdxp8tT5YCrwx/r+Soe ukI/NtuOJMKnlvyg7iTEPjP3wN7r3yALXf+lc1+eMQ== X-Google-Smtp-Source: APXvYqxr938YdTE2N+B9Fe98i+hpyur/6wP1TpcTp3sfwG4ulGslieAud5K48nc0OVEFq6C9kYcV0D+/j2dEXFIDLSA= X-Received: by 2002:a6b:7d49:: with SMTP id d9mr12123502ioq.50.1560800424948; Mon, 17 Jun 2019 12:40:24 -0700 (PDT) MIME-Version: 1.0 References: <20190617125908.1674177-1-arnd@arndb.de> In-Reply-To: <20190617125908.1674177-1-arnd@arndb.de> From: Mathieu Poirier Date: Mon, 17 Jun 2019 13:40:14 -0600 Message-ID: Subject: Re: [PATCH] coresight: platform: add OF/APCI dependency To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190617_124025_848435_E250E892 X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Shishkin , Linux Kernel Mailing List , linux-arm-kernel , Suzuki K Poulose Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 Jun 2019 at 06:59, Arnd Bergmann wrote: > > When neither CONFIG_OF nor CONFIG_ACPI are set, we get a harmless > build warning: > > drivers/hwtracing/coresight/coresight-platform.c:26:12: error: unused function 'coresight_alloc_conns' > [-Werror,-Wunused-function] > static int coresight_alloc_conns(struct device *dev, > ^ > drivers/hwtracing/coresight/coresight-platform.c:46:1: error: unused function 'coresight_find_device_by_fwnode' > [-Werror,-Wunused-function] > coresight_find_device_by_fwnode(struct fwnode_handle *fwnode) > > As the code is useless in that configuration anyway, just add > a Kconfig dependency that only allows building when at least > one of the two is set. > > This should not hinder compile-testing, as CONFIG_OF can be > enabled on any architecture. > > Fixes: ac0e232c12f0 ("coresight: platform: Use fwnode handle for device search") > Signed-off-by: Arnd Bergmann > --- > drivers/hwtracing/coresight/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hwtracing/coresight/Kconfig b/drivers/hwtracing/coresight/Kconfig > index 5487d4a1abc2..14638db4991d 100644 > --- a/drivers/hwtracing/coresight/Kconfig > +++ b/drivers/hwtracing/coresight/Kconfig > @@ -4,6 +4,7 @@ > # > menuconfig CORESIGHT > bool "CoreSight Tracing Support" > + depends on OF || ACPI I have applied this - thanks, Mathieu > select ARM_AMBA > select PERF_EVENTS > help > -- > 2.20.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel