From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Coresight ML <coresight@lists.linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v4 00/30] coresight: Support for ACPI bindings
Date: Tue, 28 May 2019 11:36:07 -0600 [thread overview]
Message-ID: <CANLsYkzK7N9Bt6E6f187LaDydeC5afMp=LjMuvhFYKbij_SyjA@mail.gmail.com> (raw)
In-Reply-To: <CANLsYkzRXXB1EFpWHn6JN_6pfOm-1TvVgiJY2MKExhifiBakBQ@mail.gmail.com>
On Tue, 28 May 2019 at 11:32, Mathieu Poirier
<mathieu.poirier@linaro.org> wrote:
>
> On Wed, 22 May 2019 at 04:35, Suzuki K Poulose <suzuki.poulose@arm.com> wrote:
> >
> > This series adds the support for CoreSight devices on ACPI based
> > platforms. The device connections are encoded as _DSD graph property[0],
> > with CoreSight specific extensions to indicate the direction of data
> > flow as described in [1]. Components attached to CPUs are listed
> > as child devices of the corresponding CPU, removing explicit links
> > to the CPU like we do in the DT.
> >
> > The majority of the series cleans up the driver and prepares the subsystem
> > for platform agnostic firwmare probing, naming scheme, searching etc.
> >
> > We introduce platform independent helpers to parse the platform supplied
> > information. Thus we rename the platform handling code from:
> > of_coresight.c => coresight-platform.c
> >
> > The CoreSight driver creates shadow devices that appear on the Coresight
> > bus, in addition to the real devices (e.g, AMBA bus devices). The name
> > of these devices match the real device. This makes the device name
> > a bit cryptic for ACPI platform. So this series also introduces a generic
> > platform agnostic device naming scheme for the shadow Coresight devices.
> > Towards this we also make changes to the way we lookup devices to resolve
> > the connections, as we can't use the names to identify the devices. So,
> > we use the "fwnode_handle" of the real device for the device lookups.
> > Towards that we clean up the drivers to keep track of the "CoreSight"
> > device rather than the "real" device. However, all real operations,
> > like DMA allocation, Power management etc. must be performed on
> > the real device which is the parent of the shadow device.
> >
> > Finally we add the support for parsing the ACPI platform data. The power
> > management support is missing in the ACPI (and this is not specific to
> > CoreSight). The firmware must ensure that the respective power domains
> > are turned on.
> >
> > Applies on v5.2-rc1
> >
> > Tested on a Juno-r0 board with ACPI bindings patch (Patch 31/30) added on
> > top of [2]. You would need to make sure that the debug power domain is
> > turned on before the Linux kernel boots. (e.g, connect the DS-5 to the
> > Juno board while at UEFI). arm32 code is only compile tested.
> >
> > [0] ACPI Device Graphs using _DSD (Not available online yet, approved but
> > awaiting publish and eventually should be linked at).
> > https://uefi.org/sites/default/files/resources/_DSD-implementation-guide-toplevel-1_1.htm
> > [1] https://developer.arm.com/docs/den0067/latest/acpi-for-coresighttm-10-platform-design-document
> > [2] https://github.com/tianocore/edk2-platforms.git
> >
> > Changes since v3:
> > - Add tags from Mathieu
> >
> > Changes since v2:
> > - Fix the symlink name for ETM devices under cs_etm PMU (Patch by Mathieu)
> > - Drop patches merged already in the tree.
> > - Add the tags from Mathieu
> > - More documentation with examples of ACPI graph in ACPI bindings support.
> > - Fix ETM4 error return path (Mathieu)
> > - Drop the patches exposing device links via sysfs, to be posted as separate
> > series.
> > - Drop the generic helper for device search by fwnode for a better cleanup
> > later.
> > - Split the ACPI bindings support patch for AMBA and platform devices.
> > - Return integer error for <platform>_get_platform_data() helpers.
> > - Fix comment about the return code for acpi_get_coresight_cpu().
> > - Ensure we don't have devices part of multiple graphs (Mathieu).
> >
> > Changes since v1:
> >
> > [ http://lists.infradead.org/pipermail/linux-arm-kernel/2019-March/639963.html ]
> >
> > - Dropped the replicator driver merge changes as they were pulled already.
> > - Cleanups for Power management in the drivers.
> > - Reuse platform description for connection information. Also introduce
> > routines to clean up the platform description to make sure we drop
> > the references (fwnode_handle).
> > - Add RFC patches for exposing the device-links via sysfs.
> > - Drop tracking the device in favour of coresight_device.
> > - Name etb10 as "etb"
> > - Fix other comments in v1.
> > - Use a generic helper for searching with fwnode_handle rather than adding
> > one for CoreSight.
> >
> >
> > Mathieu Poirier (1):
> > coresight: Use coresight device names for sinks in PMU attribute
> >
> > Suzuki K Poulose (29):
> > coresight: funnel: Clean up device book keeping
> > coresight: replicator: Cleanup device tracking
> > coresight: tmc: Clean up device specific data
> > coresight: catu: Cleanup device specific data
> > coresight: tpiu: Clean up device specific data
> > coresight: stm: Cleanup device specific data
> > coresight: etm: Clean up device specific data
> > coresight: etb10: Clean up device specific data
> > coresight: Rename of_coresight to coresight-platform
> > coresight: etm3x: Rearrange cp14 access detection
> > coresight: stm: Rearrange probing the stimulus area
> > coresight: tmc-etr: Rearrange probing default buffer size
> > coresight: platform: Make memory allocation helper generic
> > coresight: Make sure device uses DT for obsolete compatible check
> > coresight: Introduce generic platform data helper
> > coresight: Make device to CPU mapping generic
> > coresight: Remove cpu field from platform data
> > coresight: Remove name from platform description
> > coresight: Cleanup coresight_remove_conns
> > coresight: Reuse platform data structure for connection tracking
> > coresight: Rearrange platform data probing
> > coresight: Add support for releasing platform specific data
> > coresight: platform: Use fwnode handle for device search
> > coresight: Use fwnode handle instead of device names
> > coresight: Use platform agnostic names
> > coresight: stm: ACPI support for parsing stimulus base
> > coresight: Support for ACPI bindings
> > coresight: acpi: Support for AMBA components
> > coresight: acpi: Support for platform devices
> >
> > drivers/acpi/acpi_amba.c | 9 +
> > drivers/hwtracing/coresight/Makefile | 3 +-
> > drivers/hwtracing/coresight/coresight-catu.c | 40 +-
> > drivers/hwtracing/coresight/coresight-catu.h | 1 -
> > drivers/hwtracing/coresight/coresight-cpu-debug.c | 3 +-
> > drivers/hwtracing/coresight/coresight-etb10.c | 51 +-
> > drivers/hwtracing/coresight/coresight-etm-perf.c | 8 +-
> > drivers/hwtracing/coresight/coresight-etm.h | 6 +-
> > .../hwtracing/coresight/coresight-etm3x-sysfs.c | 12 +-
> > drivers/hwtracing/coresight/coresight-etm3x.c | 45 +-
> > drivers/hwtracing/coresight/coresight-etm4x.c | 37 +-
> > drivers/hwtracing/coresight/coresight-etm4x.h | 2 -
> > drivers/hwtracing/coresight/coresight-funnel.c | 35 +-
> > drivers/hwtracing/coresight/coresight-platform.c | 810 +++++++++++++++++++++
> > drivers/hwtracing/coresight/coresight-priv.h | 4 +
> > drivers/hwtracing/coresight/coresight-replicator.c | 42 +-
> > drivers/hwtracing/coresight/coresight-stm.c | 118 ++-
> > drivers/hwtracing/coresight/coresight-tmc-etf.c | 9 +-
> > drivers/hwtracing/coresight/coresight-tmc-etr.c | 44 +-
> > drivers/hwtracing/coresight/coresight-tmc.c | 96 +--
> > drivers/hwtracing/coresight/coresight-tmc.h | 2 -
> > drivers/hwtracing/coresight/coresight-tpiu.c | 24 +-
> > drivers/hwtracing/coresight/coresight.c | 164 ++++-
> > drivers/hwtracing/coresight/of_coresight.c | 297 --------
> > include/linux/coresight.h | 61 +-
> > 25 files changed, 1332 insertions(+), 591 deletions(-)
> > create mode 100644 drivers/hwtracing/coresight/coresight-platform.c
> > delete mode 100644 drivers/hwtracing/coresight/of_coresight.c
>
> I have applied this set.
As Leo pointed out it would be interesting to update the documentation
in "Documentation/trace/coresight.txt".
>
> Thanks,
> Mathieu
>
> >
> > ACPI bindings for Juno-r0 (applies on [2] above)
> >
> > Suzuki K Poulose (1):
> > edk2-platform: juno: Update ACPI CoreSight Bindings
> >
> > Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 241 +++++++++++++++++++++++++++++++
> > 1 file changed, 241 insertions(+)
> >
> > --
> > 2.7.4
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-05-28 17:36 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-22 10:34 [PATCH v4 00/30] coresight: Support for ACPI bindings Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 01/30] coresight: funnel: Clean up device book keeping Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 02/30] coresight: replicator: Cleanup device tracking Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 03/30] coresight: tmc: Clean up device specific data Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 04/30] coresight: catu: Cleanup " Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 05/30] coresight: tpiu: Clean up " Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 06/30] coresight: stm: Cleanup " Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 07/30] coresight: etm: Clean up " Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 08/30] coresight: etb10: " Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 09/30] coresight: Use coresight device names for sinks in PMU attribute Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 10/30] coresight: Rename of_coresight to coresight-platform Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 11/30] coresight: etm3x: Rearrange cp14 access detection Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 12/30] coresight: stm: Rearrange probing the stimulus area Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 13/30] coresight: tmc-etr: Rearrange probing default buffer size Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 14/30] coresight: platform: Make memory allocation helper generic Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 15/30] coresight: Make sure device uses DT for obsolete compatible check Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 16/30] coresight: Introduce generic platform data helper Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 17/30] coresight: Make device to CPU mapping generic Suzuki K Poulose
2019-06-03 10:07 ` Mike Leach
2019-06-06 12:56 ` Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 18/30] coresight: Remove cpu field from platform data Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 19/30] coresight: Remove name from platform description Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 20/30] coresight: Cleanup coresight_remove_conns Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 21/30] coresight: Reuse platform data structure for connection tracking Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 22/30] coresight: Rearrange platform data probing Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 23/30] coresight: Add support for releasing platform specific data Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 24/30] coresight: platform: Use fwnode handle for device search Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 25/30] coresight: Use fwnode handle instead of device names Suzuki K Poulose
2019-05-22 10:34 ` [PATCH v4 26/30] coresight: Use platform agnostic names Suzuki K Poulose
2019-05-29 9:32 ` Mike Leach
2019-06-03 10:12 ` Suzuki K Poulose
2019-05-22 10:35 ` [PATCH v4 27/30] coresight: stm: ACPI support for parsing stimulus base Suzuki K Poulose
2019-05-22 10:35 ` [PATCH v4 28/30] coresight: Support for ACPI bindings Suzuki K Poulose
2019-05-22 10:35 ` [PATCH v4 29/30] coresight: acpi: Support for AMBA components Suzuki K Poulose
2019-05-22 10:35 ` [PATCH v4 30/30] coresight: acpi: Support for platform devices Suzuki K Poulose
2019-05-22 10:35 ` [TEST PATCH 31/30][EDK2] edk2-platform: juno: Update ACPI CoreSight Bindings Suzuki K Poulose
2019-05-23 13:37 ` [PATCH v4 00/30] coresight: Support for ACPI bindings Suzuki K Poulose
2019-05-23 14:32 ` Leo Yan
2019-05-23 15:31 ` Suzuki K Poulose
2019-05-24 1:38 ` Leo Yan
2019-05-24 13:19 ` Mike Leach
2019-05-28 5:19 ` Leo Yan
2019-05-28 8:08 ` Leo Yan
2019-05-28 14:51 ` Mathieu Poirier
2019-05-29 6:34 ` Leo Yan
2019-05-28 17:32 ` Mathieu Poirier
2019-05-28 17:36 ` Mathieu Poirier [this message]
2019-05-28 17:40 ` Suzuki K Poulose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANLsYkzK7N9Bt6E6f187LaDydeC5afMp=LjMuvhFYKbij_SyjA@mail.gmail.com' \
--to=mathieu.poirier@linaro.org \
--cc=coresight@lists.linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suzuki.poulose@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).