From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09ED6ECAAD1 for ; Thu, 1 Sep 2022 16:53:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z2dGBx5JzuR71rBBAEisSqXjwT6R0Ks+/bJ0bMU1V8U=; b=U9dON1mjiKl7oz OTxBNq+CMEIN0IZf5SUq73PVKIQEQUpz/yJ15ROrG7sB/lMnJG9DWRIEoj76Kyu1pWwqzGYKGe2KL 7sPMSwWyPfpzdmvgMX1fGwUalPzZlgUEsntxi2gokL86g5fFLy0Y6MbnCgwjYKpZ/rUy4Blv+nFuE K0x3LTPiwJdS8LTuIYDZZ/mA8IuexOJfFhNQ8mi65KAlL3HDF7q57jl9apmIy29Sk7SIoakJ2Znjy BTIDCcfyl8GumPAQ7N939KJRisugMLXe+t9qrIGT+5rJM2eupFNS7ZwCI0U9RbMKfUANgS4SaGmiP L/hJ2YaZ5RYvXVhrbiSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnQZ-00DQhy-A4; Thu, 01 Sep 2022 16:52:27 +0000 Received: from mail-ej1-x629.google.com ([2a00:1450:4864:20::629]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oTnQV-00DQgA-G2 for linux-arm-kernel@lists.infradead.org; Thu, 01 Sep 2022 16:52:25 +0000 Received: by mail-ej1-x629.google.com with SMTP id gb36so15093163ejc.10 for ; Thu, 01 Sep 2022 09:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=8gpXKd/rcgdoy4YCxJm6j2dyIOOgr77cRPkJmoI6lKk=; b=z4NRuNJ+v1eoMoPIr5/iSOQDh/P+oZt6qu1ks9yWm6E3+hBVQqx5UHkIBVu6wNKuek 6fLQR7JWEhw0kIkMKd/PMB41NW875rLDJUMs2XD3vkxPEHxFI+5OzY9Ppkfma4UfJbH6 oUA1kG9c0AtV4cBS10sumKQJyB/2MQpbC0kHCh8ulo34jzIXKJ2GBhR5NbW4ZqkThChp pimSpi2vdasOPf7PSkhSuhR7RFNbdWFRSvM8m3/10v8cfxtWkFL3Mk9DHk39GVUHCkhH 3wrE+PEC6Gwpj/4DwZz6DGskxwHH2o39PVfejubJyJJBZnqDQd1VjaZV0d6/uM9K+mki xcfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=8gpXKd/rcgdoy4YCxJm6j2dyIOOgr77cRPkJmoI6lKk=; b=NGh32HUd3/cXpE3t0OlyITDrkLhWS6p3rqrmTLg+ElJ/5onNqsJDS7ISPL+fJr8iNg 5kEPW7oPxb1Jq2AaXs9OXEkm5P2rEFLyFZcghy4TLkpPO37UmxPQwCQbCdYClUMCCW8G As6mhiyMduGXEnKyTbeGAPUaFUII3+Sg/ncNjy37YnQlLbbka0CP0JS3wNuI42i7XXMF kbrnI0iOdtZxRtfyDxcvAxO9c4kRSuknzUnCrQx0v/5inuGX79EQJko/BkwLUYgwJ8Yb BZJp0DVgXp3J67XTgOr02Z04d5yGHR9AtnsQLxbHVWno3riUIOHq92FNOnWSiUq+znjk FKFA== X-Gm-Message-State: ACgBeo3B4HXRlAm4BDnjUEJSqdBLlSPfdKcM2BMAFCHEoVO7R+AVSmrd nHYGZsOHE8MQOadnIHf9TDOTCbtx1B+66L0Fd8BTIA== X-Google-Smtp-Source: AA6agR7BaAKxuDmGMYFoHkUOkW7cfwd7OH3CSzZWQSt0QnzsL8LHIoezQdLYgtxLWazJMZxRf8869xBolCRGGdZifj8= X-Received: by 2002:a17:907:760b:b0:73d:b5bc:feb6 with SMTP id jx11-20020a170907760b00b0073db5bcfeb6mr24486780ejc.407.1662051141088; Thu, 01 Sep 2022 09:52:21 -0700 (PDT) MIME-Version: 1.0 References: <20220818132231.28240-1-hejunhao3@huawei.com> In-Reply-To: From: Mathieu Poirier Date: Thu, 1 Sep 2022 10:52:08 -0600 Message-ID: Subject: Re: [PATCH v9 0/2] Add support for UltraSoc System Memory Buffer To: hejunhao Cc: suzuki.poulose@arm.com, mike.leach@linaro.org, leo.yan@linaro.org, coresight@lists.linaro.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxarm@huawei.com, rdunlap@infradead.org, liuqi115@huawei.com, f.fangjian@huawei.com, prime.zeng@hisilicon.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220901_095223_601657_86671F15 X-CRM114-Status: GOOD ( 21.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 1 Sept 2022 at 07:12, hejunhao wrote: > > Gentle ping. Any comment or suggestion is appreciated. > There are a few patchset that are both substantial and complex to review on the log. As such reviewing will take longer than usual. > thanks. > > On 2022/8/18 21:22, Junhao He wrote: > > Add support for UltraSoc System Memory Buffer. > > > > Change since v8: > > - Insert a blank line at the end of the config tag in Kconfig. > > - Fix the "llseek" initialization. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220816131634.38195-1-hejunhao3@huawei.com/ > > > > Change since v7: > > - Use the macros for register bit flags and numbers of resource. > > - Fix punctuation. > > - Update the Date tag and the KernelVersion tag in the document. > > - Link: https://lore.kernel.org/lkml/20220712091353.34540-1-hejunhao3@huawei.com/ > > > > Change since v6: > > - Modify the code style and driver description according to Suzuki's comment. > > - Modify configuration of "drvdata->reading", to void problems in open/read > > concurrency scenario. > > - Rename the macro of "SMB_FLOW_MASK". > > - Use the "handle->head" to determine the page number and offset. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220606130223.57354-1-liuqi115@huawei.com/ > > > > Change since v5: > > - Address the comments from Suzuki, add some comments in SMB document, and modify > > configuration of "drvdata->reading", to void problems in multi-core concurrency scenario > > - Link: https://lore.kernel.org/linux-arm-kernel/20220416083953.52610-1-liuqi115@huawei.com/ > > > > Change since v4: > > - Add a simple document of SMB driver according to Suzuki's comment. > > - Address the comments from Suzuki. > > - Link: https://lore.kernel.org/linux-arm-kernel/20220128061755.31909-1-liuqi115@huawei.com/ > > > > Change since v3: > > - Modify the file header according to community specifications. > > - Address the comments from Mathieu. > > - Link: https://lore.kernel.org/linux-arm-kernel/20211118110016.40398-1-liuqi115@huawei.com/ > > > > Change since v2: > > - Move ultrasoc driver to drivers/hwtracing/coresight. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-November/007310.html > > > > Change since v1: > > - Drop the document of UltraSoc according to Mathieu's comment. > > - Add comments to explain some private hardware settings. > > - Address the comments from Mathieu. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-August/006842.html > > > > Change since RFC: > > - Move driver to drivers/hwtracing/coresight/ultrasoc. > > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > > basic tracing function. > > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > > - Address the comments from Mathieu and Suzuki. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > > > Qi Liu (2): > > drivers/coresight: Add UltraSoc System Memory Buffer driver > > Documentation: Add document for UltraSoc SMB drivers > > > > .../sysfs-bus-coresight-devices-ultra_smb | 31 + > > .../trace/coresight/ultrasoc-smb.rst | 80 +++ > > drivers/hwtracing/coresight/Kconfig | 11 + > > drivers/hwtracing/coresight/Makefile | 1 + > > drivers/hwtracing/coresight/ultrasoc-smb.c | 636 ++++++++++++++++++ > > drivers/hwtracing/coresight/ultrasoc-smb.h | 115 ++++ > > 6 files changed, 874 insertions(+) > > create mode 100644 Documentation/ABI/testing/sysfs-bus-coresight-devices-ultra_smb > > create mode 100644 Documentation/trace/coresight/ultrasoc-smb.rst > > create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.c > > create mode 100644 drivers/hwtracing/coresight/ultrasoc-smb.h > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel