From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFBBC433E0 for ; Fri, 10 Jul 2020 03:16:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 688922072E for ; Fri, 10 Jul 2020 03:16:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QSZIaYYA"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iz5+7TZu" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 688922072E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=MDw0XwI1QSqhvVi/0Owld2Jg+lrtZRxUnS+a7rDwCs0=; b=QSZIaYYANLandZmZof0/qHAOD D0uKz6/cH/B0qAC/t39zL77HdY5kJnoDwoki+q2Xo/JaFL+8amN6ZBx4FO25tGCc0U0i1IC1bfXf9 AXXx+uRCiml8aOMgQ/xC680KjU9IWmXcXo8xLGmEL0btH7ga2vA+EbG0UP0ocNkBugEGDX31ahH8U y+c9R8orMAYizbO2s8OkdctsTkqB2I3WGCY4PrfRYFztqVkdlfOh8vU+PyGktb2k3n+Z9hrkOIM8h hCODYO7ESaCJwZiB//2OkDDwq9qFe6W7NGgz1+y9+uEKl2iZoWHnQRkUAfnfa8Ahq8QveneGhyTSt nJEwWPIVQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtjVG-0008T8-Js; Fri, 10 Jul 2020 03:15:10 +0000 Received: from mail-vs1-xe44.google.com ([2607:f8b0:4864:20::e44]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtjVC-0008Rz-Tp for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 03:15:08 +0000 Received: by mail-vs1-xe44.google.com with SMTP id k7so2247630vso.2 for ; Thu, 09 Jul 2020 20:15:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0xK96ZEj03BYxsiwTCEC7aLn5QyV2i1PW83BHZdlgiE=; b=iz5+7TZuV43ycSJaAM7QXsHXHZMrqwe1VHhvH7nzaLRNqyuSzRIKsTm9ZY6hcyT6xL rUeURvW6GTpfMb+6hgPG7XBznhNpcnfnoWcODmOEsJARCaoCb5xul+H0TsOjwz8m0Gpt 8etFgsVIuVEHJxU8FqnuyA13ZWtKyl5k05Cmg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0xK96ZEj03BYxsiwTCEC7aLn5QyV2i1PW83BHZdlgiE=; b=L2S5LFUwAZJjDt1VcZFWZZK8XgGXNErMj2f3yaGyVc2jslbcG/BVAynGldaVz2EWCm aNFJwEfGkIZQsjQ8vJc+0whBdn2Des9OQFlBLlvq8bqiAgY6lLZshJK6Zyso5/r8SS4M y/oWxpA1jkDcRD/XcUFJveQpBLtOhs66EDNW1GlgchBU3y23V0BJ4J3nKNFMMd9AIX3T 7FovmoOz1yc1y/CmXQ2ZAkz3y1xUk1/DXEPXdlC1iTUG226m94zckgnI7Dg+xoOaqRgx h5Lg1zBRQomuNH4jW+rh5g2KRDQFAktMkB6TrJ6NnTwY881DvdQQv6Oala3HkQ+JEPyZ UrvA== X-Gm-Message-State: AOAM5329r+fSJogveHjOtiNYhHMcPpnDYY5XRWJhIUCCfahd2TIpO6Yl /q4lElnPUQ1HR1zh4wrkrFBWSvNP0awkHuLtgRC+Dg== X-Google-Smtp-Source: ABdhPJwwWTRG9i6cMBcyGYThfNXEyr1KpiR5j0/N7lIP76+Rz5QR86zchLcWA1ir6x7GGNOpx8rJ1ZOQxoECbAD4Myo= X-Received: by 2002:a67:e0c3:: with SMTP id m3mr52687562vsl.1.1594350903351; Thu, 09 Jul 2020 20:15:03 -0700 (PDT) MIME-Version: 1.0 References: <1594348182-431-1-git-send-email-chunfeng.yun@mediatek.com> In-Reply-To: <1594348182-431-1-git-send-email-chunfeng.yun@mediatek.com> From: Nicolas Boichat Date: Fri, 10 Jul 2020 11:14:52 +0800 Message-ID: Subject: Re: [PATCH] usb: xhci-mtk: fix the failure of bandwidth allocation To: Chunfeng Yun X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200709_231506_979454_1985784F X-CRM114-Status: GOOD ( 16.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mathias Nyman , Greg Kroah-Hartman , linux-usb@vger.kernel.org, lkml , stable , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , Ikjoon Jang , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 10:30 AM Chunfeng Yun wrote: > > The wMaxPacketSize field of endpoint descriptor may be zero > as default value in alternate interface, and they are not > actually selected when start stream, so skip them when try to > allocate bandwidth. > > Cc: stable > Signed-off-by: Chunfeng Yun Add this? Fixes: 0cbd4b34cda9dfd ("xhci: mediatek: support MTK xHCI host controller") > --- > drivers/usb/host/xhci-mtk-sch.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/usb/host/xhci-mtk-sch.c b/drivers/usb/host/xhci-mtk-sch.c > index fea5555..45c54d56 100644 > --- a/drivers/usb/host/xhci-mtk-sch.c > +++ b/drivers/usb/host/xhci-mtk-sch.c > @@ -557,6 +557,10 @@ static bool need_bw_sch(struct usb_host_endpoint *ep, > if (is_fs_or_ls(speed) && !has_tt) > return false; > > + /* skip endpoint with zero maxpkt */ > + if (usb_endpoint_maxp(&ep->desc) == 0) > + return false; > + > return true; > } > > -- > 1.9.1 > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel