From: Nicolas Boichat <drinkcat@chromium.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
kernel test robot <lkp@intel.com>,
"open list:REMOTE PROCESSOR \(REMOTEPROC\) SUBSYSTEM"
<linux-remoteproc@vger.kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Guenter Roeck <groeck@chromium.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Pi-Hsun Shih <pihsun@chromium.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off
Date: Mon, 16 Nov 2020 16:42:58 +0800 [thread overview]
Message-ID: <CANMq1KA_4M3vLzA6aK++_0_StDD1f7O=Q9AsofeQzHWzFmVV6Q@mail.gmail.com> (raw)
In-Reply-To: <20201116082537.3287009-2-tzungbi@google.com>
On Mon, Nov 16, 2020 at 4:26 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> Fixes the following sparse errors on sram power on and off:
>
> On drivers/remoteproc/mtk_scp.c:306:17:
> warning: incorrect type in argument 2 (different address spaces)
> expected void volatile [noderef] __iomem *addr
> got void *addr
>
> On drivers/remoteproc/mtk_scp.c:307:9:
> warning: incorrect type in argument 2 (different address spaces)
> expected void volatile [noderef] __iomem *addr
> got void *addr
>
> On drivers/remoteproc/mtk_scp.c:314:9:
> warning: incorrect type in argument 2 (different address spaces)
> expected void volatile [noderef] __iomem *addr
> got void *addr
>
> On drivers/remoteproc/mtk_scp.c:316:17:
> warning: incorrect type in argument 2 (different address spaces)
> expected void volatile [noderef] __iomem *addr
> got void *addr
Reviewed-by: Nicolas Boichat <drinkcat@chromium.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
> drivers/remoteproc/mtk_scp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index 577cbd5d421e..8ed89ea1eb78 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -298,7 +298,7 @@ static int mt8183_scp_before_load(struct mtk_scp *scp)
> return 0;
> }
>
> -static void mt8192_power_on_sram(void *addr)
> +static void mt8192_power_on_sram(void __iomem *addr)
> {
> int i;
>
> @@ -307,7 +307,7 @@ static void mt8192_power_on_sram(void *addr)
> writel(0, addr);
> }
>
> -static void mt8192_power_off_sram(void *addr)
> +static void mt8192_power_off_sram(void __iomem *addr)
> {
> int i;
>
> --
> 2.29.2.299.gdc1121823c-goog
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-16 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-16 8:25 [PATCH v2 0/2] remoteproc/mediatek: fix sparse errors Tzung-Bi Shih
2020-11-16 8:25 ` [PATCH v2 1/2] remoteproc/mediatek: fix sparse errors on sram power on and off Tzung-Bi Shih
2020-11-16 8:42 ` Nicolas Boichat [this message]
2020-11-16 20:25 ` Mathieu Poirier
2020-11-16 8:25 ` [PATCH v2 2/2] remoteproc/mediatek: fix sparse errors on dma_alloc and dma_free Tzung-Bi Shih
2020-11-16 8:45 ` Nicolas Boichat
2020-11-16 20:32 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANMq1KA_4M3vLzA6aK++_0_StDD1f7O=Q9AsofeQzHWzFmVV6Q@mail.gmail.com' \
--to=drinkcat@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=groeck@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=matthias.bgg@gmail.com \
--cc=ohad@wizery.com \
--cc=pihsun@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).