From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14148C43381 for ; Thu, 21 Mar 2019 06:02:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D787B218A5 for ; Thu, 21 Mar 2019 06:02:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="BZx4Rhe4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SxayQvWm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D787B218A5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lLCXLMt7MPIsEmtVlz2+LVUOW2Ao0hgDiQqXzHhLXRQ=; b=BZx4Rhe4Qezo5R 3W2NC9cJe3tEk5rNjfAyg8alXP6djFWfRlB4jyD2xiPtbm3M87iFT0M5K2tdeWI9z6+rRR+oDTg9y m/3kUiR+Gx2lkhxioT3Mq3UyBJeyBLwz6di4BDAzAlU116LndrS4smcyE/gcE/kgLwmWpT+wTQj/6 9eMPtXP3svwPTe/ENpr0razXq0wTgNDS1LiJ8IbjtsbuLmUeugM6i+HeziNINPlYIpTLGGDKx/oQ8 UGctYffDvNxhjw55w3AlvIwG7RExxUq95nAZ0a9PvkOmAr3uTfJ8ki30F6UCxeyBkUIZ6FOIQkrGo dHMKxkrfFY1fN2UlciGA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6qmh-0006SV-L4; Thu, 21 Mar 2019 06:02:35 +0000 Received: from mail-qt1-x841.google.com ([2607:f8b0:4864:20::841]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h6qmd-0006Qu-UH for linux-arm-kernel@lists.infradead.org; Thu, 21 Mar 2019 06:02:33 +0000 Received: by mail-qt1-x841.google.com with SMTP id v32so5400589qtc.10 for ; Wed, 20 Mar 2019 23:02:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3km5VzrkKtwK+4kIEccjRQTP8ZA+SvIT9ompJqty5D0=; b=SxayQvWmsF6bfxh81kvysGuQB1NY3I/Z+iJdzp++YBk8JD71Cp5sQNj5bHgj6CGbIW v3pM+eMfe8qP1dbB+U55u1f2kBhMGp0gsi0e7W4fuZqGqKC+fKIAQV/y79kExH2yI2Iw NslkybhulxCHOfab4tBoTQiEwE5tGLnBTjIKk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3km5VzrkKtwK+4kIEccjRQTP8ZA+SvIT9ompJqty5D0=; b=OV7cNL6tssZlYQy41ryCgmE8B6YfMiiTZLU9RVp5vnZyelkuiXDpg8rsfOXxrraeJw 3d3r1DI+hVDtE34+zKPC851qu0fhx6sKuXzmz+ZuapUlpL8nYX1eV/C/diekbzpt0i1w 7aGFcpkmej1rSJkK1piMch0bdC6bFZMbCc9zfe/ruthmSqVpnZgeLsvo8aRXRkkIoVaS tZmOKfaxK6S3sRlcu9i9J6GibWSJ1fbgLvN6GqEQTh7hVT7eu/D5vD+dbrNt9F4LHZXp dPOt/N6J6Vfdn/G5Lzust4ZKZNuywffBB1gJRcarJ6RvhwBD56zQBCu2ot6iNx4zkFBq lBpg== X-Gm-Message-State: APjAAAU9AzK/EmCB93ZLx8x7wYHHCMD9YfcwXiaetyjIJGhTtuo4Lles InQkPQEirmD3O03SneqziwYcg27V+1OIYa0adCBp/TmiZU0= X-Google-Smtp-Source: APXvYqzRTqHx0ai3tiaMbxmTEkhj3DJAIicQcXTzAZ38aVKtiEji5tNr/i07g9zXYxtC2tvnG67hFqJujMebVkaHydo= X-Received: by 2002:ac8:f3c:: with SMTP id e57mr1508707qtk.75.1553148149669; Wed, 20 Mar 2019 23:02:29 -0700 (PDT) MIME-Version: 1.0 References: <20190319080140.24055-1-weiyi.lu@mediatek.com> <20190319080140.24055-10-weiyi.lu@mediatek.com> In-Reply-To: <20190319080140.24055-10-weiyi.lu@mediatek.com> From: Nicolas Boichat Date: Thu, 21 Mar 2019 14:02:18 +0800 Message-ID: Subject: Re: [PATCH v5 09/14] soc: mediatek: Add basic_clk_name to scp_power_data To: Weiyi Lu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190320_230232_008603_8B50C80D X-CRM114-Status: GOOD ( 18.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , srv_heupstream , James Liao , lkml , Fan Chen , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Mar 19, 2019 at 4:02 PM Weiyi Lu wrote: > > Try to stop extending the clk_id or clk_names if there are > more and more new BASIC clocks. To get its own clocks by the > basic_clk_name of each power domain. > > Signed-off-by: Weiyi Lu > --- > drivers/soc/mediatek/mtk-scpsys.c | 27 +++++++++++++++++++-------- > 1 file changed, 19 insertions(+), 8 deletions(-) > > diff --git a/drivers/soc/mediatek/mtk-scpsys.c b/drivers/soc/mediatek/mtk-scpsys.c > index 6bf846cb1893..c6360de4e41e 100644 > --- a/drivers/soc/mediatek/mtk-scpsys.c > +++ b/drivers/soc/mediatek/mtk-scpsys.c > @@ -118,6 +118,8 @@ static const char * const clk_names[] = { > * @bus_prot_mask: The mask for single step bus protection. > * @clk_id: The basic clock needs to be enabled before enabling certain > * power domains. > + * @basic_clk_name: provide the same purpose with field "clk_id" > + * by declaring basic clock prefix name rather than clk_id. > * @caps: The flag for active wake-up action. > */ > struct scp_domain_data { > @@ -128,6 +130,7 @@ struct scp_domain_data { > u32 sram_pdn_ack_bits; > u32 bus_prot_mask; > enum clk_id clk_id[MAX_CLKS]; > + const char *basic_clk_name[MAX_CLKS]; Either call them basic_clk_id/basic_clk_name, or clk_id/clk_name. > u8 caps; > }; > > @@ -499,16 +502,24 @@ static struct scp *init_scp(struct platform_device *pdev, > > scpd->data = data; > > - for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > - struct clk *c = clk[data->clk_id[j]]; > + if (data->clk_id[0]) { Since it's either clk_id or basic_clk_name, I wonder if it'd be good to add a WARN_ON here, e.g. WARN_ON(data->basic_clk_name[0]); > + for (j = 0; j < MAX_CLKS && data->clk_id[j]; j++) { > + struct clk *c = clk[data->clk_id[j]]; > > - if (IS_ERR(c)) { > - dev_err(&pdev->dev, "%s: clk unavailable\n", > - data->name); > - return ERR_CAST(c); > - } > + if (IS_ERR(c)) { > + dev_err(&pdev->dev, > + "%s: clk unavailable\n", > + data->name); > + return ERR_CAST(c); > + } > > - scpd->clk[j] = c; > + scpd->clk[j] = c; > + } > + } else if (data->basic_clk_name[0]) { > + for (j = 0; j < MAX_CLKS && > + data->basic_clk_name[j]; j++) > + scpd->clk[j] = devm_clk_get(&pdev->dev, > + data->basic_clk_name[j]); > } > > genpd->name = data->name; > -- > 2.18.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel