From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E561C54FD0 for ; Mon, 27 Apr 2020 16:49:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6DDCB2078E for ; Mon, 27 Apr 2020 16:49:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IQ2Lm8Dx"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GRK7TdGO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DDCB2078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chKBIqadLwNC3uGrbiM0YuF+/KLxhiDbRFVGvx3bhU4=; b=IQ2Lm8Dxh7fT+o 9w//J95caFL6cOaPzj0EzzGGTgpubeW6OWNkF3cdqsKvOMm+pxEJ4rAF0sNd1WWXijL6mUGTGoE1r NMXecWsbFBJIo8FmKz1rscCLlIN6jIRSBsgO1E1vs2bxuSL9BSduIMJ/GrvoCpteIS80uXatvKSlO dPy1QiNB1o9RZZ9eJ6/xnmOULk/05CvS1nsoREAgpMddtqMaPkalqxnTb/fBH1LpqThSnNPA8orfN T/M9AIu6svd6A27pzboLS7LrZHBShKUqcPRf0Uhi7RaEYgJA5akL+oyu9ng0MKtHPgRhhRuog6rGB SAXG3ucnXhO5JI4l46yw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT6wL-0004y2-Nb; Mon, 27 Apr 2020 16:49:05 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT6wJ-0004ww-5U for linux-arm-kernel@lists.infradead.org; Mon, 27 Apr 2020 16:49:04 +0000 Received: by mail-lj1-x243.google.com with SMTP id j3so18292443ljg.8 for ; Mon, 27 Apr 2020 09:49:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DggTYojfEhSzNZzSt4p++E5JdlZHCZXJc0ROh9SzVlM=; b=GRK7TdGOAvGylag4wlIODdJrhvjeHh+CNCtIcuSjrjRzmjvA/4gHODiRDIqS3Ni+Ul xbrVAAQCFm0TrYX2gS2hmjsvmryyRHakKtro88oW5d8as36di5wAZi4QB0mVNrt3VYKC +mpM0biKQt1OtPZuP6KA+c31n0Icc3RDkS0F9D8RbdChUBCSxHizssgw5UMLXNS+Ozdv GhMLcbyKMjipz7hWcnUogsA5mxtEQ9HhUWk5UBJ4M7FpLiEWL82tfvSHuemxUMjA3T9k HQEcjwjSO8dW822QXi8v5ESAjxm5SgtUzR6RIF8ybNX7oWNscelNzVp5wj+yo9QkGQtH XR7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DggTYojfEhSzNZzSt4p++E5JdlZHCZXJc0ROh9SzVlM=; b=jyb0vFO7i+NIgdQ6uYrFiyU+IgOoSzCPMPRyZCnuIOFuPG7N7IPqlGf/ZhfMfmp1Tk z4gMri7G34oMtgBWDfbJm5EpfMlhMlsPeSn6xvWLxcwC/hPke1CLTXxDQM28fxuBeXvR CC8E7scRUlt2YRY5jCLaqiOdlwHmsw20RraLoa/BZAClIBW0tn4bCdOG/o2FkcE4hImU w1nLjyflBJQdvaTZvWCMqxEM4KBcXriVxY98K7v1API0VSKZtgQCjmC2nVxtVjElMdHf CfvhigYKbotOkREnI4Y5gdx3n3ED4PMHkUPM3rXpo26bXwW2AtbG0tz8CkNFcRTZdpD1 yXEg== X-Gm-Message-State: AGi0Pub5BOmyfkaMl755cW+ldEJZ4fzboALeiqE90jPIwf02RYpZRy9a IyA9/L38VMOM87DcUOv2bAwPjoJqTnySoKlYfZk= X-Google-Smtp-Source: APiQypKOZlel+ggVdbFyIPtgHGZpVrDz6ne1COTeLPmgW0WeAhG5IdM5qWoDEvfl/ilzflIttY+StL0Az1RFGIsqSuw= X-Received: by 2002:a2e:7613:: with SMTP id r19mr4909107ljc.29.1588006140845; Mon, 27 Apr 2020 09:49:00 -0700 (PDT) MIME-Version: 1.0 References: <20191018161033.261971-1-samitolvanen@google.com> <20200427160018.243569-1-samitolvanen@google.com> <20200427160018.243569-2-samitolvanen@google.com> In-Reply-To: <20200427160018.243569-2-samitolvanen@google.com> From: Miguel Ojeda Date: Mon, 27 Apr 2020 18:48:49 +0200 Message-ID: Subject: Re: [PATCH v13 01/12] add support for Clang's Shadow Call Stack (SCS) To: Sami Tolvanen X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_094903_213365_F183E8DA X-CRM114-Status: GOOD ( 11.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Juri Lelli , Kernel Hardening , Peter Zijlstra , Catalin Marinas , Will Deacon , Marc Zyngier , Masahiro Yamada , clang-built-linux , Ingo Molnar , Laura Abbott , Dave Martin , Kees Cook , Jann Horn , Steven Rostedt , Linux ARM , Michal Marek , Ard Biesheuvel , Nick Desaulniers , linux-kernel , James Morse , Masami Hiramatsu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 27, 2020 at 6:00 PM Sami Tolvanen wrote: > > diff --git a/include/linux/compiler-clang.h b/include/linux/compiler-clang.h > index 333a6695a918..18fc4d29ef27 100644 > --- a/include/linux/compiler-clang.h > +++ b/include/linux/compiler-clang.h > @@ -42,3 +42,9 @@ > * compilers, like ICC. > */ > #define barrier() __asm__ __volatile__("" : : : "memory") > + > +#if __has_feature(shadow_call_stack) > +# define __noscs __attribute__((__no_sanitize__("shadow-call-stack"))) > +#else > +# define __noscs > +#endif Can we remove the `#else` branch? compiler_types.h [*] has to care anyway about that case for other compilers anyway, no? > diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h > index e970f97a7fcb..97b62f47a80d 100644 > --- a/include/linux/compiler_types.h > +++ b/include/linux/compiler_types.h > @@ -193,6 +193,10 @@ struct ftrace_likely_data { > # define randomized_struct_fields_end > #endif > > +#ifndef __noscs > +# define __noscs > +#endif [*] Here Cheers, Miguel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel