From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A118C4338F for ; Wed, 4 Aug 2021 08:43:33 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE58E60200 for ; Wed, 4 Aug 2021 08:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CE58E60200 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Wg/ePsces67e57rj3Z7qEC6aukDHPycKTmhOWrAnQtA=; b=0qBy8+p1Fky5wq gwAnoWqvZwxffhSb7bu6q1NHk2qJeq9q9XThAa5N/Q+FjzcvFzNsTlqO32mb4d73r9jmZCxjIYbwX x2G/DfFwb10+RjY2aGpiSTU88tGG2u/bpVIMXllDzJgHhLpCAIx7pPlkloaRUNsUYhVI4WHLHhQsI qVhWIXDkEKLAjbqC0aumb83xbvYMfuZnVOF9oZfRIKB9/uTJEx6VNSUjiA2wjzfsRhC89u/ifEGJs Q6LidZ8yIwcl77EEiIcRyif5QGhtuAoFzmPwuUTdI/1Q/Gzov5riH83w2A45uotJJT94eY8i/+cap 1LhBFyYrCjorWL39F2Qw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBCTB-005BXo-Vn; Wed, 04 Aug 2021 08:41:46 +0000 Received: from mail-ot1-x32c.google.com ([2607:f8b0:4864:20::32c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBCT6-005BV8-Rx for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 08:41:43 +0000 Received: by mail-ot1-x32c.google.com with SMTP id h63-20020a9d14450000b02904ce97efee36so1006777oth.7 for ; Wed, 04 Aug 2021 01:41:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ry/C788Ax+QRjoem679Qz9xjcGp3R8vxYXF3Ug8T/cU=; b=CdeSijkPZlqUImGIAEzCPBTp6l7WQasuELwBXyk/ZoG5VDeh1gjR+9z3QgEETkKMXx ESlpE0ZjQ6Hm4EczMgQduF7lq//myVLatAB4ctFpbLT5+96N383jrCYI+6OROefnr406 vQk/G+owiXqx6JVCRyqvTddr/+DGhRXI+vd61ALTEzm5pGxtmfJp9fAHE+I7gsVluHKn HzgA76R4usQfRo5H8GM4t39wQzbxhwP7HYrKHuoMo1v4E8IHXBPydAKh5qHaWXy8oW+Y J+Qikv9yXbG5K5ClLtSz4jV/dOrpGWZf0sJpFAB0kWfvC8KHFw9VjvZb5H7RQw8e0C6m s+2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ry/C788Ax+QRjoem679Qz9xjcGp3R8vxYXF3Ug8T/cU=; b=Bm2NuQAOMutir/slwIJeqeAyCO6VeAqLzNXpxDuFitQb/gq1UCcb4ASPLT0LWxR/Cm U8kMPyTIjb8zDwd1t72pfDo+xaLPUiHSDRkGGnKElhA9g1Ccy0wETfmlgcR7J+Es6vn8 Le1vn6cbwe4IeFOX9M8bjnqdlEJMuh4sH0eZsi/zFn9xTp9jpTwtunufos48MhFRdFkk NiwiTcVr4YqC+l2Y/r8dKeeoJQd7AuTLD5Gz9IrxFehV6Wmwwbj4UMlhYZfmLIEWAx7v tIJuP0W14Xy5g8O2ALtVUOaauy/u4SB78OrxzFIoaEJW0yzdf2r3gs4e2vDJhWCfX8ov 3iNw== X-Gm-Message-State: AOAM531kkzU+Qn7OTA3Iw4mg7EIbyiWjQHdFZA2ZSMcONYPUOGfkazCN PgkfdXwEEilRGMwXdKB02iZA8/KYyyoUUat1wgcU6g== X-Google-Smtp-Source: ABdhPJwULOwQJrId2LR6uf4OqnUiOnC6+yQnX9X5/0EP+lRGGxsuaAeYFWMZ2K7UDJwoWl0nMWJTt4uXnmlICOmyUos= X-Received: by 2002:a05:6830:1490:: with SMTP id s16mr2295783otq.233.1628066496794; Wed, 04 Aug 2021 01:41:36 -0700 (PDT) MIME-Version: 1.0 References: <20210804082230.10837-1-Kuan-Ying.Lee@mediatek.com> <20210804082230.10837-3-Kuan-Ying.Lee@mediatek.com> In-Reply-To: <20210804082230.10837-3-Kuan-Ying.Lee@mediatek.com> From: Marco Elver Date: Wed, 4 Aug 2021 10:41:25 +0200 Message-ID: Subject: Re: [PATCH v2 2/2] kasan, slub: reset tag when printing address To: Kuan-Ying Lee Cc: Nicholas Tang , Andrew Yang , Andrey Konovalov , Andrey Ryabinin , Alexander Potapenko , Catalin Marinas , Chinwen Chang , Andrew Morton , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_014140_946334_9D4B3033 X-CRM114-Status: GOOD ( 20.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 4 Aug 2021 at 10:23, Kuan-Ying Lee wrote: > > The address still includes the tags when it is printed. > With hardware tag-based kasan enabled, we will get a > false positive KASAN issue when we access metadata. > > Reset the tag before we access the metadata. > > Fixes: aa1ef4d7b3f6 ("kasan, mm: reset tags when accessing metadata") > Signed-off-by: Kuan-Ying Lee > Suggested-by: Marco Elver Note, in this case Suggested-by is inappropriate, because I did not suggest the change in any way (you already had it in v1). I just commented on the fact that it's missing a Fixes so stable can pick it up and some clarification. Reviewed-by: Marco Elver > --- > mm/slub.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index b6c5205252eb..f77d8cd79ef7 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -576,8 +576,8 @@ static void print_section(char *level, char *text, u8 *addr, > unsigned int length) > { > metadata_access_enable(); > - print_hex_dump(level, kasan_reset_tag(text), DUMP_PREFIX_ADDRESS, > - 16, 1, addr, length, 1); > + print_hex_dump(level, text, DUMP_PREFIX_ADDRESS, > + 16, 1, kasan_reset_tag((void *)addr), length, 1); > metadata_access_disable(); > } > > -- > 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel