From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D9E4C4338F for ; Wed, 25 Aug 2021 09:56:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D25D660E97 for ; Wed, 25 Aug 2021 09:56:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D25D660E97 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CSpFK9fZDDfUBmsIQLXuXuf6fqhjgritDUNsYAOJcoU=; b=JvDiAz5IHeUKU6 InshgknOL/Wdr2wlGnCKFBRo1Fr6K01d3OIEnUUq7011b7PtUEmka22zOt/F7ZsO1Ui3Z7/6phhJc jz4Frb+ltmqxKH4MVK8BAK8tDFks+8lfdA8gEX04mIk8NOZ/gtz7YlQhfJez56DFfJcvhUgr9lkRI H3FRXLxLqQ5u3cfV5YL0LQ1BeNfNEvfRvSafEBknV9VFSpuxrmbVngmn2Sq2gtA+D0eAbpb/tLG9w IzdGqHDi3pZnYf3W9eQSENFwYz/WJAtc6t/uZPlIQPRz4AWh04OOFAHE5MFA/1w+pvWr50rFxYdq+ U4iLXS5yGcRCFStwb0SA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpcF-006GzK-23; Wed, 25 Aug 2021 09:54:39 +0000 Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIpc4-006Gv5-TD for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 09:54:30 +0000 Received: by mail-ot1-x330.google.com with SMTP id v33-20020a0568300921b0290517cd06302dso54030930ott.13 for ; Wed, 25 Aug 2021 02:54:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=u292+T+PmNvvzzkHWgQqQyq2ET9S9Sd8vOWw3NIaxU8=; b=fdYoLhyAPa70zFflHkbc0jPuLAmarJelaiV3EHuGBC/x6BSW9INC3reopeOhNwOrqd fOuDF0G5YMfSVhbcXIhd6XIm2wtPJXNq9DU4g52Dh2vMTXdN1l3feSj1mDkAAxuIVwqL d52eeW/FPCDLsePj1vTohQn63Z621mFMjkrwxrHKPmiXQyiVlF4TBSa6MHkAyNX3WplF QsljTBxdjH02ED28l/YVKOwF0vcI4bYx3sPmZ+LiGc3ib75jm5RDYFaHEEYxRq5K/2iN fDtAACYtC3OrjCoPrmfvB0Wbz18jEgiBYBuL3ewMzNNccpQPqSP9ro42Il0zkqr5fCok aK5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=u292+T+PmNvvzzkHWgQqQyq2ET9S9Sd8vOWw3NIaxU8=; b=mNeIqfuSijCPNZvaXE46Ecelc68NMFJTGeqaAuL9vPC7nRNEUVtfo2UBBwhxg1wlsf FKIjbLWNX936+9wgE7UtWPcsNoxGKLIELIsdwyZQzyBPGpj6I1kV/SmbdPzitKuASt2C fhoHWxk7F6PE018bHisfvXNJAlKMxy80eHWpKuhEeDlt5T/CLnOJHJxMX3O6ZzpKQs03 U9+pK9tyNEUTYI4tkTrAkXyFgZDb0+DRKICt2amP9O/BpDBlXwWLW8dFVUKY+05m+s+w D2UIhzZftlWWaan5xAncGVr7fMnXIGQvRD9XDNmJJ9s/dgQ7Y3vY2QGtJZAzZWQvzRw4 qNfQ== X-Gm-Message-State: AOAM530KRx2b8bjnNOCOES/b8TRBDua9aulefG/bLTy6Y/a1zboA5V5H h5RRMe8ctHAvLz1p/TmHDazso8hOOBeK5QqbRowJAA== X-Google-Smtp-Source: ABdhPJw06OWfSSBQZ90EY4CXd+Zmvqbypk7F8T9q6crqFZCrAOl83adjr3qFW1g6VdvZOZGe1cBQw2A+a5HSTLvCuTY= X-Received: by 2002:a05:6830:88:: with SMTP id a8mr36303165oto.233.1629885264254; Wed, 25 Aug 2021 02:54:24 -0700 (PDT) MIME-Version: 1.0 References: <20210825092116.149975-1-wangkefeng.wang@huawei.com> <20210825092116.149975-5-wangkefeng.wang@huawei.com> In-Reply-To: From: Marco Elver Date: Wed, 25 Aug 2021 11:54:12 +0200 Message-ID: Subject: Re: [PATCH 4/4] mm: kfence: Only load kfence_test when kfence is enabled To: Alexander Potapenko Cc: Kefeng Wang , Russell King , Dmitry Vyukov , Linux ARM , LKML , kasan-dev , Andrew Morton X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_025428_971793_7F1AE00A X-CRM114-Status: GOOD ( 15.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 25 Aug 2021 at 11:31, Alexander Potapenko wrote: > On Wed, Aug 25, 2021 at 11:17 AM Kefeng Wang wrote: > > > > Provide kfence_is_enabled() helper, only load kfence_test module > > when kfence is enabled. > > What's wrong with the current behavior? > I think we need at least some way to tell the developer that KFENCE > does not work, and a failing test seems to be the perfect one. Like Alex said, this is working as intended. The KFENCE test verifies that everything is working as expected, *including* that KFENCE was enabled, and has already helped us identify issues where we expected it to be enabled! Trying to run the test when KFENCE was intentionally disabled is therefore not a useful usecase. Please drop this patch. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel