From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A5BDC2D0E4 for ; Tue, 17 Nov 2020 13:20:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A3A2324248 for ; Tue, 17 Nov 2020 13:20:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bn0FUOhC"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="kHpe6Zac" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A3A2324248 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VEBrwkBNQQZ5rcj+sA11nQJgxVDaUuzpw3XeDg8Ld/k=; b=bn0FUOhC3dhaeC/vkMQQjgFaX FDt3nHcOn8le6Cg+mSWL5fIAzog18FJpf4K45vX76Z9/3SVl9tvYkUH10AiGN5zt0GAXLN/V4BvxC q2SSQTIfculc8MRbQgVQrg4IAvUrfw7omKL5HQzkVnasPBFXeeTq7xZ5t3SwaYg+kHMr1d+mTDYuq EZoyhpz99CUp0Y4pvXXaKpfdAqxqvPAKulOSoguXQLuqLHDlMizE0NaBw/X/A/enzi1U1wm2ruQgv V9Psx0DFZ1n0EuO5qWBRDXJTjQsUiD4JDTntxxq+ZOyb9nVJfn/0roWbbhJHi46d1LC6cTiCsPAUk tUaf0vpxg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf0sm-0001bE-20; Tue, 17 Nov 2020 13:18:52 +0000 Received: from mail-ot1-x342.google.com ([2607:f8b0:4864:20::342]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kf0si-0001ZA-KP for linux-arm-kernel@lists.infradead.org; Tue, 17 Nov 2020 13:18:49 +0000 Received: by mail-ot1-x342.google.com with SMTP id l36so19330802ota.4 for ; Tue, 17 Nov 2020 05:18:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pa0dw+2YDpQA3Ip7yWMCpwDF+q2V8p/vPHE4K5vOsWU=; b=kHpe6ZacvQalxImqYZ7Y/Tk8Xjw4k5FGX1UY3t/LRIwWRZmd9vBOLAnRtGqkYTNV/8 N1tM1Z4t15cJ3hI03/Fqy/u766FH2Q7C8ibXnQH7ygnlt6SoY516fehJgltRw4Tdf5ou /MIP8VoxRk3+7pMZiBxotFbBZH69xaXFxn/P770IbhdeB8US1QVd5wwWZSv2TGMJMdDq q1vj0z/gj/AVe8F1on0J3RXV2WEidKxliEvz9jYscGMLWveMr31Z1FwxwYoWb4MwZ8K7 RXBTdRlJRkRk6umlo+RJd4UAY9lxe5infHlR0AznIXeW8P+2ovCZb7vlhoqecEma65s+ 4xJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pa0dw+2YDpQA3Ip7yWMCpwDF+q2V8p/vPHE4K5vOsWU=; b=GclrWz3h8nrCiOAEbNYZgJv3x6yrm1rIAmve9L2FbkivZ+MKSNLaDQTjkK8/8Qas1P olPAsk1RFAqNiOEC3bqddB2uOpuhI3EvLJ2y4a53gc5q+9HrFUrxB5J0vNoE6m06EzW5 FPgzFULsLjqlwdFmSJQtaq5uyGj7+2gLiy3DdM/WbwG8N7QkwoNQC+ShT+MryrYfeBdz lqeEuiS2IiJW4GSxyupHIendjzWRjTmutReiMQ0mhHrgNRrXERoCsk9vfXrhP3jZKACx 9/p3tg3gTMiDQ3fq94Q6KDqln/5UWZLbv4igDGBh5VNvdNixV/h8YTeNHSn7Dq8s61yO N12A== X-Gm-Message-State: AOAM5326ZOy98Nn6LyNy0iFcZpzPYBCVvFeKqTFWpR+LVEQeNv1moaSI 2p7BMR2fkmBtsKxnv0jDHlkkKzzsneMr9U+slMSxxw== X-Google-Smtp-Source: ABdhPJzceQV4pvLQZoRKoQlzVJPrNglPcBp5aH4wjBQUCmugGSRGSwyeI7fnJHOFVn7ftcB1JSeqjD1Y2otDtNStrlc= X-Received: by 2002:a9d:f44:: with SMTP id 62mr3111227ott.17.1605619124327; Tue, 17 Nov 2020 05:18:44 -0800 (PST) MIME-Version: 1.0 References: <52518837b34d607abbf30855b3ac4cb1a9486946.1605305978.git.andreyknvl@google.com> In-Reply-To: From: Marco Elver Date: Tue, 17 Nov 2020 14:18:32 +0100 Message-ID: Subject: Re: [PATCH mm v3 17/19] kasan: clean up metadata allocation and usage To: Dmitry Vyukov X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201117_081848_712614_6FF65085 X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Andrey Konovalov , Kevin Brodsky , Will Deacon , LKML , kasan-dev , Linux-MM , Alexander Potapenko , Linux ARM , Catalin Marinas , Andrey Ryabinin , Andrew Morton , Vincenzo Frascino , Evgenii Stepanov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 17 Nov 2020 at 14:12, Dmitry Vyukov wrote: > > + */ > > *(u8 *)kasan_mem_to_shadow(object) = KASAN_KMALLOC_FREE; > > + > > ___cache_free(cache, object, _THIS_IP_); > > > > if (IS_ENABLED(CONFIG_SLAB)) > > @@ -168,6 +173,9 @@ void quarantine_put(struct kmem_cache *cache, void *object) > > struct qlist_head temp = QLIST_INIT; > > struct kasan_free_meta *meta = kasan_get_free_meta(cache, object); > > > > + if (!meta) > > + return; > > Humm... is this possible? If yes, we would be leaking the object here... > Perhaps BUG_ON with a comment instead. If this is possible in prod-mode KASAN, a WARN_ON() that returns would be safer. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel