* [RESEND 00/25] Rid W=1 warnings from HID
@ 2021-03-26 14:34 Lee Jones
2021-03-26 14:34 ` Lee Jones
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [RESEND 00/25] Rid W=1 warnings from HID
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
@ 2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
[RESEND] contains no functional changes. Only 18 of 25 patches
actually made it to the list during the first attempt.
Lee Jones (25):
HID: intel-ish-hid: Remove unused variable 'err'
HID: ishtp-hid-client: Move variable to where it's actually used
HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
HID: intel-ish: Supply some missing param descriptions
HID: intel-ish: Fix a naming disparity and a formatting error
HID: usbhid: Repair a formatting issue in a struct description
HID: intel-ish-hid: Fix a little doc-rot
HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
HID: hid-alps: Correct struct misnaming
HID: intel-ish-hid: Fix potential copy/paste error
HID: hid-core: Fix incorrect function name in header
HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
header
HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
HID: hid-picolcd_core: Remove unused variable 'ret'
HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
abuses
HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
HID: hid-uclogic-params: Ensure function names are present and correct
in kernel-doc headers
HID: hid-sensor-custom: Remove unused variable 'ret'
HID: wacom_sys: Demote kernel-doc abuse
HID: hid-sensor-hub: Remove unused struct member 'quirks'
HID: hid-sensor-hub: Move 'hsdev' description to correct struct
definition
HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
drivers/hid/hid-alps.c | 2 +-
drivers/hid/hid-core.c | 2 +-
drivers/hid/hid-kye.c | 2 +-
drivers/hid/hid-logitech-hidpp.c | 7 +--
drivers/hid/hid-picolcd_core.c | 5 +--
drivers/hid/hid-sensor-custom.c | 5 +--
drivers/hid/hid-sensor-hub.c | 4 +-
drivers/hid/hid-thrustmaster.c | 24 +++++------
drivers/hid/hid-uclogic-params.c | 8 ++--
drivers/hid/hid-uclogic-rdesc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/ipc.c | 2 +-
drivers/hid/intel-ish-hid/ipc/pci-ish.c | 3 +-
drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 45 ++++++++++----------
drivers/hid/intel-ish-hid/ishtp-hid-client.c | 11 +++--
drivers/hid/intel-ish-hid/ishtp-hid.c | 2 +-
drivers/hid/intel-ish-hid/ishtp-hid.h | 9 +---
drivers/hid/intel-ish-hid/ishtp/bus.c | 9 +++-
drivers/hid/intel-ish-hid/ishtp/client.c | 5 +--
drivers/hid/intel-ish-hid/ishtp/hbm.c | 4 +-
drivers/hid/intel-ish-hid/ishtp/ishtp-dev.h | 4 +-
drivers/hid/usbhid/hid-pidff.c | 4 +-
drivers/hid/usbhid/usbkbd.c | 2 +-
drivers/hid/wacom_sys.c | 2 +-
include/linux/intel-ish-client-if.h | 8 +++-
24 files changed, 90 insertions(+), 81 deletions(-)
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Anssi Hannula <anssi.hannula@gmail.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: "Bruno Prémont" <bonbons@linux-vserver.org>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: Daniel Drubin <daniel.drubin@intel.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: Henrik Rydberg <rydberg@bitmath.org>
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Jonathan Cameron <jic23@kernel.org>
Cc: Kai-Heng Feng <kai.heng.feng@canonical.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: linaro-mm-sig@lists.linaro.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-iio@vger.kernel.org
Cc: linux-input@vger.kernel.org
Cc: linux-media@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-usb@vger.kernel.org
Cc: Lopez Casado <nlopezcasad@logitech.com>
Cc: "L. Vinyard, Jr" <rvinyard@cs.nmsu.edu>
Cc: Masaki Ota <masaki.ota@jp.alps.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: message to <vojtech@ucw.cz>
Cc: Michael Haboustak <mike-@cinci.rr.com>
Cc: Rushikesh S Kadam <rushikesh.s.kadam@intel.com>
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Sumit Semwal <sumit.semwal@linaro.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>
Cc: Vojtech Pavlik <vojtech@suse.cz>
Cc: Zhang Lixu <lixu.zhang@intel.com>
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
@ 2021-03-26 14:34 ` Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2 siblings, 0 replies; 7+ messages in thread
From: Lee Jones @ 2021-03-26 14:34 UTC (permalink / raw)
To: lee.jones
Cc: linux-kernel, Jiri Kosina, Benjamin Tissoires, Maxime Coquelin,
Alexandre Torgue, Dario Pagani, Kim Kuparinen, linux-input,
linux-stm32, linux-arm-kernel
Fixes the following W=1 kernel build warning(s):
drivers/hid/hid-thrustmaster.c:23: warning: Incorrect use of kernel-doc format: * These interrupts are used to prevent a nasty crash when initializing the
drivers/hid/hid-thrustmaster.c:26: warning: cannot understand function prototype: 'const u8 setup_0[] = '
drivers/hid/hid-thrustmaster.c:49: warning: cannot understand function prototype: 'struct tm_wheel_info '
drivers/hid/hid-thrustmaster.c:62: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:84: warning: cannot understand function prototype: 'struct __packed tm_wheel_response '
drivers/hid/hid-thrustmaster.c:143: warning: wrong kernel-doc identifier on line:
drivers/hid/hid-thrustmaster.c:202: warning: Function parameter or member 'urb' not described in 'thrustmaster_model_handler'
drivers/hid/hid-thrustmaster.c:202: warning: expecting prototype for Called by the USB subsystem when the wheel responses to our request(). Prototype was for thrustmaster_model_handler() instead
drivers/hid/hid-thrustmaster.c:265: warning: wrong kernel-doc identifier on line:
Cc: Jiri Kosina <jikos@kernel.org>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: Dario Pagani <dario.pagani.146+linuxk@gmail.com>
Cc: Kim Kuparinen <kimi.h.kuparinen@gmail.com>
Cc: linux-input@vger.kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com
Cc: linux-arm-kernel@lists.infradead.org
Signed-off-by: Lee Jones <lee.jones@linaro.org>
---
drivers/hid/hid-thrustmaster.c | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/hid/hid-thrustmaster.c b/drivers/hid/hid-thrustmaster.c
index bfcd08759ba09..4f9c0642e816b 100644
--- a/drivers/hid/hid-thrustmaster.c
+++ b/drivers/hid/hid-thrustmaster.c
@@ -1,5 +1,5 @@
// SPDX-License-Identifier: GPL-2.0
-/**
+/*
* When connected to the machine, the Thrustmaster wheels appear as
* a «generic» hid gamepad called "Thrustmaster FFB Wheel".
*
@@ -19,7 +19,7 @@
#include <linux/slab.h>
#include <linux/module.h>
-/**
+/*
* These interrupts are used to prevent a nasty crash when initializing the
* T300RS. Used in thrustmaster_interrupts().
*/
@@ -36,7 +36,7 @@ static const unsigned int setup_arr_sizes[] = {
ARRAY_SIZE(setup_3),
ARRAY_SIZE(setup_4)
};
-/**
+/*
* This struct contains for each type of
* Thrustmaster wheel
*
@@ -49,7 +49,7 @@ static const unsigned int setup_arr_sizes[] = {
struct tm_wheel_info {
uint16_t wheel_type;
- /**
+ /*
* See when the USB control out packet is prepared...
* @TODO The TMX seems to require multiple control codes to switch.
*/
@@ -58,7 +58,7 @@ struct tm_wheel_info {
char const *const wheel_name;
};
-/**
+/*
* Known wheels.
* Note: TMX does not work as it requires 2 control packets
*/
@@ -72,7 +72,7 @@ static const struct tm_wheel_info tm_wheels_infos[] = {
static const uint8_t tm_wheels_infos_length = 4;
-/**
+/*
* This structs contains (in little endian) the response data
* of the wheel to the request 73
*
@@ -82,7 +82,7 @@ static const uint8_t tm_wheels_infos_length = 4;
*/
struct __packed tm_wheel_response
{
- /**
+ /*
* Seems to be the type of packet
* - 0x0049 if is data.a (15 bytes)
* - 0x0047 if is data.b (7 bytes)
@@ -93,7 +93,7 @@ struct __packed tm_wheel_response
struct __packed {
uint16_t field0;
uint16_t field1;
- /**
+ /*
* Seems to be the model code of the wheel
* Read table thrustmaster_wheels to values
*/
@@ -122,7 +122,7 @@ struct tm_wheel {
struct usb_ctrlrequest *change_request;
};
-/** The control packet to send to wheel */
+/* The control packet to send to wheel */
static const struct usb_ctrlrequest model_request = {
.bRequestType = 0xc1,
.bRequest = 73,
@@ -139,7 +139,7 @@ static const struct usb_ctrlrequest change_request = {
.wLength = 0
};
-/**
+/*
* On some setups initializing the T300RS crashes the kernel,
* these interrupts fix that particular issue. So far they haven't caused any
* adverse effects in other wheels.
@@ -191,7 +191,7 @@ static void thrustmaster_change_handler(struct urb *urb)
hid_warn(hdev, "URB to change wheel mode seems to have failed with error %d\n", urb->status);
}
-/**
+/*
* Called by the USB subsystem when the wheel responses to our request
* to get [what it seems to be] the wheel's model.
*
@@ -261,7 +261,7 @@ static void thrustmaster_remove(struct hid_device *hdev)
hid_hw_stop(hdev);
}
-/**
+/*
* Function called by HID when a hid Thrustmaster FFB wheel is connected to the host.
* This function starts the hid dev, tries to allocate the tm_wheel data structure and
* finally send an USB CONTROL REQUEST to the wheel to get [what it seems to be] its
--
2.27.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Lee Jones
@ 2021-04-06 8:56 ` Lee Jones
2021-04-07 16:09 ` Benjamin Tissoires
2 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2021-04-06 8:56 UTC (permalink / raw)
To: linux-kernel, Alexandre Torgue, Anssi Hannula,
Benjamin Tissoires, Bruno Prémont, Christian König,
Daniel Drubin, Dario Pagani, dri-devel, Henrik Rydberg,
Jiri Kosina, Jonathan Cameron, Kai-Heng Feng, Kim Kuparinen,
Krzysztof Wilczyński, linaro-mm-sig, linux-arm-kernel,
linux-iio, linux-input, linux-media, linux-stm32, linux-usb,
Lopez Casado, L. Vinyard, Jr, Masaki Ota, Maxime Coquelin,
message to, Michael Haboustak, Rushikesh S Kadam,
Srinivas Pandruvada, Sumit Semwal, Uwe Kleine-König,
Vojtech Pavlik, Zhang Lixu
On Fri, 26 Mar 2021, Lee Jones wrote:
> This set is part of a larger effort attempting to clean-up W=1
> kernel builds, which are currently overwhelmingly riddled with
> niggly little warnings.
>
> Lee Jones (25):
> HID: intel-ish-hid: Remove unused variable 'err'
> HID: ishtp-hid-client: Move variable to where it's actually used
> HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> HID: intel-ish: Supply some missing param descriptions
> HID: intel-ish: Fix a naming disparity and a formatting error
> HID: usbhid: Repair a formatting issue in a struct description
> HID: intel-ish-hid: Fix a little doc-rot
> HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> HID: hid-alps: Correct struct misnaming
> HID: intel-ish-hid: Fix potential copy/paste error
> HID: hid-core: Fix incorrect function name in header
> HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> header
> HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> HID: hid-picolcd_core: Remove unused variable 'ret'
> HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> abuses
> HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> HID: hid-uclogic-params: Ensure function names are present and correct
> in kernel-doc headers
> HID: hid-sensor-custom: Remove unused variable 'ret'
> HID: wacom_sys: Demote kernel-doc abuse
> HID: hid-sensor-hub: Remove unused struct member 'quirks'
> HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> definition
> HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
These have been on the list for a couple of weeks now.
Is there anything I can do to help expedite their merge?
I'm concerned since -rc6 has just been released.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
@ 2021-04-07 16:09 ` Benjamin Tissoires
2021-04-08 7:06 ` Lee Jones
0 siblings, 1 reply; 7+ messages in thread
From: Benjamin Tissoires @ 2021-04-07 16:09 UTC (permalink / raw)
To: Lee Jones
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 26 Mar 2021, Lee Jones wrote:
>
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > Lee Jones (25):
> > HID: intel-ish-hid: Remove unused variable 'err'
> > HID: ishtp-hid-client: Move variable to where it's actually used
> > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > HID: intel-ish: Supply some missing param descriptions
> > HID: intel-ish: Fix a naming disparity and a formatting error
> > HID: usbhid: Repair a formatting issue in a struct description
> > HID: intel-ish-hid: Fix a little doc-rot
> > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > HID: hid-alps: Correct struct misnaming
> > HID: intel-ish-hid: Fix potential copy/paste error
> > HID: hid-core: Fix incorrect function name in header
> > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > header
> > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > HID: hid-picolcd_core: Remove unused variable 'ret'
> > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > abuses
> > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > HID: hid-uclogic-params: Ensure function names are present and correct
> > in kernel-doc headers
> > HID: hid-sensor-custom: Remove unused variable 'ret'
> > HID: wacom_sys: Demote kernel-doc abuse
> > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > definition
> > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
>
> These have been on the list for a couple of weeks now.
>
> Is there anything I can do to help expedite their merge?
>
> I'm concerned since -rc6 has just been released.
Sorry for the delay.
I am currently queuing them locally and running a few tests on them. I
don't expect anything to happen, but better be safe than anything.
FWIW, I am splitting the series in 3:
- 11 patches for intel ish are going to be queued in for-5.13/intel-ish
- the thrustmaster one in for-5.13/thrustmaster
- the rest (13 patches) will be sent in for-5.13/warnings.
Cheers,
Benjamin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-07 16:09 ` Benjamin Tissoires
@ 2021-04-08 7:06 ` Lee Jones
2021-04-08 11:43 ` Benjamin Tissoires
0 siblings, 1 reply; 7+ messages in thread
From: Lee Jones @ 2021-04-08 7:06 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
> On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> >
> > > This set is part of a larger effort attempting to clean-up W=1
> > > kernel builds, which are currently overwhelmingly riddled with
> > > niggly little warnings.
> > >
> > > Lee Jones (25):
> > > HID: intel-ish-hid: Remove unused variable 'err'
> > > HID: ishtp-hid-client: Move variable to where it's actually used
> > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > HID: intel-ish: Supply some missing param descriptions
> > > HID: intel-ish: Fix a naming disparity and a formatting error
> > > HID: usbhid: Repair a formatting issue in a struct description
> > > HID: intel-ish-hid: Fix a little doc-rot
> > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > HID: hid-alps: Correct struct misnaming
> > > HID: intel-ish-hid: Fix potential copy/paste error
> > > HID: hid-core: Fix incorrect function name in header
> > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > header
> > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > HID: hid-picolcd_core: Remove unused variable 'ret'
> > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > abuses
> > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > HID: hid-uclogic-params: Ensure function names are present and correct
> > > in kernel-doc headers
> > > HID: hid-sensor-custom: Remove unused variable 'ret'
> > > HID: wacom_sys: Demote kernel-doc abuse
> > > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > definition
> > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> >
> > These have been on the list for a couple of weeks now.
> >
> > Is there anything I can do to help expedite their merge?
> >
> > I'm concerned since -rc6 has just been released.
>
> Sorry for the delay.
>
> I am currently queuing them locally and running a few tests on them. I
> don't expect anything to happen, but better be safe than anything.
>
> FWIW, I am splitting the series in 3:
> - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> - the thrustmaster one in for-5.13/thrustmaster
> - the rest (13 patches) will be sent in for-5.13/warnings.
Sounds good to me. Thanks Benjamin.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND 00/25] Rid W=1 warnings from HID
2021-04-08 7:06 ` Lee Jones
@ 2021-04-08 11:43 ` Benjamin Tissoires
0 siblings, 0 replies; 7+ messages in thread
From: Benjamin Tissoires @ 2021-04-08 11:43 UTC (permalink / raw)
To: Lee Jones
Cc: lkml, Alexandre Torgue, Anssi Hannula, Bruno Prémont,
Christian König, Daniel Drubin, Dario Pagani, dri-devel,
Henrik Rydberg, Jiri Kosina, Jonathan Cameron, Kai-Heng Feng,
Kim Kuparinen, Krzysztof Wilczyński, linaro-mm-sig,
Linux ARM, linux-iio, open list:HID CORE LAYER, linux-media,
linux-stm32, Linux USB Mailing List, Lopez Casado, L. Vinyard,
Jr, Masaki Ota, Maxime Coquelin, message to, Michael Haboustak,
Rushikesh S Kadam, Srinivas Pandruvada, Sumit Semwal,
Uwe Kleine-König, Vojtech Pavlik, Zhang Lixu
On Thu, Apr 8, 2021 at 9:06 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Wed, 07 Apr 2021, Benjamin Tissoires wrote:
>
> > On Tue, Apr 6, 2021 at 10:56 AM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Fri, 26 Mar 2021, Lee Jones wrote:
> > >
> > > > This set is part of a larger effort attempting to clean-up W=1
> > > > kernel builds, which are currently overwhelmingly riddled with
> > > > niggly little warnings.
> > > >
> > > > Lee Jones (25):
> > > > HID: intel-ish-hid: Remove unused variable 'err'
> > > > HID: ishtp-hid-client: Move variable to where it's actually used
> > > > HID: intel-ish-hid: pci-ish: Remove unused variable 'ret'
> > > > HID: intel-ish: Supply some missing param descriptions
> > > > HID: intel-ish: Fix a naming disparity and a formatting error
> > > > HID: usbhid: Repair a formatting issue in a struct description
> > > > HID: intel-ish-hid: Fix a little doc-rot
> > > > HID: usbhid: hid-pidff: Demote a couple kernel-doc abuses
> > > > HID: hid-alps: Correct struct misnaming
> > > > HID: intel-ish-hid: Fix potential copy/paste error
> > > > HID: hid-core: Fix incorrect function name in header
> > > > HID: intel-ish-hid: ipc: Correct fw_reset_work_fn() function name in
> > > > header
> > > > HID: ishtp-hid-client: Fix incorrect function name report_bad_packet()
> > > > HID: hid-kye: Fix incorrect function name for kye_tablet_enable()
> > > > HID: hid-picolcd_core: Remove unused variable 'ret'
> > > > HID: hid-logitech-hidpp: Fix conformant kernel-doc header and demote
> > > > abuses
> > > > HID: hid-uclogic-rdesc: Kernel-doc is for functions and structs
> > > > HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses
> > > > HID: hid-uclogic-params: Ensure function names are present and correct
> > > > in kernel-doc headers
> > > > HID: hid-sensor-custom: Remove unused variable 'ret'
> > > > HID: wacom_sys: Demote kernel-doc abuse
> > > > HID: hid-sensor-hub: Remove unused struct member 'quirks'
> > > > HID: hid-sensor-hub: Move 'hsdev' description to correct struct
> > > > definition
> > > > HID: intel-ish-hid: ishtp-fw-loader: Fix a bunch of formatting issues
> > > > HID: ishtp-hid-client: Fix 'suggest-attribute=format' compiler warning
> > >
> > > These have been on the list for a couple of weeks now.
> > >
> > > Is there anything I can do to help expedite their merge?
> > >
> > > I'm concerned since -rc6 has just been released.
> >
> > Sorry for the delay.
> >
> > I am currently queuing them locally and running a few tests on them. I
> > don't expect anything to happen, but better be safe than anything.
> >
> > FWIW, I am splitting the series in 3:
> > - 11 patches for intel ish are going to be queued in for-5.13/intel-ish
> > - the thrustmaster one in for-5.13/thrustmaster
> > - the rest (13 patches) will be sent in for-5.13/warnings.
>
> Sounds good to me. Thanks Benjamin.
>
After a few attempts at fixing my CI, I have now pushed this series as
mentioned previously.
Cheers,
Benjamin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-04-08 11:46 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-26 14:34 [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-03-26 14:34 ` Lee Jones
2021-03-26 14:34 ` [PATCH 18/25] HID: hid-thrustmaster: Demote a bunch of kernel-doc abuses Lee Jones
2021-04-06 8:56 ` [RESEND 00/25] Rid W=1 warnings from HID Lee Jones
2021-04-07 16:09 ` Benjamin Tissoires
2021-04-08 7:06 ` Lee Jones
2021-04-08 11:43 ` Benjamin Tissoires
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).