From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E52FEC433DB for ; Mon, 18 Jan 2021 16:32:33 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ADB2E22BE9 for ; Mon, 18 Jan 2021 16:32:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ADB2E22BE9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Eiyh1tbxwYmZYwItFGwtj2rCkFTxRCA62e7kB2o3aLs=; b=h5ntU+SBVM+NbVvANvpvawRef cjkCrZJiJ+ybRp3d9sO6FHuoVlxl7v+XAxnjUFGA8FxZFH5iETGi689HyswEbRxY5KORaRkGXL40c mBfZyW937Zb4GmQYrRfM00EWX+FdOukxvKZQCrGmh49J99vcoFfgYXwRgBAXWUw3cX0mU2c4yY3NL Oljui3AkrXHHKzpp1arFu/rgsSJxm1SSrxMy8SZTSTu+aatLLueHx6dGOx3pw8S7muLCTTcEpiumG X4eNdmCGzK3GJeWFREZX7/Cb226waN1TY/ai87TYk+Yy5n4IxnhWe9B1T6WtZkcKYY5DViySVrFoO nye41NEOw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1XQp-0004pW-A1; Mon, 18 Jan 2021 16:31:07 +0000 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1XQn-0004p0-6Q for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 16:31:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610987463; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UqqkV4pT3FZ8X8fvg8OJBm77Py4wiQX0myH+LsoZDCw=; b=a6h9eXCo75jl5isULT7F3kmejAQX6of968yumgoMe955AWpcxvhrucIz9zPSkB5y0aqNbg IplVcN0dy7+1gjnBsb2nTRf4Lr8mo2cCUNKH7/S0h9w7ZKQjdLiQGfTTno/koPFRBBogJL flLywJEcIKLU6uOuiF3BoQoddA3BocI= Received: from mail-pg1-f198.google.com (mail-pg1-f198.google.com [209.85.215.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-444-pwJ03SLLMzSgM45HzGoeIg-1; Mon, 18 Jan 2021 11:31:01 -0500 X-MC-Unique: pwJ03SLLMzSgM45HzGoeIg-1 Received: by mail-pg1-f198.google.com with SMTP id y2so13600154pgq.23 for ; Mon, 18 Jan 2021 08:31:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UqqkV4pT3FZ8X8fvg8OJBm77Py4wiQX0myH+LsoZDCw=; b=Vkx8jtP2rSVnF/ymdzGEUvOd0CJoSMsyKVJIZ1U61yI/j1h8hexRt8B2nApMdLHnlX z/ThLpEsGSWCVkWSDLwM01cIaqw0IEsY+W2zEfoAZ4R+x2slbJZgPiTG0tqEii75MNj8 qG1hR1mdBvKs1VLjfCScBI+s4D1b8UxTWKc1JyEb05+jx4+UixrZBUv7awknURaMmZK4 ukbW/pYDuwPfnqrCJZBfHJEBnC5tH05k5D63l0G4h0cYcJHFIHeYed46/cEZ89b5G9wR uFQDm+3RRybPAuoUcYnvt12jVIIh5DHEpZ/SDUQP38eYYVpA0ZZgtxgNtDKP4o5cWHVD YlsQ== X-Gm-Message-State: AOAM532zx+zKJDqm0vEwzh1nP9gFMQpgWz3uMD8oyg2KFQhLT6wrQYyR 0LXRmddTE0aLIbeAPhm+lc/4rJD9A/1bNh6ABojjG4pCC+bGh/1NuGy+EHDHgTavDUw0lIAjE24 QVY4npVj5SxCIC6mMNGHCgZHRG530yN9hqI1+Q6I7tN9Ed21JI80= X-Received: by 2002:a62:5547:0:b029:1a4:cb2a:2833 with SMTP id j68-20020a6255470000b02901a4cb2a2833mr342792pfb.35.1610987459105; Mon, 18 Jan 2021 08:30:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJwQZOW38waFNxH9jbai1nJ21Z+g0/K1dIN8TLDr66GfVuysO8ZrPHNLGZxQPy2H160dRR5gxUpHW2cA6nG/36I= X-Received: by 2002:a62:5547:0:b029:1a4:cb2a:2833 with SMTP id j68-20020a6255470000b02901a4cb2a2833mr342749pfb.35.1610987458819; Mon, 18 Jan 2021 08:30:58 -0800 (PST) MIME-Version: 1.0 References: <20210115170641.903392-1-dianders@chromium.org> In-Reply-To: <20210115170641.903392-1-dianders@chromium.org> From: Benjamin Tissoires Date: Mon, 18 Jan 2021 17:30:47 +0100 Message-ID: Subject: Re: [PATCH v9 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p To: Douglas Anderson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210118_113105_269202_77045C1F X-CRM114-Status: GOOD ( 28.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , =?UTF-8?Q?Guido_G=C3=BCnther?= , Bjorn Andersson , Kai Heng Feng , Will Deacon , Anson Huang , Masahiro Yamada , Vinod Koul , Linux ARM , "open list:HID CORE LAYER" , DTML , Jiri Kosina , Stephen Boyd , Hans De Goede , Rob Herring , Daniel Playfair Cal , Andrea Borgia , Max Krummenacher , Greg Kroah-Hartman , Dmitry Torokhov , lkml , Coiby Xu , Li Yang , Michael Walle , Jiri Kosina , Shawn Guo Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 15, 2021 at 6:07 PM Douglas Anderson wrote: > > > The goal of this series is to support the Goodix GT7375P touchscreen. > This touchscreen is special because it has power sequencing > requirements that necessitate driving a reset GPIO. > > To do this, we totally rejigger the way i2c-hid is organized so that > it's easier to jam the Goodix support in there. > > This series was: > - Tested on a device that uses normal i2c-hid. > - Tested on a device that has a Goodix i2c-hid device. > - Tested on an ACPI device, but an earlier version of the series. > > I believe the plan is for Benjamin to land the whole series. Will > said this about the arm64 defconfig change (and provided his Ack): > > ...there are a few things I really care about > > in defconfig (e.g. things like page size!), generally speaking we don't > > need to Ack everything that changes in there. > > > > That said, might be worth checking whether arm-soc have any defconfig > > changes queued in -next so you don't end up with conflicts. > > Changes in v9: > - 120 ms delay => 180 ms delay > - Local variable in ACPI code "ihid_of" => "ihid_acpi". > - Squash Benjamin's change for ACPI power on. > > Changes in v8: > - Mark suspend/resume as static as per patches robot. > > Changes in v7: > - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") > > Changes in v6: > - ACPI probe function should have been "static" > - Don't export suspend/resume, just export dev_pm_ops from core. > - Fixed crash in ACPI module (missing init of "client") > - No need for regulator include in the core. > - Removed i2c_device_id table from ACPI module. > - Suspend/resume are no longer exported from the core. > > Changes in v5: > - Add shutdown_tail op and use it in ACPI. > - Added mention of i2c-hid in the yaml itself as per Rob. > - Adjusted subject as per Rob. > - i2chid_subclass_data => i2chid_ops. > - power_up_device => power_up (same with power_down). > - subclass => ops. > > Changes in v4: > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > - Fully rejigger so ACPI and OF are full subclasses. > - Totally redid based on the new subclass system. > > Changes in v3: > - Fixed compatible in example. > - Removed Benjamin as a maintainer. > - Rework to use subclassing. > - Updated description. > > Changes in v2: > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > - Get timings based on the compatible string. > - Use a separate compatible string for this new touchscreen. > > Douglas Anderson (4): > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > arm64: defconfig: Update config names for i2c-hid rejigger > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > GT7375P > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core > > .../bindings/input/goodix,gt7375p.yaml | 65 +++++ > arch/arm64/configs/defconfig | 3 +- > drivers/hid/Makefile | 2 +- > drivers/hid/i2c-hid/Kconfig | 47 +++- > drivers/hid/i2c-hid/Makefile | 6 +- > drivers/hid/i2c-hid/i2c-hid-acpi.c | 143 ++++++++++ > drivers/hid/i2c-hid/i2c-hid-core.c | 252 +++--------------- > drivers/hid/i2c-hid/i2c-hid-of-goodix.c | 116 ++++++++ > drivers/hid/i2c-hid/i2c-hid-of.c | 143 ++++++++++ > drivers/hid/i2c-hid/i2c-hid.h | 22 ++ > include/linux/platform_data/i2c-hid.h | 41 --- > 11 files changed, 578 insertions(+), 262 deletions(-) > create mode 100644 Documentation/devicetree/bindings/input/goodix,gt7375p.yaml > create mode 100644 drivers/hid/i2c-hid/i2c-hid-acpi.c > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of-goodix.c > create mode 100644 drivers/hid/i2c-hid/i2c-hid-of.c > delete mode 100644 include/linux/platform_data/i2c-hid.h > Many thanks for the wait. I have now scheduled this series in for-5.12/i2c-hid. Cheers, Benjamin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel