From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0EE2C433E0 for ; Wed, 13 Jan 2021 15:10:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 55F892333E for ; Wed, 13 Jan 2021 15:10:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 55F892333E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=N53D66dnCDlVw7ZrsDeiOvaUwZ+kdZh0eudUPpxcaAs=; b=u5abMbNDvtz6zHZjHS7rjydPh v4+pGSvqBfANXZOzM+PlKia+mc3ZH5YsnbWrQ/q9nTb1H3J9kuEYihX3FXX1yZ9UKzLa8khT2b0LX TZE/kTsbW4Tk2ed1wtsLOtTCuFSFUIm6NkVyCeWDLdvJur6L8y58JDLNPkrhhaFwHrtkrANHJr+cS OxR/1FCPZCtfCDlNKiGR9eNc5GqXonVFyPyQwHc5xZ4HBqVkDE9N0aP/jNkbusFi/FrdFXN/4ei3y OJ2TNa5MkwEGgYjyGjaQHS/xnQXUe4SRsJf6GmuTQIMWZPiA71WKPsOgFPJ50meISdPetXqlh3CSZ XQisxHHJg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzhlm-0007EI-T3; Wed, 13 Jan 2021 15:09:10 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzhlg-0007Cz-5M for linux-arm-kernel@lists.infradead.org; Wed, 13 Jan 2021 15:09:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610550538; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kWipm+X2j1RbsimdpvIAl9U3K5QN86SQ19iK5SoxS1o=; b=RYIfPmZNI15b4RKyI3WhVjL841P+YfWBgU6ezlmXY0Pb1XeLjgKbVvNWNZpWXSqjRoGQm3 AbTsNYFy1loeIsQbN/mfUxWKIyajHnhrNtTJrEi2JIB7L596vhq2uvr6XyT16zVq8DEipo oXYx3irqEB9Exro6uhMCSo9jJizZER0= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-0kQ0hK9qOoms36Cgt1EySg-1; Wed, 13 Jan 2021 10:08:53 -0500 X-MC-Unique: 0kQ0hK9qOoms36Cgt1EySg-1 Received: by mail-pl1-f200.google.com with SMTP id y10so1396268pll.20 for ; Wed, 13 Jan 2021 07:08:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kWipm+X2j1RbsimdpvIAl9U3K5QN86SQ19iK5SoxS1o=; b=tifso4MUy33Fpt6m0LScF9/kyUZkcBNC19yz5jbg1vf1Wx+kAc+nP1DCgrloPAd08C nXaLcuvAx+WydpjBlWt+DTcrUJ2rlZRhLNnkcuftAIaV8uRHvALYrC5Atle68zF320JS w9X4n2o0wrV/p1NCn25KCCsXzQ8P/rqRI5tGsD8FgdIWBzlAHGyvlSkzMoxbWZ2FL2nN uVkX2MG5FcNG/ysJ1bRSEMsFXqf0fmE1uHX0ajtvBx9uiclbz+U47AzOtq5wNRBZT0vy ATAjh3TEZPpUmOrvFF3i4yt6iRxrw6keQVOD1sVYgF8VtB926WV5M0vRHXARpSLToLAS i9mA== X-Gm-Message-State: AOAM532+Bayll3Hc2ezGL3h5QthM+16aTQRNuzcqoUgUWDgA1W/FwBwG FOZzyePeFjviKS4nlsxOgZGb5o59Nv8Baz9yT0Zzt44t0NLAricBaejcfZAnrAWRt7toHgQrAFA cAMcKODm+eSCmvM/epB6acJLicH5d6TOdl+KW9XmtAEbZbyMI7Yw= X-Received: by 2002:a63:4d41:: with SMTP id n1mr2439842pgl.147.1610550532840; Wed, 13 Jan 2021 07:08:52 -0800 (PST) X-Google-Smtp-Source: ABdhPJzvxkW7BMeeEqiByfe7FaWReWauDte5vCp+7LTLQQFvoJcFAxS9Ug7HUmiUfgfocS9TC46d93Yz9Z3rprm9ksw= X-Received: by 2002:a63:4d41:: with SMTP id n1mr2439815pgl.147.1610550532579; Wed, 13 Jan 2021 07:08:52 -0800 (PST) MIME-Version: 1.0 References: <20201211222448.2115188-1-dianders@chromium.org> In-Reply-To: From: Benjamin Tissoires Date: Wed, 13 Jan 2021 16:08:41 +0100 Message-ID: Subject: Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix, gt7375p To: Doug Anderson Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=btissoir@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210113_100904_252545_1E1172FC X-CRM114-Status: GOOD ( 37.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Catalin Marinas , =?UTF-8?Q?Guido_G=C3=BCnther?= , Bjorn Andersson , Kai-Heng Feng , Will Deacon , Anson Huang , Masahiro Yamada , Vinod Koul , Linux ARM , "open list:HID CORE LAYER" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Jiri Kosina , Stephen Boyd , Hans de Goede , Rob Herring , Daniel Playfair Cal , Andrea Borgia , Max Krummenacher , Greg Kroah-Hartman , Dmitry Torokhov , LKML , Li Yang , Michael Walle , Xiaofei Tan , Jiri Kosina , Shawn Guo , Pavel Balan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jan 8, 2021 at 6:52 PM Benjamin Tissoires wrote: > > Hi Doug, > > On Wed, Jan 6, 2021 at 2:35 AM Doug Anderson wrote: > > > > Benjamin, > > > > On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson wrote: > > > > > > The goal of this series is to support the Goodix GT7375P touchscreen. > > > This touchscreen is special because it has power sequencing > > > requirements that necessitate driving a reset GPIO. > > > > > > To do this, we totally rejigger the way i2c-hid is organized so that > > > it's easier to jam the Goodix support in there. > > > > > > This series was: > > > - Tested on a device that uses normal i2c-hid. > > > - Tested on a device that has a Goodix i2c-hid device. > > > - Tested on an ACPI device, but an earlier version of the series. > > > > > > I believe the plan is for Benjamin to land the whole series. Will > > > said this about the arm64 defconfig change (and provided his Ack): > > > > ...there are a few things I really care about > > > > in defconfig (e.g. things like page size!), generally speaking we don't > > > > need to Ack everything that changes in there. > > > > > > > > That said, might be worth checking whether arm-soc have any defconfig > > > > changes queued in -next so you don't end up with conflicts. > > > > > > Changes in v8: > > > - Mark suspend/resume as static as per patches robot. > > > > > > Changes in v7: > > > - Rebase atop commit afdd34c5fa40 ("HID: i2c-hid: show the error ...") > > > > > > Changes in v6: > > > - ACPI probe function should have been "static" > > > - Don't export suspend/resume, just export dev_pm_ops from core. > > > - Fixed crash in ACPI module (missing init of "client") > > > - No need for regulator include in the core. > > > - Removed i2c_device_id table from ACPI module. > > > - Suspend/resume are no longer exported from the core. > > > > > > Changes in v5: > > > - Add shutdown_tail op and use it in ACPI. > > > - Added mention of i2c-hid in the yaml itself as per Rob. > > > - Adjusted subject as per Rob. > > > - i2chid_subclass_data => i2chid_ops. > > > - power_up_device => power_up (same with power_down). > > > - subclass => ops. > > > > > > Changes in v4: > > > - ("arm64: defconfig: Update config names for i2c-hid rejigger") new for v4. > > > - Fully rejigger so ACPI and OF are full subclasses. > > > - Totally redid based on the new subclass system. > > > > > > Changes in v3: > > > - Fixed compatible in example. > > > - Removed Benjamin as a maintainer. > > > - Rework to use subclassing. > > > - Updated description. > > > > > > Changes in v2: > > > - ("dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P") new in v2. > > > - Get timings based on the compatible string. > > > - Use a separate compatible string for this new touchscreen. > > > > > > Douglas Anderson (4): > > > HID: i2c-hid: Reorganize so ACPI and OF are separate modules > > > arm64: defconfig: Update config names for i2c-hid rejigger > > > dt-bindings: input: HID: i2c-hid: Introduce bindings for the Goodix > > > GT7375P > > > HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core > > > > I think this series is ready to land. The "defconfig" has a trivial > > conflict with commit 74b87103b3d0 ("arm64: defconfig: Enable HID > > multitouch") against linuxnext, but it's so simple that hopefully > > folks will be OK with that when it lands. > > > > Please let me know if there's anything else you need me to do. :-) > > > > I wanted to apply the series yesterday, but for these kinds of changes > I like giving it a spin on actual hardware. Turns out that my XPS-13 > can not boot to v5.11-rc2, which makes testing the new branch slightly > more difficult. > > I'll give it a spin next week, but I think I should be able to land it for 5.12. > > Regarding the defconfig conflict, no worries, we can handle it with > Stephen and Linus. > After 2 full kernel bisects (I messed up the first because I am an idiot and inverted good and bad after the first reboot), I found my culprit, and I was able to test the series today. The series works fine regarding enumeration and removing of devices, but it prevents my system from being suspended. If I rmmod i2c-hid-acpi, suspend works fine, but if it is present, it immediately comes back, which makes me think that something must be wrong. I also just reverted the series and confirmed that suspend/resume now works, meaning that patch 1/4 needs to be checked. Cheers, Benjamin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel