From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C018EC433EF for ; Mon, 20 Sep 2021 12:47:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DA7560F58 for ; Mon, 20 Sep 2021 12:47:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7DA7560F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UCpKSfQh3TFNvAFnWHW/+AqiB1xhyuVubGiuGgA/69Q=; b=O6kgrPAbD/Be6h f27sKUtYs68d1aW8Ui5anNvVP6bqlpDfKA6v6bg1nn+a2eIyzk8yjkCdKTcU4xc2y2/gFilhLhM52 IJFqlank9B+sEW8rrS26bEnEfVl6ARKx5tAYjnsc8d4gR3kCP3GQT3NwuzS7JcRwtJUrrl2m5hGlN Js/ZMu8uGBjypEfDJDY2t4NHxp1lZbUoIzpwP4GDwYc+4lh7YZtlfxvcNy5GnkDsz+1CJPXeLnABD XSzXU5xR3gvxnvhp2rUzgv6lazaECT7GTM7sSDuZ+OsWdoY96M1+hPOr0qo9DqhcI9R2LEbW/j6U6 YTu8dFwPHFf1Ko+lJRrw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSIfl-001dL6-C5; Mon, 20 Sep 2021 12:45:26 +0000 Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSIfc-001dIZ-AI for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 12:45:17 +0000 Received: by mail-lf1-x12f.google.com with SMTP id m3so65051594lfu.2 for ; Mon, 20 Sep 2021 05:45:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fwUX+Uyred0HTEGQWL9JhHRlrkwmUhERwhYxYKonkhk=; b=WmFcxwGgg4zy6KAkKfyGkYMonCTzwSi8SXcAnewI68odgEIUiGV+vJwYS7wBfPLXBq rXTiXgL51e3EAbw7chGUMqNa9iyR2fEQ1v8Q0AHi1r+Xb0qa0JP+LWrgjkva7vUbLmuD 6XngXmiLcaqx4BVbSzlc3idGBn949tbt/+kapaUibR8tTSpS/BwgeEYhrVtBCIry94+g uJN2bDk4LvvgLom+wrvMz+RJ6gwgVgKFLzAeDgD7HrKLzbWNnaZLYNGC5NVHzjgodf3b 91mv5T5iZW+yCmHJCKMw1APy2GqdJDzh9j1yNTndpSXQeiEie1G+m4cgOuU/gWSdEsOk W0jA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fwUX+Uyred0HTEGQWL9JhHRlrkwmUhERwhYxYKonkhk=; b=cOrIw42BkBnNa2KCUTkhMGFCS4PFQnFGteqFg7dKXtneLQtCWQ0vJOP+7gIcC62Svw 7EHvY1A8b5yZG2xAmGJh9LafKmbc9Pycsvgn8M5nHIsz0xM9qlT0STALRYAEK3X9L64T BFsOVRIiFF0AFD4R/HhMRiPFTCYxTLZV4lckpHQg06+Po7kQDoSY49upjygG5X9ZJqei c3pK9dcBMyWP1H6Oveebrhatb7H/Cxm1xhaw7e+Wwr45bgmx1hDN4MF11T4GIk9C4jJa 46FgLpar1ERkHn5BQydbzyNF1RCcvoaZtc9htfkIrhSBk/e9no81FpX9DBIQeY13b0nH axAQ== X-Gm-Message-State: AOAM533Gous5vf0iM9wGgVBaEiBom+dp06AE3DPJUUZi58hg1zNiXdhn D1UH01GAhW2h4KFAAklBh2DcDYPI7UAU3x+EAn8= X-Google-Smtp-Source: ABdhPJxS30HNPGmp2pgNzoPNm4MQjWJVcz7RLd04w/rtRYfkSjXSSXTpVU77p+nJRKUDafJy1fGSPnVRgxe8gFJseN8= X-Received: by 2002:a2e:a485:: with SMTP id h5mr23739576lji.345.1632141914800; Mon, 20 Sep 2021 05:45:14 -0700 (PDT) MIME-Version: 1.0 References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> In-Reply-To: From: Fabio Estevam Date: Mon, 20 Sep 2021 09:45:03 -0300 Message-ID: Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Sergey Shtylyov Cc: Sergey Shtylyov , Jens Axboe , linux-ide@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_054516_418874_797DBF21 X-CRM114-Status: GOOD ( 12.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sergey, On Sat, Sep 18, 2021 at 5:49 PM Sergey Shtylyov wrote: > > IMHO the current code is correct as-is. > > Not quite... I don't want to leave a bad example for the future driver authors. What should > I change in the patch description for the patch to become acceptable for you? Please see how the PCI subsystem has converted the handling of platform_get_irq(): https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5 Why does drivers/ata/ need to handle platform_get_irq() differently? I still don't see the need for changing drivers/ata/pata_imx.c in this aspect. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel