From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36563C433ED for ; Tue, 4 May 2021 11:15:53 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9A220611AE for ; Tue, 4 May 2021 11:15:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9A220611AE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9ThqX9gdkpEfpWZuTvlWG4rHYx/nVzlKyu14Jv6c9tU=; b=jk66Azh69NSyNRtHRnT+zwtFF mdaqq9lPlkoXQtN6U/xB4on6cBKHKBRQRPJHORPQc14Cv1rWtC9g9j8BZEE9NzMeuUG8TOc+HVnx7 6Vctjd+6aSofv7E1CnXZ5ywDN13/RL7Q91ciJpx9OQV3e7k6KSIlYe8+OsiovfW5MDtk8wpipVYlH CLbRO1r5/IYm+VaLZEzMFeMOGzZEMmW0jerIBdbkgYxhqzAK/p66BS8o3QeKg1XctxD042vQM/oC7 vRtikuUTD4aFD1jIVAREsOCEY9sa/+zTQBVjyX/BCMvHkC0Qm56ATy860pnlnM0Kh6VepH/+9/yMp Y0A2ByFzg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldt02-00G3Ir-0Q; Tue, 04 May 2021 11:13:58 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldszy-00G3Ic-BZ for linux-arm-kernel@desiato.infradead.org; Tue, 04 May 2021 11:13:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pB5B5vGNh7JfHcktCPrIN1oKnZroXbXhhazB4fhfugs=; b=1intm1VZqu4yKxAOHiciAZgRfM DvYXjjN5cPqP2YL9pX7b3HRE4J94DIi2YwNbvHIWCRAw7iyLahBEWGbBAgpJvCLl0+28JJDpZNc3L kG7ek6r22pwgPtDDZ3FojFP5nc4026xPbaiAZZPqc6C4MAe7zcVB7GPxu1reooT7AsE/waMz4Ojox Dy6sGzJ/giX/+HIPxvAWjH01XOmya0nphKndBDcQb+1TrsEgFsGoCCE6+D9dGxP54PTWLtYy+KRni zNEtNzawrVBhYudh1ah/1qIBb54Jvs9QBPm1tS366UyiCbCCVALnFOc8c9VSSWyTSr5/1Sn5BShvr OYQPQHkQ==; Received: from mail-lf1-x12f.google.com ([2a00:1450:4864:20::12f]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldszv-003vWe-KO for linux-arm-kernel@lists.infradead.org; Tue, 04 May 2021 11:13:53 +0000 Received: by mail-lf1-x12f.google.com with SMTP id 12so12644319lfq.13 for ; Tue, 04 May 2021 04:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pB5B5vGNh7JfHcktCPrIN1oKnZroXbXhhazB4fhfugs=; b=oNSPNdRDAz8qH2TjdHNrrOZBUXHAk1AW+N8S5H5ogqryWPMQi9KOocAneEwqXpTVXs ylKiI0NgwCfGfIoXSWwQdH4/AOTIOkG100mic0aTxvilePSoeJN+/tqw33mqhTyqhLWr pUexxleUqI4xWy9RMKG0S2uYGTthjNBPanajP/2M4fW96bUFRAtz+Rjr68oh8jc0+pt5 8GmTHFMcqtxZ43bdxsjmrIZYmXc4i2gyZrND40eG3FqwmI/m5l1lX+OYHNv8RK7HTqB+ C2QIafQceFabyo4Qh8nP1M+aTYm9WIZiL3QaA6EL6rkPIGen1YyNWFWhTXZTppFMas3/ l99A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pB5B5vGNh7JfHcktCPrIN1oKnZroXbXhhazB4fhfugs=; b=C2QOpBeQcWU6JGHOM4MTom/3mJzqO6BkaOqByZqcH5VlurpU7na69CKoowFUKCHkfz pO5+NzT3VWskSbfx7GHpOVYuxdLlWucBZR3dq06184PIDrR5f24dm/9ZksBu5GDmOz73 EdGMIJsZ7p7eTokCPANN9U8wMcJpHYmGpTgQn4lPHPaIbaeZawJYO7E0QlzW5qSvN2uj oER6waN8iEbfF47VDRw55p4PamUuifcJYsBFkZz1hvd1ibMdJdWONlbegLrpkApq37Fo Lq9WIhO/5q4tphm0jeQrfXoIyYeJ9Ahtb2xv8y7J/iaI0zL0EAL1WV5t+MmohFp8Dm7e DPxw== X-Gm-Message-State: AOAM5324+7auqXbSQp9ER0XP9oWOOcCEIF+Hobx/7ETBL8VzmzkTNK5d DobLRB2voGZvYbaIkaJk0wCGDsNl/5Py5eiRIvI= X-Google-Smtp-Source: ABdhPJwino+fPpYKDcNU5mJ2NOppWmanyJi54pdQ9f4VBW0ZqjvyHhzOM6wB4bkRrL+B73I+G1rGBG1feXbg2jYRiMQ= X-Received: by 2002:ac2:4308:: with SMTP id l8mr15510685lfh.223.1620126829233; Tue, 04 May 2021 04:13:49 -0700 (PDT) MIME-Version: 1.0 References: <20210430052746.10815-1-peng.fan@oss.nxp.com> <20210430052746.10815-5-peng.fan@oss.nxp.com> In-Reply-To: <20210430052746.10815-5-peng.fan@oss.nxp.com> From: Fabio Estevam Date: Tue, 4 May 2021 08:13:37 -0300 Message-ID: Subject: Re: [PATCH V2 4/4] soc: imx: Add blk-ctl driver for i.MX8MM To: "Peng Fan (OSS)" Cc: Rob Herring , Shawn Guo , Sascha Hauer , Sascha Hauer , NXP Linux Team , Philipp Zabel , Lucas Stach , Krzysztof Kozlowski , =?UTF-8?Q?Guido_G=C3=BCnther?= , Marek Vasut , Andrey Smirnov , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-kernel , Ping Bai , Schrempf Frieder , Adam Ford , Abel Vesa , Peng Fan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210504_041351_705197_7585B2B7 X-CRM114-Status: GOOD ( 12.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Peng, On Fri, Apr 30, 2021 at 1:56 AM Peng Fan (OSS) wrote: > +static int imx8mm_blk_ctl_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + const struct imx_blk_ctl_dev_data *dev_data = of_device_get_match_data(dev); > + struct regmap *regmap; > + struct resource *res; > + struct imx_blk_ctl *ctl; > + void __iomem *base; > + > + ctl = devm_kzalloc(dev, sizeof(*ctl), GFP_KERNEL); > + if (!ctl) > + return -ENOMEM; > + > + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + base = devm_ioremap_resource(dev, res); > + if (IS_ERR(base)) > + return PTR_ERR(base); > + > + regmap = devm_regmap_init_mmio(dev, base, &dev_data->config); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + ctl->regmap = regmap; > + ctl->dev = dev; > + atomic_set(&ctl->power_count, 0); > + > + ctl->num_clks = devm_clk_bulk_get_all(dev, &ctl->clks); > + if (ctl->num_clks < 0) > + return ctl->num_clks; > + > + dev_set_drvdata(dev, ctl); > + ctl->dev_data = of_device_get_match_data(dev); No need to call of_device_get_match_data() twice. You could do: ctl->dev_data = dev_data; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel