* [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option
@ 2021-04-02 7:53 Alexander Shiyan
2021-04-02 7:53 ` [PATCH RESEND 2/2] ARM: dts: imx6q-icore: " Alexander Shiyan
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
0 siblings, 2 replies; 5+ messages in thread
From: Alexander Shiyan @ 2021-04-02 7:53 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring, Alexander Shiyan
The operating mode is used for the AC97 interface only,
so lets drop the excess fsl,mode item from SSI node.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
index a4217f564a53..67b2dd510981 100644
--- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
@@ -225,7 +225,6 @@ &pcie {
};
&ssi1 {
- fsl,mode = "i2s-slave";
status = "okay";
};
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH RESEND 2/2] ARM: dts: imx6q-icore: Drop redundant "fsl, mode" option
2021-04-02 7:53 [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option Alexander Shiyan
@ 2021-04-02 7:53 ` Alexander Shiyan
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
1 sibling, 0 replies; 5+ messages in thread
From: Alexander Shiyan @ 2021-04-02 7:53 UTC (permalink / raw)
To: linux-arm-kernel
Cc: Shawn Guo, Sascha Hauer, Fabio Estevam, Rob Herring, Alexander Shiyan
The operating mode is used for the AC97 interface only,
so lets drop the excess fsl,mode item from SSI node.
Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
---
arch/arm/boot/dts/imx6qdl-icore.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-icore.dtsi b/arch/arm/boot/dts/imx6qdl-icore.dtsi
index 23c318d9636f..7ed853e33eca 100644
--- a/arch/arm/boot/dts/imx6qdl-icore.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-icore.dtsi
@@ -252,7 +252,6 @@ &pwm3 {
};
&ssi1 {
- fsl,mode = "i2s-slave";
status = "okay";
};
--
2.26.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option
2021-04-02 7:53 [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option Alexander Shiyan
2021-04-02 7:53 ` [PATCH RESEND 2/2] ARM: dts: imx6q-icore: " Alexander Shiyan
@ 2021-05-11 2:37 ` Shawn Guo
2021-05-13 15:12 ` Alexander Shiyan
1 sibling, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2021-05-11 2:37 UTC (permalink / raw)
To: Alexander Shiyan
Cc: linux-arm-kernel, Sascha Hauer, Fabio Estevam, Rob Herring
On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote:
> The operating mode is used for the AC97 interface only,
> so lets drop the excess fsl,mode item from SSI node.
Isn't it 'fsl,mode' meant for? I do not follow how it becomes excess.
- fsl,mode: The operating mode for the AC97 interface only.
"ac97-slave" - AC97 mode, SSI is clock slave
"ac97-master" - AC97 mode, SSI is clock master
Shawn
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
> arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> index a4217f564a53..67b2dd510981 100644
> --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> @@ -225,7 +225,6 @@ &pcie {
> };
>
> &ssi1 {
> - fsl,mode = "i2s-slave";
> status = "okay";
> };
>
> --
> 2.26.2
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
@ 2021-05-13 15:12 ` Alexander Shiyan
2021-05-13 19:51 ` Fabio Estevam
0 siblings, 1 reply; 5+ messages in thread
From: Alexander Shiyan @ 2021-05-13 15:12 UTC (permalink / raw)
To: Shawn Guo; +Cc: linux-arm-kernel, Sascha Hauer, Fabio Estevam, Rob Herring
On Tue, 11 May 2021 10:37:50 +0800
Shawn Guo <shawnguo@kernel.org> wrote:
These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
so AC97 parameters are not used in such cases.
> On Fri, Apr 02, 2021 at 10:53:54AM +0300, Alexander Shiyan wrote:
> > The operating mode is used for the AC97 interface only,
> > so lets drop the excess fsl,mode item from SSI node.
>
> Isn't it 'fsl,mode' meant for? I do not follow how it becomes excess.
>
> - fsl,mode: The operating mode for the AC97 interface only.
> "ac97-slave" - AC97 mode, SSI is clock slave
> "ac97-master" - AC97 mode, SSI is clock master
>
> Shawn
>
> >
> > Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> > ---
> > arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > index a4217f564a53..67b2dd510981 100644
> > --- a/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > +++ b/arch/arm/boot/dts/imx6qdl-icore-rqs.dtsi
> > @@ -225,7 +225,6 @@ &pcie {
> > };
> >
> > &ssi1 {
> > - fsl,mode = "i2s-slave";
> > status = "okay";
> > };
> >
> > --
> > 2.26.2
> >
--
Alexander Shiyan <shc_work@mail.ru>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option
2021-05-13 15:12 ` Alexander Shiyan
@ 2021-05-13 19:51 ` Fabio Estevam
0 siblings, 0 replies; 5+ messages in thread
From: Fabio Estevam @ 2021-05-13 19:51 UTC (permalink / raw)
To: Alexander Shiyan
Cc: Shawn Guo,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
Sascha Hauer, Rob Herring
Hi Alexander,
On Thu, May 13, 2021 at 12:12 PM Alexander Shiyan <shc_work@mail.ru> wrote:
>
> On Tue, 11 May 2021 10:37:50 +0800
> Shawn Guo <shawnguo@kernel.org> wrote:
>
> These machines use I2S mode (SND_SOC_DAIFMT_I2S), not AC97 (SND_SOC_DAIFMT_AC97),
> so AC97 parameters are not used in such cases.
Looking at imx6qdl-icore-rqs.dtsi, I see it uses the sgtl5000 audio codec.
To make the commit log clearer, you could also state that the board
uses the sgtl5000 codec connected via I2S.
Then it would become easier to understand why 'fsl,mode' could be removed.
Reviewed-by: Fabio Estevam <festevam@gmail.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-05-13 19:57 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-02 7:53 [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl, mode" option Alexander Shiyan
2021-04-02 7:53 ` [PATCH RESEND 2/2] ARM: dts: imx6q-icore: " Alexander Shiyan
2021-05-11 2:37 ` [PATCH RESEND 1/2] ARM: dts: imx6q-icore-rqs: Drop redundant "fsl,mode" option Shawn Guo
2021-05-13 15:12 ` Alexander Shiyan
2021-05-13 19:51 ` Fabio Estevam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).