From: Fabio Estevam <festevam@gmail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Gavin Schenk <g.schenk@eckelmann.de>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ARM: dts: Add devicetree for Eckelmann CI4x10
Date: Fri, 8 Feb 2019 08:48:02 -0200 [thread overview]
Message-ID: <CAOMZO5AODGe0MXme5+xN6y4cr6NqmM4Gz6=euZN=V7rL1At21g@mail.gmail.com> (raw)
In-Reply-To: <20190208093306.14316-1-u.kleine-koenig@pengutronix.de>
Hi Uwe,
On Fri, Feb 8, 2019 at 7:33 AM Uwe Kleine-König
<u.kleine-koenig@pengutronix.de> wrote:
> + reg_usb_h1_vbus: regulator-usb-h1-vbus {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_reg_usb_h1_vbus>;
> + compatible = "regulator-fixed";
> + regulator-name = "usb_h1_vbus";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + gpio = <&gpio3 31 0>;
Please use GPIO_ACTIVE_HIGH label for better readability.
> + enable-active-high;
> + };
> +
> + siox {
> + compatible = "eckelmann,siox-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_siox>;
> + din-gpios = <&gpio6 11 0>;
> + dout-gpios = <&gpio6 8 0>;
> + dclk-gpios = <&gpio6 9 0>;
> + dld-gpios = <&gpio6 10 0>;
Same here.
> + pinctrl_usbh1: usbh1grp {
> + fsl,pins = <
> + MX6QDL_PAD_EIM_D30__USB_H1_OC 0x80000000
No 0x80000000 please. Use the real IOMUX setting here so that we don't
rely on the bootloader.
> +&pcie {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_pcie>;
> + reset-gpio = <&gpio1 20 GPIO_ACTIVE_HIGH>;
I guess you meant GPIO_ACTIVE_LOW here instead?
The reset-gpio polarity is ignored by the imx6 PCI driver and assumed
to be active low unless the "reset-gpio-active-high" is present.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-02-08 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 16:49 [PATCH 1/2] ARM: dts: Add devicetree for Eckelmann CI4x10 Uwe Kleine-König
2019-01-11 16:49 ` [PATCH 2/2] ARM: imx_v6_v7_defconfig: Enable SIOX bus Uwe Kleine-König
2019-01-14 1:40 ` Shawn Guo
2019-02-05 6:17 ` Uwe Kleine-König
2019-02-11 1:28 ` Shawn Guo
2019-01-14 1:39 ` [PATCH 1/2] ARM: dts: Add devicetree for Eckelmann CI4x10 Shawn Guo
2019-02-05 8:18 ` Uwe Kleine-König
2019-02-08 9:33 ` [PATCH v2] " Uwe Kleine-König
2019-02-08 10:48 ` Fabio Estevam [this message]
2019-02-11 10:50 ` Uwe Kleine-König
2019-02-11 1:38 ` [PATCH 1/2] " Shawn Guo
2019-02-11 10:59 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5AODGe0MXme5+xN6y4cr6NqmM4Gz6=euZN=V7rL1At21g@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=fabio.estevam@nxp.com \
--cc=g.schenk@eckelmann.de \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=shawnguo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).