Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / Atom feed
From: Fabio Estevam <festevam@gmail.com>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: "Rob Herring" <robh@kernel.org>,
	kernel@puri.sm, "Yongcai Huang" <Anson.Huang@nxp.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	"Daniel Baluta" <daniel.baluta@nxp.com>,
	"Sascha Hauer" <s.hauer@pengutronix.de>,
	"Angus Ainslie (Purism)" <angus@akkea.ca>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	"Mark Brown" <broonie@kernel.org>,
	"NXP Linux Team" <linux-imx@nxp.com>,
	"Sascha Hauer" <kernel@pengutronix.de>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Shawn Guo" <shawnguo@kernel.org>,
	"Guido Günther" <agx@sigxcpu.org>,
	"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 1/3] arm64: dts: Add a device tree for the Librem 5 phone
Date: Thu, 20 Aug 2020 19:01:28 -0300
Message-ID: <CAOMZO5AZSu-_bKZ+_ym-Dtk7GCiHnR2cd7YZumOoE6Q6D6kB9A@mail.gmail.com> (raw)
In-Reply-To: <20200731082725.21878-1-martin.kepplinger@puri.sm>

Hi Martin,

This looks good.

Only some minor comments:

On Fri, Jul 31, 2020 at 5:28 AM Martin Kepplinger
<martin.kepplinger@puri.sm> wrote:

> +       sound {
> +               compatible = "simple-audio-card";
> +               pinctrl-0 = <&pinctrl_hp>;

Please pass pinctrl-names = "default"; prior to pinctrl-0. Please
check globally in this patch.

> +&ecspi1 {
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_ecspi1>;
> +       cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>;

This should be active low instead.

After 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors")
you should a similar message as in the kernel log:

flash@0 enforce active low on chipselect handle

> +       pinctrl_ecspi1: spi1grp {

ecspigrp {

> +       flash@53 {
> +               compatible = "lm3560";

This seems to be not documented. It also misses the vendor.

> +&i2c3 {
> +       clock-frequency = <387000>;
> +       pinctrl-names = "default";
> +       pinctrl-0 = <&pinctrl_i2c3>;
> +       status = "okay";
> +
> +       codec: audio-codec@1a {
> +               compatible = "wlf,wm8962";
> +               reg = <0x1a>; // 0x4a is the test address

Remove the comment, maybe?

Reviewed-by: Fabio Estevam <festevam@gmail.com>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

      parent reply index

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-31  8:27 Martin Kepplinger
2020-07-31  8:27 ` [PATCH v5 2/3] MAINTAINERS: Add Purism Librem 5 section to the list Martin Kepplinger
2020-07-31  8:27 ` [PATCH v5 3/3] dt-bindings: arm: fsl: Add the librem 5 phone Martin Kepplinger
2020-07-31 19:35   ` Rob Herring
2020-08-01 10:56     ` Martin Kepplinger
2020-08-13  6:51 ` [PATCH v5 1/3] arm64: dts: Add a device tree for the Librem " Martin Kepplinger
2020-08-20 22:01 ` Fabio Estevam [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOMZO5AZSu-_bKZ+_ym-Dtk7GCiHnR2cd7YZumOoE6Q6D6kB9A@mail.gmail.com \
    --to=festevam@gmail.com \
    --cc=Anson.Huang@nxp.com \
    --cc=agx@sigxcpu.org \
    --cc=angus@akkea.ca \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel@pengutronix.de \
    --cc=kernel@puri.sm \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.kepplinger@puri.sm \
    --cc=mchehab@kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-ARM-Kernel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/0 linux-arm-kernel/git/0.git
	git clone --mirror https://lore.kernel.org/linux-arm-kernel/1 linux-arm-kernel/git/1.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-arm-kernel linux-arm-kernel/ https://lore.kernel.org/linux-arm-kernel \
		linux-arm-kernel@lists.infradead.org
	public-inbox-index linux-arm-kernel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.infradead.lists.linux-arm-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git