From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802C3C433DF for ; Thu, 20 Aug 2020 22:03:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 46D972087D for ; Thu, 20 Aug 2020 22:03:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="fKZSspx3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hB8rGo68" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 46D972087D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=WGdeZNFr9J2QvsAqmnuhxmGUH2cKrsJMHq6q7+7TSBQ=; b=fKZSspx3UwQIw12AnJBsMupe6 k3GeTOUsI6cY8h/tCsJ1XDXs9/vxOW7sQVs922wc0opTrqu7u0IIT4aQWticfmDAwwlc7UjF+Xekd zgj05LaYBK8tveiZN3BNy7yC9CweSJr2Sctqx0k0qutqBqDAsZ84UsZlO2QiWNSENfN1PioHZFMZq QPotPbF34byo3Y0GxXKEYg8oGccbmWZ3c0CmB24oCGlEU4RbwOa3GzOA6y98O8HEcTsXLqFU1h9Mh QdhOIx3STbpBKEnojm8tMOiFzwaaAY1SBFZyLewtF5R6c0thfvKjD1erT3DbWFe+2KEMtwDyGPAIY t+HNCfi2w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8sd0-0001UZ-Kv; Thu, 20 Aug 2020 22:01:46 +0000 Received: from mail-lj1-x242.google.com ([2a00:1450:4864:20::242]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k8scy-0001Tb-Cs for linux-arm-kernel@lists.infradead.org; Thu, 20 Aug 2020 22:01:45 +0000 Received: by mail-lj1-x242.google.com with SMTP id w25so3750511ljo.12 for ; Thu, 20 Aug 2020 15:01:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FgcODlr4E6A8//aA0EDpJkZYU4kK0bAL6cRITsU0h1Q=; b=hB8rGo68iZ4Q840IFDbTgoLOYJCefYtSAozw+yxtnnS1+Rtcz/PO7yqg9BMWStJNsj ty0gCe5sGEiYAj8SwxW4kJUDoy25i6BeVCfuu+oQMSCmpg16MbKF/ZgaDQxhXjXvbyFU vmZVavaeev2BDBDAyhAoJzv0UqSRUaW6ty5tNcq84vEzJnUMBPKInF/9MV/EVtWTeFu7 anZD0DA8cl8mRXEprmonP/98+NGLW/TZmL7WLaAKTmh29jTD+rcs5kckPFTwjA/d7nFe mTsT/r93VMOU6vegFljRKfjU1SQltt3bgqfaHvSo5KQ9IchwG8OREw+j/rZ+Hzpo+853 nlfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FgcODlr4E6A8//aA0EDpJkZYU4kK0bAL6cRITsU0h1Q=; b=OvpK2bb0ybUril//wOYaxgi1iiZKAjZ+IDGk7zazu1yuHp9CyyN3wGeWM8S9nXcSZc sp+7JjzOG4rMAeozlTWrNUh28sH6k/kRlzZZ29Fv2+24eGKD8BenwKkRphqKgHmpZo0+ krqN2iJKM5946Yc+Mdj5Gm3I/HCUzTb/xoSQT2LLm21L2oi8W3cX1VQRWTbWlS8jQ9Ar F+0ZmAvPwbRzDJdFsTE8VPDJ/hSonnjefvDcjAXRtU7OV4iE09aZkCGoOWg3t33/xE0Z wqleDNQODbo25oku2y3vqwp5PVreaiBoLD5Mt2vj2vBRPk3oKRp4cRoCaFkRBcZieo+f ynjQ== X-Gm-Message-State: AOAM5322X3I3dzqvYudx7wnVj5Csp+1FX4BR7FbIz5Dzm7vLU3fwxAOV YsBxIGC6W6ivp2n+O31pfLT6GWEy9XZORkEeAzk= X-Google-Smtp-Source: ABdhPJysn/j9f8dyPXMiSs+Jk6L+kEp2L+3crAXd2jTQ6PrUbFIR18fsGNBqdWLKXdN0qOPBiSzeaeRG7wQIJJalAYo= X-Received: by 2002:a2e:1417:: with SMTP id u23mr42773ljd.44.1597960900155; Thu, 20 Aug 2020 15:01:40 -0700 (PDT) MIME-Version: 1.0 References: <20200731082725.21878-1-martin.kepplinger@puri.sm> In-Reply-To: <20200731082725.21878-1-martin.kepplinger@puri.sm> From: Fabio Estevam Date: Thu, 20 Aug 2020 19:01:28 -0300 Message-ID: Subject: Re: [PATCH v5 1/3] arm64: dts: Add a device tree for the Librem 5 phone To: Martin Kepplinger X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200820_180144_453343_93E846E9 X-CRM114-Status: GOOD ( 13.55 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , kernel@puri.sm, Yongcai Huang , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Daniel Baluta , Sascha Hauer , "Angus Ainslie \(Purism\)" , linux-kernel , Mark Brown , NXP Linux Team , Sascha Hauer , Mauro Carvalho Chehab , Shawn Guo , =?UTF-8?Q?Guido_G=C3=BCnther?= , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Martin, This looks good. Only some minor comments: On Fri, Jul 31, 2020 at 5:28 AM Martin Kepplinger wrote: > + sound { > + compatible = "simple-audio-card"; > + pinctrl-0 = <&pinctrl_hp>; Please pass pinctrl-names = "default"; prior to pinctrl-0. Please check globally in this patch. > +&ecspi1 { > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_ecspi1>; > + cs-gpios = <&gpio5 9 GPIO_ACTIVE_HIGH>; This should be active low instead. After 8cdcd8aeee28 ("spi: imx/fsl-lpspi: Convert to GPIO descriptors") you should a similar message as in the kernel log: flash@0 enforce active low on chipselect handle > + pinctrl_ecspi1: spi1grp { ecspigrp { > + flash@53 { > + compatible = "lm3560"; This seems to be not documented. It also misses the vendor. > +&i2c3 { > + clock-frequency = <387000>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_i2c3>; > + status = "okay"; > + > + codec: audio-codec@1a { > + compatible = "wlf,wm8962"; > + reg = <0x1a>; // 0x4a is the test address Remove the comment, maybe? Reviewed-by: Fabio Estevam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel