From: Fabio Estevam <festevam@gmail.com>
To: Steffen Trumtrar <s.trumtrar@pengutronix.de>
Cc: "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway
Date: Tue, 12 Jan 2021 10:29:16 -0300 [thread overview]
Message-ID: <CAOMZO5CeqJWk2rEDBFT5FycQcGmifOc0RHcrk8bsRb=2hK5S7g@mail.gmail.com> (raw)
In-Reply-To: <20200714051140.8090-4-s.trumtrar@pengutronix.de>
Hi Steffen,
On Tue, Jul 14, 2020 at 2:12 AM Steffen Trumtrar
<s.trumtrar@pengutronix.de> wrote:
> + memory {
memory@80000000 to avoid dtc W=1 warning.
> +&ecspi2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi2>;
> + num-chipselects = <1>;
This property is not used for spi-imx.
> + status = "okay";
> +
> + flash: m25p80@0 {
Node names should be generic:
spi-flash@0
> +/* Expansion slot */
> +&ecspi3 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_ecspi3>;
> + num-chipselects = <1>;
> + status = "okay";
> +};
> +
> +&fec2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_enet2>,
> + <&pinctrl_mdio>,
> + <&pinctrl_rmii_phy>;
> + /* set the enet_ref_clk and enet_out with a 50MHz clock */
> + assigned-clocks = <&clks IMX7D_ENET_PHY_REF_ROOT_DIV>;
> + assigned-clock-parents = <&clks IMX7D_PLL_ENET_MAIN_100M_CLK>;
> + assigned-clock-rates = <50000000>;
> + clocks = <&clks IMX7D_ENET2_IPG_ROOT_CLK>,
> + <&clks IMX7D_ENET_AXI_ROOT_CLK>,
> + <&clks IMX7D_ENET2_TIME_ROOT_CLK>,
> + <&clks IMX7D_PLL_ENET_MAIN_50M_CLK>,
> + <&clks IMX7D_ENET2_REF_ROOT_DIV>;
> + clock-names = "ipg", "ahb", "ptp",
> + "enet_clk_ref", "enet_out";
> + phy-handle = <ðphy1>;
> + phy-mode = "rmii";
> + phy-reset-gpios = <&gpio2 27 GPIO_ACTIVE_LOW>;
This property is considered obsolete.
Please describe the Ethernet PHY reset inside the ethernet-phy nodes as per:
Documentation/devicetree/bindings/net/ethernet-phy.yaml
> + pcf85363: pcf85363@51 {
rtc@51
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-12 13:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 5:11 [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Steffen Trumtrar
2020-07-14 5:11 ` [PATCH v2 2/4] dt-bindings: Add DS2482 as trivial device Steffen Trumtrar
2020-10-26 1:58 ` Shawn Guo
2020-07-14 5:11 ` [PATCH v2 3/4] dt-bindings: Add vendor prefix for IoTmaxx GmbH Steffen Trumtrar
2020-10-26 1:59 ` Shawn Guo
2020-07-14 5:11 ` [PATCH v2 4/4] ARM: imx7: add support for iotmaxx gateway Steffen Trumtrar
2020-10-13 9:45 ` Steffen Trumtrar
2021-01-12 12:59 ` Steffen Trumtrar
2021-01-12 13:29 ` Fabio Estevam [this message]
2021-01-12 15:30 ` Ahmad Fatoum
2020-08-17 7:24 ` [PATCH v2 1/4] ARM: imx7d: add enet2 clk sel Shawn Guo
2020-08-24 9:46 ` Steffen Trumtrar
2020-10-26 1:57 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5CeqJWk2rEDBFT5FycQcGmifOc0RHcrk8bsRb=2hK5S7g@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.trumtrar@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).