From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7380AC433F5 for ; Mon, 20 Sep 2021 12:54:45 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 36811610A0 for ; Mon, 20 Sep 2021 12:54:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 36811610A0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nRjObz5Hq0dLoVMuFjfuiJ47jnoDkzz6kmr4ZIxZwLw=; b=nbeu4FrhkVimjA sDXCHjOL0L22yW1ovcUorL4Gih1iIYUW8wzsPoZCvxmB0GTsezFjDmrxFWP0+JZU8c9l2R2p6eFFD auAO7003PqTrX+SLAk0QOTsHAHDwPMk5Tg8wlJs0xchiH2wm9d0qk6qjsK9em/BaFS7fEC0oUw8Zw BNh5jN1RnZLos420F7fEmUJHgiOZJr9gKNSFPn0BnMNuOgOKTuAjI9ucaPzfeXEG0PoNMXgtoBjbU zkDTjuea73LB24r86rAbGFwAMxKfeaOCtpeAJrjvcuS82BMrbkBLDjuHkgmNdpg+RCGCy//UuOTR3 Ld5q2Syq9+FZOcEMLAcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSIms-001fWN-18; Mon, 20 Sep 2021 12:52:46 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSImj-001fUX-Nz for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 12:52:39 +0000 Received: by mail-lf1-x132.google.com with SMTP id g1so67914628lfj.12 for ; Mon, 20 Sep 2021 05:52:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sQ7i2scGcmG9OZhSR8ZJ1VYth2bzV/cPe4QmSweRP9k=; b=OezVhePJPTkBqqeJMkbleTtgmKQsVNs8o0qLVeDYNrqY6rbgHix0Vwdxer4NENbaOg 9aLiuC6Ie8UUCMoaj7Wab22Ph+ZmyoYfy+vhkz67sXupPrnWLRNQg0XyqznPwWmerWIM djtQlLy2u7hwMaGtc+VqIADibwKSIurCmYlsLCedk/Xde2Wtqt2CTzp47YwhwwgxjUnQ dp/CoeAOs5Ch4YEOF+vEcWro1y2sFw1Y32+dy7XUd31Xb/YFiJou/y5Epq6+O40S0Jep XtRuWfHnicphhLr7Q6r26AdwEW7mdMQTMHSLTHfktdGFlSmn+3podChBaDx1x8d97Uk/ kLpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sQ7i2scGcmG9OZhSR8ZJ1VYth2bzV/cPe4QmSweRP9k=; b=MXlTWqAVc9aqNh+FoGsgwgLFCOfW0s9Eoolwsmfitkt4X33SMR8wKpgXs4a6Phga62 jxymVJlAyVMTa9gPH0hDWO7XmXlvd9MepH0uXA7wxPcKzBONuGtmcEJC7ZyjZ2DK5geY QnZiq6uUyLvo/OGK2P6BObffpEjhTdQ5Ey2Y6c7eoIgwcAKhGe9K1wgw5XTYQUzED9d2 3druhxDLsrDLUc8vokZhbD1wcklsfFFhnyoZlduYRxFzm3npCWVLhlURtRF/Kdzp0uvg danXw/j1AKqFW7DaiI6lJYk8FJp/XarLOfrC1AB3BUSCw5UkWv4VDEFu6XXy2nh0Lzfh N92Q== X-Gm-Message-State: AOAM5307VfFfXBnIqcLrsKb6yoC2zM77yMsaBAHAn//YMHUNV1QrBoPb eHS5ClTx1THWed1hN/ZWko4BmqI4287h20Fmqag= X-Google-Smtp-Source: ABdhPJxF7TPBPP3qkrH0O/T2bKoDx1GstKrtVx2SX3VDm7/L/F2C4u4LT6WPmctDw41Y+4ac4WP4rmjx3SsuPtCl4sc= X-Received: by 2002:a2e:5815:: with SMTP id m21mr14891308ljb.95.1632142356294; Mon, 20 Sep 2021 05:52:36 -0700 (PDT) MIME-Version: 1.0 References: <2e552c36-84a5-a642-a8f0-1395f77a1a6a@omprussia.ru> In-Reply-To: From: Fabio Estevam Date: Mon, 20 Sep 2021 09:52:25 -0300 Message-ID: Subject: Re: [PATCH 4/4] pata_imx: deny IRQ0 To: Sergey Shtylyov Cc: Sergey Shtylyov , Jens Axboe , linux-ide@vger.kernel.org, Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_055237_859548_3687C423 X-CRM114-Status: GOOD ( 15.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 20, 2021 at 9:45 AM Fabio Estevam wrote: > > Hi Sergey, > > On Sat, Sep 18, 2021 at 5:49 PM Sergey Shtylyov wrote: > > > > IMHO the current code is correct as-is. > > > > Not quite... I don't want to leave a bad example for the future driver authors. What should > > I change in the patch description for the patch to become acceptable for you? > > Please see how the PCI subsystem has converted the handling of > platform_get_irq(): > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=0584bff09629666eea97c7ac428e55b00df211f5 > > Why does drivers/ata/ need to handle platform_get_irq() differently? > > I still don't see the need for changing drivers/ata/pata_imx.c in this aspect. Also, please check this commit too: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=v5.15-rc2&id=a85a6c86c25be2d2a5f9c31491f612ce0edc7869 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel