From: Fabio Estevam <festevam@gmail.com>
To: Sven Van Asbroeck <thesven73@gmail.com>
Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, Fugang Duan <fugang.duan@nxp.com>,
netdev <netdev@vger.kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
NXP Linux Team <linux-imx@nxp.com>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Jakub Kicinski <kuba@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref
Date: Thu, 2 Jul 2020 19:29:29 -0300 [thread overview]
Message-ID: <CAOMZO5DxUeXH8ZYxmKynA7xO3uF6SP_Kt-g=8MPgsF7tqkRvAA@mail.gmail.com> (raw)
In-Reply-To: <20200702175352.19223-3-TheSven73@gmail.com>
Hi Sven,
On Thu, Jul 2, 2020 at 2:53 PM Sven Van Asbroeck <thesven73@gmail.com> wrote:
> + /*
> + * On imx6 plus, enet_ref from ANATOP/CCM can be internally routed to
> + * be the PTP clock source, instead of having to be routed through
> + * pads.
> + */
> + if (of_machine_is_compatible("fsl,imx6qp")) {
> + clksel = of_property_read_bool(np, "fsl,ptpclk-bypass-pad") ?
> + IMX6Q_GPR5_ENET_TXCLK_SEL_PLL :
> + IMX6Q_GPR5_ENET_TXCLK_SEL_PAD;
> + regmap_update_bits(gpr, IOMUXC_GPR5,
> + IMX6Q_GPR5_ENET_TXCLK_SEL_MASK, clksel);
> + }
With the device tree approach, I think that a better place to touch
GPR5 would be inside the fec driver.
You can refer to drivers/pci/controller/dwc/pci-imx6.c and follow the
same approach for accessing the GPR register:
...
/* Grab GPR config register range */
imx6_pcie->iomuxc_gpr =
syscon_regmap_lookup_by_compatible("fsl,imx6q-iomuxc-gpr")
For the property name, what about fsl,txclk-from-pll?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-02 22:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 17:53 [PATCH v5 1/3] ARM: imx: mach-imx6q: Search for fsl, imx6q-iomuxc-gpr earlier Sven Van Asbroeck
2020-07-02 17:53 ` [PATCH v5 2/3] dt-bindings: fec: add fsl, ptpclk-bypass-pad boolean property Sven Van Asbroeck
2020-07-02 17:53 ` [PATCH v5 3/3] ARM: imx6plus: optionally enable internal routing of clk_enet_ref Sven Van Asbroeck
2020-07-02 22:29 ` Fabio Estevam [this message]
2020-07-03 0:50 ` Sven Van Asbroeck
2020-07-03 2:01 ` [EXT] " Andy Duan
2020-07-04 14:08 ` Sven Van Asbroeck
2020-07-05 14:45 ` [EXT] " Andy Duan
2020-07-05 15:34 ` Sven Van Asbroeck
2020-07-06 5:30 ` Andy Duan
2020-07-06 13:46 ` Fabio Estevam
2020-07-06 14:58 ` Sven Van Asbroeck
2020-07-06 14:59 ` Sven Van Asbroeck
2020-07-07 3:38 ` Andy Duan
2020-07-07 15:21 ` Sven Van Asbroeck
2020-07-08 5:16 ` Andy Duan
2020-07-06 14:53 ` Sven Van Asbroeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOMZO5DxUeXH8ZYxmKynA7xO3uF6SP_Kt-g=8MPgsF7tqkRvAA@mail.gmail.com' \
--to=festevam@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=fugang.duan@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=thesven73@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).