From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FA39C49361 for ; Mon, 21 Jun 2021 08:24:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E4246109F for ; Mon, 21 Jun 2021 08:24:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3E4246109F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=20vaYsXIqXCqfASua5/bFrUHZPN/YZyBe/YaGXZ7EJg=; b=mFrehkaaw8EqeG YD/t5UrDH8GdzbaboFx+3LSK4PO4At5hPV964a7/eyT7n+FhlDhJK1O2q/ziMRcy7vpwcy+5jCMYK +wqQmbv3SlYQjd2v4ekuL2dlhQ3KphKAiemaBJMQ0ZNzrJtiD9WGbG6zO9xC2qpE7SXpKlWAxISzJ JrYrZGk8A9x3VS+S6Q1eJSJglulxRSZrqE+eyUHdVuYn86ZjWRoim7MEJ19GS6PUho+1Ds+o8rBH+ wZ6EW5dY3ksDZ+717xdRUKnEBMfLoY74BKtclIJTHZZDbKXaQsP0HsYtdNSAmmxU58++tH29O4mLK 1jJX7Hb8hbT4J8Og/Cyg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvFCM-002fEp-Kj; Mon, 21 Jun 2021 08:22:26 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lvFCI-002fB1-Fu for linux-arm-kernel@lists.infradead.org; Mon, 21 Jun 2021 08:22:23 +0000 Received: by mail-pj1-x102f.google.com with SMTP id h16so9496581pjv.2 for ; Mon, 21 Jun 2021 01:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gqd3O4ne1dNUetj8IOBDVEDjIC1vEw62dq7UiJ0rgTM=; b=P5DIJiYcaFv2PfJZNbczzivYyCCQ9u7w3i/vH90+0mTyRL8r0HLL2Pd7w/RbaVUAZG ucSIEnU4YgKWml+P3z4z4Gc3qujHL7jSo/JfLdH1jGjlMXfQuZNoWbPF8gWWqly7PDSa aFaROk04qJwKB56IRCweNyqXZCaqIPlAP9CI0u2tm3mxZNnw6exFVtzEOvUvaBXwBqxb wu+hLeum0CH3GVeEAtUJ81WGcSMx8vXl7oEL3V1+mrQEaS/JtjL/5vYj5T+BtAzizdL4 toDaLFGkRDYIHX8yL7Dfdm7yUra6/gzzVOpQGabfKhy1gGKPie9uDp3UxOKTmuJIgiby d1vA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gqd3O4ne1dNUetj8IOBDVEDjIC1vEw62dq7UiJ0rgTM=; b=CNnQzBD8J2hKan5KehO1zB4zT478+ZqFSOGZ+Kl+spMICfnLlh9qC6hAuF+zIa8uYp KpST7CGvMFgZmqMAvPVN8gFbeU1cM58Q0OrnHRwy4cxfljYOTzbTHcuQDRNGzAi0G8LC PL59CNPfKqpN8RyrjpTT9+bx8ltSB9Xkl7rouERRko2EgU31wNdt07fZJ4RUr/6jsUUw dm+cHr9KgBTOcXZBZOh9UGh5woeSMWlCwdew62Uall+FFpUcpfdBtdEU8X7kd7qzXYIj fuvF2sfV2+qBcS6DpACLyCobn8+9nKeQqQ1fSQx6MMlxbAzlUm/3I1nvRm+UI8yghIg1 SzwA== X-Gm-Message-State: AOAM5306S6FKQZINZBbiP6RKoc3LBNCsOH1xZyfon90huKr3X2LnNhJf Q9h6dDoCKZBIIZEJPtuCPUhM+b6X0PIWFMvrZsh2hg== X-Google-Smtp-Source: ABdhPJwm9dF6HvcKy6dVJDn+aQMg1MuHWfIcw7Np2YEgLInhtBmcV4IDOEML8eNuAt0mxQzlgpuCNXuEVLpBe/VG5ww= X-Received: by 2002:a17:90b:300c:: with SMTP id hg12mr28711402pjb.46.1624263734484; Mon, 21 Jun 2021 01:22:14 -0700 (PDT) MIME-Version: 1.0 References: <20210528161552.654907-1-leo.yan@linaro.org> <5cf3effb-fccc-9385-6328-6d1e2e5ccdf3@arm.com> <20210612032721.GB36748@leoy-ThinkPad-X240s> In-Reply-To: <20210612032721.GB36748@leoy-ThinkPad-X240s> From: Denis Nikitin Date: Sun, 20 Jun 2021 22:21:57 -1000 Message-ID: Subject: Re: [PATCH v1 0/3] coresight: Fix for snapshot mode To: Leo Yan Cc: Suzuki K Poulose , Arnaldo Carvalho de Melo , Mathieu Poirier , Mike Leach , Alexander Shishkin , John Garry , Will Deacon , Peter Zijlstra , Ingo Molnar , Jiri Olsa , Namhyung Kim , Daniel Kiss , Coresight ML , linux-arm-kernel , Linux Kernel Mailing List , linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210621_012222_571174_EDBC3947 X-CRM114-Status: GOOD ( 25.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Leo, On Fri, Jun 11, 2021 at 5:27 PM Leo Yan wrote: > > On Fri, Jun 11, 2021 at 01:31:41AM -0700, Denis Nikitin wrote: > > Hi Suzuki, > > > > On Thu, Jun 10, 2021 at 9:04 AM Suzuki K Poulose wrote: > > > > > [...] > > > > > > Are you able to confirm if the patch 3 alone fixes the above issue ? > > > I am not convinced that Patch 1 is necessary. > > > > > > > Yes. "perf cs-etm: Remove callback cs_etm_find_snapshot()" alone fixes > > the issue. > > Based on current testing result, we should give high priority for > patches 2 and 3. > > The patch 1 is controversial for how to handle the trace data kept > in multiple AUX buffers; essentially it's up to how we understand the > snapshot definition. I confirmed Intel-PT and CoreSight have the same > behaviour for capturing trace data from multiple AUX ring buffers when > snapshot occurs. > > I'd like to leave patch 1/3 out, and resend it if we get conclusion. > At the meantime, @Denis, if you have observed any profiling result > (or profiling quality) difference caused by patch 1, the feedback would > be very valuable. I evaluated AutoFDO profiles with benchmarks but I was only focused on the system-wide mode. And as I understood patch 1 fixes the issue in non system-wide mode. Currently I'm OoO so I won't be able to do further evaluation. - Denis > > > Thanks a lot for Denis' testing and insight review from Suzuki! > > Leo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel