linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Olof Johansson <olof@lixom.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	ARM SoC <arm@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	"linux-alpha@vger.kernel.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [GIT PULL 1/4] ARM: SoC platform updates
Date: Thu, 16 May 2019 10:10:41 -0700	[thread overview]
Message-ID: <CAOesGMgQ9kF08PDzA3LSjsXt-ETB8vAnqo2EjtbKEMJ5UrnJnw@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a27zgq3c_iWHVfypAc-hLag06Bs=Q2D7bn4i4nVfPQSyw@mail.gmail.com>

On Thu, May 16, 2019 at 8:53 AM Arnd Bergmann <arnd@arndb.de> wrote:
>
> On Thu, May 16, 2019 at 5:34 PM Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
> >
> > On Wed, May 15, 2019 at 11:43 PM Olof Johansson <olof@lixom.net> wrote:
> > >
> > > SoC updates, mostly refactorings and cleanups of old legacy platforms.
> > > Major themes this release:
> >
> > Hmm. This brings in a new warning:
> >
> >   drivers/clocksource/timer-ixp4xx.c:78:20: warning:
> > ‘ixp4xx_read_sched_clock’ defined but not used [-Wunused-function]
> >
> > because that drivers is enabled for build testing, but that function
> > is only used under
> >
> >   #ifdef CONFIG_ARM
> >         sched_clock_register(ixp4xx_read_sched_clock, 32, timer_freq);
> >   #endif
> >
> > It's not clear why that #ifdef is there. This driver only builds
> > non-ARM when COMPILE_TEST is enabled, and that #ifdef actually breaks
> > that build test.
> >
> > I'm going to remove that #ifdef in my merge, because I do *not* want
> > to see new warnings, and it doesn't seem to make any sense.
> >
> > Maybe that's the wrong resolution, please holler and let me know if
> > you want something else.
>
> As far as I can tell, that is the best fix, thanks for the cleanup!

Yeah, this was entirely on me -- it was found and fixed on linux-next,
and Linus Walleij sent patches. However, as I was staging these pull
requests, I applied them to a branch of fixes that I'm collecting for
later this week instead of on top of the one I was sending.

Thanks for fixing it up.


-Olof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-05-16 17:11 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-16  6:43 [GIT PULL 0/4] ARM: SoC contents for 5.2 merge window Olof Johansson
2019-05-16  6:43 ` [GIT PULL 1/4] ARM: SoC platform updates Olof Johansson
2019-05-16 15:33   ` Linus Torvalds
2019-05-16 15:53     ` Arnd Bergmann
2019-05-16 17:10       ` Olof Johansson [this message]
2019-05-20 21:56         ` Linus Walleij
2019-05-16 15:59     ` Marc Gonzalez
2019-05-16 16:34       ` Linus Torvalds
2019-05-16 16:40   ` pr-tracker-bot
2019-05-16  6:43 ` [GIT PULL 2/4] ARM: Device-tree updates Olof Johansson
2019-05-16 16:40   ` pr-tracker-bot
2019-05-16  6:43 ` [GIT PULL 3/4] ARM: SoC-related driver updates Olof Johansson
2019-05-16 16:26   ` Linus Torvalds
2019-05-16 16:35     ` Patrick Venture
2019-05-16 17:39     ` Olof Johansson
2019-05-16 16:40   ` pr-tracker-bot
2019-05-16  6:43 ` [GIT PULL 4/4] ARM: SoC defconfig updates Olof Johansson
2019-05-16 16:40   ` pr-tracker-bot
  -- strict thread matches above, loose matches on Subject: below --
2019-12-05 18:04 [GIT PULL 1/4] ARM: SoC platform updates Olof Johansson
2019-12-05 20:45 ` pr-tracker-bot
2019-07-19 23:54 [GIT PULL 0/4] ARM: SoC contents for 5.3 merge window Olof Johansson
2019-07-19 23:54 ` [GIT PULL 1/4] ARM: SoC platform updates Olof Johansson
2019-07-20  0:30   ` pr-tracker-bot
2018-12-31 21:46 [GIT PULL 0/4] ARM: SoC changes for v4.21 Olof Johansson
2018-12-31 21:46 ` [GIT PULL 1/4] ARM: SoC platform updates Olof Johansson
2019-01-01  1:45   ` pr-tracker-bot
2018-06-12  0:01 [GIT PULL 0/4] ARM: SoC updates Olof Johansson
2018-06-12  0:01 ` [GIT PULL 1/4] ARM: SoC platform updates Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAOesGMgQ9kF08PDzA3LSjsXt-ETB8vAnqo2EjtbKEMJ5UrnJnw@mail.gmail.com \
    --to=olof@lixom.net \
    --cc=arm@kernel.org \
    --cc=arnd@arndb.de \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).