From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D792BECAAA1 for ; Tue, 13 Sep 2022 02:35:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8RFJOZGtplBum18XNHd7W6wl0AK/KS8VtVHFYclyGMg=; b=FOFn7i93z9nOXk 1uDFtTmF4M7wzA//yuRDn3ajGl7wXvj9Gcgf8q/sVierfnxrp15tC8Lo34Gl1/sxseWB0//GUUxDr gUf4QGsiDFs4zJCXHRexduXRkWya5vNxPNPF/ybs3dCBI9yGjMXx/F++GVpqSMyz5X4/CCWKYSXF2 IFMGjjq9iVM//E9xdkyDkwJvJGh4f1YQ3gci2mKEzGHHEmj7jye+VqLr3rCayPftRD7nxt4iqSeeK 66OYZohRslfyk59T6Fz8HswJTT0AZ6Wp+59jlJ26FHtHmpXZloAgjZ0vS5h24WmrfG5amKnwx0lRa X2Q/DPr6ZCUNIVXbEDjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXvki-000LuQ-Uc; Tue, 13 Sep 2022 02:34:21 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXvke-000Lp7-Fw for linux-arm-kernel@lists.infradead.org; Tue, 13 Sep 2022 02:34:19 +0000 Received: by mail-ej1-x633.google.com with SMTP id y17so19286812ejo.6 for ; Mon, 12 Sep 2022 19:34:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5K5C19ucjIxirrTVwdTH8e1rDFFb25mycghKPQV6gu0=; b=vdpA6/PCDhdOn4FHZdxwU6muy2HDRh6oIz4AgmwFHsQZn4+Voak+h+r/3WyHUZSDy2 MT1zLdA1+Va/7dTKENil5CMjiiM5w3L/1bYVJmXlMmeJ2WTtcC09uf4rA2E9YhncIrnE x3eniFG3ljQmdA8u1Z715pWgOVFldMnB0uCJV6iBid35EBecyOnqU6C1vi2PNe7J911J b6Ga8Al/azf84L27DOL0pVQUZwuJhAicRv9wmua1tDiX8Et9brdlVI8nI7oEKCTyVloU xuYjwAnYMhQV3lFt19A/9eMqZ3LC/267oiEotbje/X0XktdF42H1NfJoncxojN7JAP74 OsZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5K5C19ucjIxirrTVwdTH8e1rDFFb25mycghKPQV6gu0=; b=MAP6FCXZa3xgIbhSbDaiULp9Gu83eV6SbKy1IwZHlq4WGtM2ITUQUCTlWrQxw8cNn9 VdVcdZh/4Nn7y68bLSxZa6PCQIw4yOfJM0RhLYgquVzBW6Ef6aXXXVGCWtlNGxTiZ0Ue sZmKK11U+0/5E+0DIom2Fnl+p6c4uHvdoA2qEQ1x3G0d3jTxScJ34kxbl70H60n77mOM eNB44sQQOJIHDc0UxhHtH5PA6VTI/g1/cs/R6ng7Vbs/jqEvPDeICfbO195ePR82b3Ff Ct1wPlTcbz6cck4yuGSGfnrYym2YYj0P1+RizLWj91vPR6ki9reCupF4ZfR4yb8lhV9y 6APg== X-Gm-Message-State: ACgBeo1cbpIdVdrhGv//nB2izABjJAegYsVXuw9+1yh8x0T7pgCFyjee hPYdM18x5IBmycj6IHQcTixkHhPw+fl3qet7y/rpkg== X-Google-Smtp-Source: AA6agR53syAuFCxMC5jPl66C8lWNug01/UM+Q3l+8Iaatq6b22RcIEBqU7NnV0Jd0WyjriPxcN5ew/70t+IrqLbxtnk= X-Received: by 2002:a17:907:1c0b:b0:77e:7da8:f6ed with SMTP id nc11-20020a1709071c0b00b0077e7da8f6edmr4079086ejc.309.1663036453344; Mon, 12 Sep 2022 19:34:13 -0700 (PDT) MIME-Version: 1.0 References: <20220817202538.21493-1-leoyang.li@nxp.com> <20220817202538.21493-2-leoyang.li@nxp.com> In-Reply-To: From: Olof Johansson Date: Mon, 12 Sep 2022 19:34:01 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon To: "Russell King (Oracle)" Cc: Li Yang , shawnguo@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hou Zhiqiang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_193416_814262_86320CD1 X-CRM114-Status: GOOD ( 30.09 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 12, 2022 at 1:33 PM Russell King (Oracle) wrote: > > On Mon, Sep 12, 2022 at 11:54:06AM -0700, Olof Johansson wrote: > > On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson wrote: > > > > > > Hi, > > > > > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang wrote: > > > > > > > > The original dts was created based on the non-production rev1 silicon > > > > which was only used for evaluation. Update the PCIe nodes to align with > > > > the different controller used in production rev2 silicon. > > > > > > How can I confirm what version of silicon I have on a system? > > > > > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > > > > > # cat /sys/bus/soc/devices/soc0/revision > > > 1.0 > > > > > > And I will be really grumpy if this system stops working. It's what I > > > use to do all my maintainer work, even if that's been fairly dormant > > > this year. > > > > > > It's overall setting off red flags to update an in-place devicetree to > > > a "new revision" of silicon instead of adding a new DT for said > > > revision. 2160A has been on the market for several years, so it just > > > seems odd to all of the sudden retroactively make things > > > non-backwards-compatible. > > > > Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe. > > > > Shawn, please revert, and be on the lookout for similar problematic > > approaches in the future. Thanks! > > I think you may also need to beware of the MC firmware revision - I > seem to remember reading in the changelog notes for it that NXP > dropped support in the MC firmware for the older silicon, though I > may be misremembering. It's been a while since I really looked at > the LX2160A from the point of view of maintaining or developing > anything for it. Yeah, and if anything this speaks against trying to update u-boot/EFI on it to something newer, bugs in firmware or not. -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel