From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD6A4C6FA83 for ; Mon, 12 Sep 2022 18:55:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+/wyaUjIjBBnLf1vCtzwTUWHjlVC7O7zzaQxNxV01i4=; b=VJPMAL64kVXqZ5 mkixEMT4Tle0RqXJaN5BT7vofW3q7W7kpcxBXBg2ql6TmUj1I8DKhfA+o9fel8X+R0hsvM/ygLO6L mtD8JZY89V3+8akHiajZeRiY/r4sIEj77WjE1cqUNjyhV+ouFizAuf47URghOvZ9EbYLk0l0IxhyL flv6PMGNO2bTH7gtkSri3WgvJ1uIScndH8jE/5dq2Nj3DcYmGeY5mCVF6V2T1de2v1PdYPuaouZ2b EJPd6Pn0OM71gIRpLr2ZRijv8ADGMglEeP37guuN0Qr4vfVaZkzUtm6rTGe2r9rHU/22R+DoPfHeC j2U8K8rwHpv9MNJc8ksw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXoZd-00ChWo-Qa; Mon, 12 Sep 2022 18:54:25 +0000 Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oXoZa-00ChQx-LL for linux-arm-kernel@lists.infradead.org; Mon, 12 Sep 2022 18:54:24 +0000 Received: by mail-ej1-x62f.google.com with SMTP id r18so22329516eja.11 for ; Mon, 12 Sep 2022 11:54:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=s6eyAy8fsLw07yjiJG3Y3WBiJuoGSCNuzrzQdigxyeM=; b=askJsOGRMViVP9TH+eLx5gdy0vVV+seDJ07sDVdRCd9w9rv5EorVk3WrM6eBPX1GDv 1WVho2cEul8r5RZBSPX60xC7/NDqWE3KXxOCf+UjpLVSLoN7HjaXhPDO6OkP2YCfRWLo im4RTcL6sR8LhO08eUFsuAgPRipICzT3OrczorC2ypefvcgyxi1gTWfM0iT/tK5mXIAi d4uB5Ir82U0Kpgm8wEsK0FSCfoP0IlPdy3mqkIIXF11zWxDIigtwQijzCxOHne4zt+NJ 3OdjOeGNCljXlTUUYbmpEUY/mBnEoDL2H/+6Fhe8XNAE3GvUSeTx/Kk5fl/KyoO3CgAu BM2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=s6eyAy8fsLw07yjiJG3Y3WBiJuoGSCNuzrzQdigxyeM=; b=rbk+cYwxqmWuGk3wxSt8C9a8HHZpRAfRXABE8I0oGpxB2uGGx8oHwCITORCHm+80Mf HnSSh5xIiHD+rAOp1BskWsZBrxd9JUwc71UlE0rdFHu7ofQg/513HYLB1ou/bWbR9v1p BwZGP4tmMV5jEl9pBiANO+/xzMPe3vUyIGPED2i60tGiQxrGpR2T4HXR6oHrkrFni3Ai 5wjm/VZlFzRfjFenz/XS8fuAmOu0CcLt8k1tsPSbTvdk45kGJEz/VmYHGehwuuUQ4XQ+ /1+36sZJfFgH2j/+uKKTzocPGHmE4+mZRFNNXipFVeQRL/7kxdK0SstMtqab8CpKB0kN 3KAg== X-Gm-Message-State: ACgBeo2Ow8qwn+iab8Bj90/GCtnTwRLr42BMEnQXJ3ARsBQOsSg988+1 lvJ7VtEt0S1LwWFnDnmPDcfQk9mUugRK2hHm+G9j6Q== X-Google-Smtp-Source: AA6agR5PZCpqVbSoRQoHff6UH1Bvdy/S60yTjJnaKok0R7uO2OjDQm9D8qrinN9WiJdngWGpT8DHhphXW/nHH2w44Uo= X-Received: by 2002:a17:907:1690:b0:77c:37be:2345 with SMTP id hc16-20020a170907169000b0077c37be2345mr6515986ejc.359.1663008858057; Mon, 12 Sep 2022 11:54:18 -0700 (PDT) MIME-Version: 1.0 References: <20220817202538.21493-1-leoyang.li@nxp.com> <20220817202538.21493-2-leoyang.li@nxp.com> In-Reply-To: From: Olof Johansson Date: Mon, 12 Sep 2022 11:54:06 -0700 Message-ID: Subject: Re: [PATCH v4 1/2] arm64: dts: lx2160a: update PCIe nodes to match rev2 silicon To: Li Yang Cc: shawnguo@kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Hou Zhiqiang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220912_115422_963797_3D7DCD32 X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 12, 2022 at 12:05 AM Olof Johansson wrote: > > Hi, > > On Wed, Aug 17, 2022 at 1:26 PM Li Yang wrote: > > > > The original dts was created based on the non-production rev1 silicon > > which was only used for evaluation. Update the PCIe nodes to align with > > the different controller used in production rev2 silicon. > > How can I confirm what version of silicon I have on a system? > > My non-evaluation commercially purchased system (HoneyComb LX2K) has: > > # cat /sys/bus/soc/devices/soc0/revision > 1.0 > > And I will be really grumpy if this system stops working. It's what I > use to do all my maintainer work, even if that's been fairly dormant > this year. > > It's overall setting off red flags to update an in-place devicetree to > a "new revision" of silicon instead of adding a new DT for said > revision. 2160A has been on the market for several years, so it just > seems odd to all of the sudden retroactively make things > non-backwards-compatible. Confirmed that this patch renders my HoneyComb unbootable -- PCIe doesn't probe. Shawn, please revert, and be on the lookout for similar problematic approaches in the future. Thanks! -Olof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel