From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31068C31E49 for ; Wed, 19 Jun 2019 13:33:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06B0820B1F for ; Wed, 19 Jun 2019 13:33:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eTXBBZmX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ra8QE7eB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06B0820B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bf1zj4KmDbCS7hejntIdM+EFtr/vufVn4V5MFtN10QY=; b=eTXBBZmXIFn8So oeBuk77Eo6mF5RSMa2oclnrAiM4c5QM1vjit7Nniw842niySdcGJToDA3kfD+ElPM5oxCWl7EPb4i BKnqyClt9kybL9veE9znU8Dgpht7Xtd4Z5O4HpyVjwO3qrD1/EOhF5XzdOZug66HxCuNB0sLAX4FN ruCbU13eIsDXQsDtNNOxhhP34X9BHY2zRWtatYJvgHeUNeXT09nP2vfrSQcmT28d3WrdzYHQJj3Gz gyXTLIc9WJ2ENQQjk0M1xTlvh3QkHvMQBcNXR3a/Fh3HaPHtXZ8Am0TRtqam+5JhQ+s8Tj0ZjP6Y+ SIl6Akjz7QbmbZ9pvAkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdair-0005b1-Nx; Wed, 19 Jun 2019 13:33:57 +0000 Received: from mail-ua1-x942.google.com ([2607:f8b0:4864:20::942]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdaio-0005aH-91 for linux-arm-kernel@lists.infradead.org; Wed, 19 Jun 2019 13:33:55 +0000 Received: by mail-ua1-x942.google.com with SMTP id z13so9822499uaa.4 for ; Wed, 19 Jun 2019 06:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/hOvNsnkdNjDa+A6/yfZ/Thg3iaWZ4X1bBVE79rdUH4=; b=ra8QE7eBnzaOXjOx0RMs0LZQe2kPZTC6xR1Rt/o70uPhVeniKXcCavDC3PrQDG92pU ErmTmVNphJLe6VZA2E7mn+lz4XP2Hn3Ji2Cdx9QWjH/COc1dbYOt0+uPQFwwzEzMXp8e 6Jj9ID6vXj/RGBIMl0BSHp9hJqpX8Z+7HM1tpHFG9eYWrQJcSWJszuCedusibuJmFTpE i9HIKEvITQsMqq8gOYlNfKCUqAcMK/IoydTG2YSBI9duQVaA5JX7MoE1cKslCGoH8HxB fq+n3cIcrKOae3POoib/yOj4IxWA4FqsIoc48CljZJfyOTagnzo8yQHI/J0LW8zpNYd2 hNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/hOvNsnkdNjDa+A6/yfZ/Thg3iaWZ4X1bBVE79rdUH4=; b=fBgDEA7iJRlxsiLImlPq2yrBdkK0uMPuTtEftYj17pcu9c+DwGZ8h2NzQP955QxpoB bovf/4qw5+m1E11GecLogWM6Kq5D7LHkGZFRmjxJAuRwt6UYJFKIoeSwXDztMaWz+sKC 3hMtaFP4Taj/wAfV6nwU2Mlh1sS9VfMw2lLjeUw8ekkKKwVP3VIY+04iRKoH73yhqj/Y DctNpEHRE2skz5qqDkIjYGbxMuM5DTvCvqb74cNlN/pzAIxV918ebkxK/CZ0nZAmXV3a fzUfzQCIolvfjls6JU6cyaiTyee0w1zi1PbjFg7gbuCpHCFNiN6aZlw34FQ+Ckmk8Ev2 XVSQ== X-Gm-Message-State: APjAAAUyBRBvB6Q9gNkoM3ed7SGQonn0jLn93uAZiJCOXsMEthyoBUZ1 FRErPO2pFydZriIWEN5aJauVdpU+te6nx8NFZR0A74TI X-Google-Smtp-Source: APXvYqzXc0QxvHUX0+Zq6+MSDbGCxesWmtXJbSYuo788EfEdCW+LbJBYo7MWWKhK0YKIbtRHuEZqD16YL5NCdT/noa4= X-Received: by 2002:ab0:6988:: with SMTP id t8mr22144122uaq.49.1560951231950; Wed, 19 Jun 2019 06:33:51 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Pintu Agarwal Date: Wed, 19 Jun 2019 19:03:39 +0530 Message-ID: Subject: Re: [IMX] [DRM]: suspend/resume support To: Fabio Estevam X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190619_063354_346313_E8617634 X-CRM114-Status: GOOD ( 19.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-pm@vger.kernel.org, open list , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Kernelnewbies Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 18, 2019 at 8:39 PM Fabio Estevam wrote: > > On Tue, Jun 18, 2019 at 11:46 AM Pintu Agarwal wrote: > > > Thank you so much for your reply. > > Yes, I already checked the latest mainline kernel changes until 5.2-**. > > I see that there are many cleanup related changes, but still I see > > that suspend/resume functions are missing in dw_hdmi-imx driver. > > Please see this recently submitted patch: > https://lore.kernel.org/patchwork/patch/1084057/ > Okay. Thank you for this reference. This can be definitely helpful. But a quick look may be feel, this is slightly different. Anyways, I will have a deeper look. > > So, I am trying to implement myself. > > Also, I see that suspend/resume is missing even in : > > drivers/gpu/drm/imx/ipuv3-crtc.c > > I am trying this also (not sure if we need this as well). > > > > Can you point out some specific patches which can be helpful ? > > > > Currently, what I observed is that hdmi bind() functions are not getting called. > > Not sure who is responsible for triggering this bind function. > > Or, irq remains disabled after resume, and we need to enable it back > > again (but how ?) > > Or, we may need to enable vblank events and thus irqs can be enabled. > > > > So, I am exploring many possibilities. > > If you have any suggestions please let me know. > > The suggestion I have is to try to use latest mainline kernel. If you > see any issues with it, please report. > > The combination you mentioned in a prior thread (kernel 3.10 + > backported drm patches 4.9) is not really something the community can > help you. You can think that the version I am using right now is almost 4.9 itself. Upgrading again to higher kernel version is again difficult, also customer does not want it. BTW, I am not talking about runtime suspend/resume. I know it works normally. I just need some approach and pointers. Like someone said rightly, I may need to re-implement bind() function again in resume path. I already tried doing hdmi_power_on/off and with that I could invoke hdmi_setup() function, but the system hang after that. Another approach I tried is, installing hdmi {dw-hdmi.ko, dw_hdmi-imx.ko} as a module, just after the resume. With this also system hangs during installation of dw_hdmi-imx.ko at below location: imx_drm_driver_load(..) | |--> component_bind_all(...) | |-> component_bind(ipu) | | ipu_drm_bind(..) | |-> ipu_crtc_init(..) | |-> ipu_plane_irq(..) | | ----> << __HANGS HERE__ >> | |-> devm_request_irq(ipu_irq_handler) So, ipu_drm_bind() never returns, and hangs. ---------- So, my question is, which approach is better (as a first trial): 1) Installing hdmi as a module, after resume ? 2) Or, implementing the suspend/resume itself ? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel